Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        ira.weiny@intel.com
Subject: Re: [git pull] common helper for kmap_local_page() users in local filesystems
Date:   Mon, 27 Mar 2023 12:20:23 +0200
Message-ID: <2729240.9PvXe5no7K@suse>
In-Reply-To: <8232398.NyiUUSuA9g@suse>
References: <20230310204431.GW3390869@ZenIV> <8232398.NyiUUSuA9g@suse>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On sabato 11 marzo 2023 18:11:01 CEST Fabio M. De Francesco wrote:
> On venerd=EC 10 marzo 2023 21:44:31 CET Al Viro wrote:
> > 	kmap_local_page() conversions in local filesystems keep running into
> >=20
> > kunmap_local_page()+put_page() combinations; we can keep inventing names
> > for identical inline helpers, but it's getting rather inconvenient.  I'=
ve
> > added a trivial helper to linux/highmem.h instead.
>=20
> Yeah, "put_and_unmap_page()". Nice helper :-)

[snip]

Hi Al,=20

> Why did you name it "put_and_unmap_page()" instead of=20
"unmap_and_put_page()",
> for we always unmap first _and_ put the page immediately the unmapping?
>
> It seems it want to imply that instead we put first and unmap later (which
> would be wrong). That name sounds misleading to me and not sound (logical=
ly
> speaking).
>=20
> Am I missing some obscure convention behind your choice of that name for =
the
> helper?

Can you please explain what I'm missing behind your motivation?

Thanks,

=46abio

P.S.: Adding Ira to the Cc list, since he's been doing kmap() and=20
kmap_atomic() conversions long time before I too started with them.