Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 27 Mar 2023 20:30:02 +1000
Message-Id: <CRH3GJDNC4SF.2HBIHLLQSCWSI@bobo>
To:     "Kautuk Consul" <kconsul@linux.vnet.ibm.com>,
        "Michael Ellerman" <mpe@ellerman.id.au>,
        "Christophe Leroy" <christophe.leroy@csgroup.eu>,
        "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        "Sathvika Vasireddy" <sv@linux.ibm.com>,
        "Alexey Kardashevskiy" <aik@ozlabs.ru>,
        "Fabiano Rosas" <farosas@linux.ibm.com>
Cc:     <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] arch/powerpc/kvm: kvmppc_hv_entry: remove .global
 scope
From:   "Nicholas Piggin" <npiggin@gmail.com>
References: <20230327100411.3342194-1-kconsul@linux.vnet.ibm.com>
In-Reply-To: <20230327100411.3342194-1-kconsul@linux.vnet.ibm.com>
Precedence: bulk

On Mon Mar 27, 2023 at 8:04 PM AEST, Kautuk Consul wrote:
> kvmppc_hv_entry isn't called from anywhere other than
> book3s_hv_rmhandlers.S itself. Removing .global scope for
> this function and annotating it with SYM_CODE_START_LOCAL
> and SYM_CODE_END.

Does removing .global introduce the objtool warning, or was it already
present? Just trying to understand if this is two changes or one (not
that it really matters, maybe just for the purpose of the changelog).

Since the patch only touches KVM, subject should follow arch/powerpc/kvm
convention, which is not the same as the rest of arch/powerpc. KVM: PPC:
Book3S HV:

Otherwise seems okay

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

Thanks,
Nick

>
> Signed-off-by: Kautuk Consul <kconsul@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/b=
ook3s_hv_rmhandlers.S
> index acf80915f406..0a9781192b86 100644
> --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> @@ -502,8 +502,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S)
>   *                                                                      =
      *
>   ***********************************************************************=
******/
> =20
> -.global kvmppc_hv_entry
> -kvmppc_hv_entry:
> +SYM_CODE_START_LOCAL(kvmppc_hv_entry)
> =20
>  	/* Required state:
>  	 *
> @@ -940,6 +939,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_HAS_PPR)
>  	ld	r4, VCPU_GPR(R4)(r4)
>  	HRFI_TO_GUEST
>  	b	.
> +SYM_CODE_END(kvmppc_hv_entry)
> =20
>  secondary_too_late:
>  	li	r12, 0
> --=20
> 2.39.2