Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 12:40:22 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Tudor Ambarus <tudor.ambarus@linaro.org>
Cc:     Christophe Kerello <christophe.kerello@foss.st.com>,
        richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2 1/2] mtd: rawnand: stm32_fmc2: do not support EDO
 mode
Message-ID: <20230327124022.4bb32839@xps-13>
In-Reply-To: <a17cd888-ef4d-ced0-adba-c6a6abdba51a@linaro.org>
References: <20230327094742.38856-1-christophe.kerello@foss.st.com>
        <20230327094742.38856-2-christophe.kerello@foss.st.com>
        <a17cd888-ef4d-ced0-adba-c6a6abdba51a@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:29:56 +0100:

> Hi,
>=20
> On 3/27/23 10:47, Christophe Kerello wrote:
> > FMC2 controller does not support EDO mode (timings mode 4 and 5).
> >  =20
>=20
> commit subject and message should be in imperative mood, so I would
> change the commit subject to "mtd: rawnand: stm32_fmc2: Remove
> unsupported EDO mode" and the message to something like "Remove the EDO
> mode support from as the FMC2 controller does not support the feature."
> Extra points if you describe what happened when you used timings mode 4
> and 5 with the current version of the driver.
>=20
> Miquel, could you add Cc to stable when applying?
> Cc: stable@vger.kernel.org

Yes, absolutely.

>=20
> > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
> > Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND fla=
sh controller driver") =20
>=20
> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>=20
> > ---
> >  drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >=20
> > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/=
raw/stm32_fmc2_nand.c
> > index 5d627048c420..3abb63d00a0b 100644
> > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> > @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct =
nand_chip *chip, int chipnr,
> >  	if (IS_ERR(sdrt))
> >  		return PTR_ERR(sdrt);
> > =20
> > +	if (sdrt->tRC_min < 30000)
> > +		return -EOPNOTSUPP;
> > +
> >  	if (chipnr =3D=3D NAND_DATA_IFACE_CHECK_ONLY)
> >  		return 0;
> >   =20


Thanks,
Miqu=C3=A8l