Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 12:43:13 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Tudor Ambarus <tudor.ambarus@linaro.org>
Cc:     Christophe Kerello <christophe.kerello@foss.st.com>,
        richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode
 instead of checking tRC_min
Message-ID: <20230327124313.1ccd3d66@xps-13>
In-Reply-To: <75dcd205-5432-7103-370c-d65d792631ea@linaro.org>
References: <20230327094742.38856-1-christophe.kerello@foss.st.com>
        <20230327094742.38856-3-christophe.kerello@foss.st.com>
        <75dcd205-5432-7103-370c-d65d792631ea@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100:

> On 3/27/23 10:47, Christophe Kerello wrote:
> > This patch is using timings.mode value instead of checking tRC_min timi=
ng
> > for EDO mode support.
> >  =20
>=20
> Fixes and Cc to stable here too, as you'd like to have this backported
> as well, don't you?

Actually the reason why Christophe split this into two patches is
because timings.mode was introduced rather lately, he wanted the same
patch to apply on all stable kernels, he actually asked for that split
and I agreed (another solution would have been to send this current
patch to Linus and have the other version sent to stable, but it
requires a bit of scheduling on both ends).

Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t

>=20
> > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> =20
>=20
> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>=20
> > ---
> >  drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/=
raw/stm32_fmc2_nand.c
> > index 3abb63d00a0b..9e74bcd90aaa 100644
> > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> > @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct =
nand_chip *chip, int chipnr,
> >  	if (IS_ERR(sdrt))
> >  		return PTR_ERR(sdrt);
> > =20
> > -	if (sdrt->tRC_min < 30000)
> > +	if (conf->timings.mode > 3)
> >  		return -EOPNOTSUPP;
> > =20
> >  	if (chipnr =3D=3D NAND_DATA_IFACE_CHECK_ONLY) =20


Thanks,
Miqu=C3=A8l