Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fe83e6f62d802109024f6203cf0d50c1ef348da1.camel@dylanvanassche.be>
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: adsp: add
 qcom,sdm845-slpi-pas compatible
From:   Dylan Van Assche <me@dylanvanassche.be>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Date:   Mon, 27 Mar 2023 13:39:47 +0200
In-Reply-To: <8ab9d0c3-89f7-90f3-58d6-d2994d372518@linaro.org>
References: <20230325132117.19733-1-me@dylanvanassche.be>
         <20230325132117.19733-2-me@dylanvanassche.be>
         <8ab9d0c3-89f7-90f3-58d6-d2994d372518@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hi Krzysztof,

On Sun, 2023-03-26 at 10:53 +0200, Krzysztof Kozlowski wrote:
> On 25/03/2023 14:21, Dylan Van Assche wrote:
> > SLPI DSP remoteproc on DSP is defined by the 'qcom,sdm845-slpi-pas'
> > compatible in the qcom_q6v5_pas driver. Add this compatible to the
> > devicetree bindings.
> >=20
> > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> > ---
> > =C2=A0Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3
> > +++
> > =C2=A01 file changed, 3 insertions(+)
> >=20
> > diff --git
> > a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> > b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> > index 643ee787a81f..175be01ecd1c 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> > @@ -26,6 +26,7 @@ properties:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - qcom,sdm660-adsp-pas
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - qcom,sdm845-adsp-pas
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - qcom,sdm845-cdsp-pas
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - qcom,sdm845-slpi-pas
> > =C2=A0
> > =C2=A0=C2=A0 reg:
> > =C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 1
> > @@ -63,6 +64,7 @@ allOf:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 - qcom,msm8998-adsp-pas
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 - qcom,sdm845-adsp-pas
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 - qcom,sdm845-cdsp-pas
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 - qcom,sdm845-slpi-pas
> > =C2=A0=C2=A0=C2=A0=C2=A0 then:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties:
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clocks:
> > @@ -104,6 +106,7 @@ allOf:
>=20
>=20
> You miss also if:then: for power-domains.

I am not sure what to put for the power-domains, newer remoteprocs from
SM8150/SM8250/SM8350 etc. are not in this binding either.

Could you elaborate a bit here? Thanks!

Kind regards,
Dylan Van Assche

>=20
> Best regards,
> Krzysztof
>=20