Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2750634rwl; Mon, 27 Mar 2023 04:59:21 -0700 (PDT) X-Google-Smtp-Source: AKy350ZrdHuvEgxEoO9P8qcFPKTMYDZDSdIr7VvC2GGec3I+/vrLHJSl+d3CQyS4OyNIak5bqb0F X-Received: by 2002:a17:907:170d:b0:92f:f2cc:93 with SMTP id le13-20020a170907170d00b0092ff2cc0093mr11968790ejc.22.1679918360812; Mon, 27 Mar 2023 04:59:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679918360; cv=none; d=google.com; s=arc-20160816; b=qWrh7d+P/HfqOjnkErU3twwNRUF49zi5DCo2MDqQAzeDGM98bg5SqVhekHDJ8Ai6b4 8rVxct7Y7tVg1KuomOaM4o5Gbld14jWepyg4ZVndP5DdpyaU1pIwUnpVNdM68vVhT3VJ QoJbabxGfusbEm5opmABvpiAQlyl9pA3bs097shtSEWgoYCqUhEcgguUDo3UWDjOvZ5M hmzpxUrkwejDwD0hHEW7izVm4gMtHUM+YK+ogDR4GgZUjEFW2z6NBbQXhGUzHOT5LG0G W9JKd9uf+gFU71Lttvqnjq6bcMMRruMKD/bd5GyVUWScq7zUZ776PgmHqpmA6aDbklG9 DnBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4hqQuH8FOf+4pgkI9aRk5V0GjIEQtjLwKLeJDXprzLI=; b=iWGRxmaDyxYZxn/bKikPHiYZMJpGxJuCoPY4vtvqu3bLMs/VMP75QNvXx7VqjjlFoq v0NSDSDLBAbiGAhXPxdJVFmI8c9BhOB5iyPLA7g3GR6dUhPPUnJLt4JUAC03PHzN9834 8bBZeQCd6PGSNM2Bv8/U+YOT8ulhhd8vhjVsEv63M/F16Zh+E9tt+Qp4LU5An/PvvgAH jNPJiwJGkV0/8H+FDohzTGIY4y/LuYapcT0Foh6smygxkk3/M+jWZC+ZSuaMh0ff8M5+ iuVkcVQf5cBAbyV6Zkffb/4XYwSciO/hAC6CV3g+tjVHq7VkJlOT9Vg/COa5jfTHOf8U RFjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hgw4lNYi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k15-20020a17090632cf00b008d0a9a403f8si29274680ejk.796.2023.03.27.04.58.55; Mon, 27 Mar 2023 04:59:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hgw4lNYi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232519AbjC0Lvm (ORCPT + 99 others); Mon, 27 Mar 2023 07:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230041AbjC0Lvl (ORCPT ); Mon, 27 Mar 2023 07:51:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9536D2D46; Mon, 27 Mar 2023 04:51:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 49850B810E2; Mon, 27 Mar 2023 11:51:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAA67C433D2; Mon, 27 Mar 2023 11:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679917898; bh=tkUKHXUOdkTFseJ4nMnQlFeH70mDuPicL36cxP8wSBM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hgw4lNYiuvCorBcv1OFHp3G4ha5Vd/AKzqSNTJx0TkyTItpNScXqDXlVr3PyiArEG dZTEgcajIDU0D8I64kN57F+0liO88s31pb9nCuzaYxymrgBQyzjVi9BLma/nvdNf4a zpoAgusmveHLJC9N4W/b26C90NjwHUnrLwpu0eSU= Date: Mon, 27 Mar 2023 13:51:34 +0200 From: Greg KH To: Mathias Nyman Cc: mirsad.todorovac@alu.unizg.hr, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ubuntu-devel-discuss@lists.ubuntu.com, stern@rowland.harvard.edu, arnd@arndb.de, Stable@vger.kernel.org Subject: Re: [PATCH] xhci: Free the command allocated for setting LPM if we return early Message-ID: References: <20230327095019.1017159-1-mathias.nyman@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327095019.1017159-1-mathias.nyman@linux.intel.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2023 at 12:50:19PM +0300, Mathias Nyman wrote: > The command allocated to set exit latency LPM values need to be freed in > case the command is never queued. This would be the case if there is no > change in exit latency values, or device is missing. > > Fixes: 5c2a380a5aa8 ("xhci: Allocate separate command structures for each LPM command") > Cc: > Signed-off-by: Mathias Nyman > --- > drivers/usb/host/xhci.c | 1 + > 1 file changed, 1 insertion(+) Do you want me to take this now, or will you be sending this to me in a separate series of xhci fixes? Either is fine with me. thanks, greg k-h