Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 09:18:39 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Kevin Tian <kevin.tian@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Remove unnecessary locking in
 intel_irq_remapping_alloc()
Message-ID: <ZCGJn3QWhQl4F1dI@nvidia.com>
References: <20230314051836.23817-1-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314051836.23817-1-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oTfT+Biwo4VTjxxrKm4xJhFXp0JZy0YRq0vbJORBXrE32MRYsD9SccUL2+hU?=
 =?us-ascii?Q?t2F2Z7w0gmSXyoP4UvG1NXhPp1TR/Mi+fe2rgJOmowo1LVr9uxAVBKEvt+NQ?=
 =?us-ascii?Q?NKwsDpiINGEj+J52BMy0l046M1hMxPB5Smt2zXjRR3F7OBCyxKiyJIBHu6M9?=
 =?us-ascii?Q?YN6nIzUIkGsoMjN/++5PgmmYQpQ5Ed/NzSY1Oqt0FBHUWBsTEcLmzqqlEM2C?=
 =?us-ascii?Q?lx7UT5jako/3WL/79rmLkypJPc13FHSuy4ZeTlfoC18cHswXpxKw9Q/q72oX?=
 =?us-ascii?Q?iwFWYYUHx+xQXTg/tFbTBA/trAsT/6GGtHWIzrOsU2GH8EpqeHM1qQduvgI/?=
 =?us-ascii?Q?qlkm/5noh9iNwYTMK5YC6FBWC4gdEYLS1/4XsVXCPv1Fz5oJElbp0VLEz3eI?=
 =?us-ascii?Q?z2OdckuADfgDIJexvORgCXatl1lad7LqqQdb6eqv/A2QO9nLs6sfxzgYzBAt?=
 =?us-ascii?Q?sRvv8+PREwb+ZcqN4p4Qgrfp6kshSPyCVZ1oXaxPW5bKg8XiGHbyZh4pF979?=
 =?us-ascii?Q?+vg5AxPrKK/MWFLtYkiEtCNQvyenztNkPk2/fAcDbrgYY3DFqFzEb5ApnhXe?=
 =?us-ascii?Q?aPB0kpM17WCSd/XfoeH5U617AGv5QrGkpVZ27RaFr++Rfkh5/t3ftWM4wJub?=
 =?us-ascii?Q?ipNMLGoWvH2yhUlNp2+AkgiUSTzWLGAG4niW9S6lHzPabuvz+cCou8SixUms?=
 =?us-ascii?Q?zxk3FtXnDvpuuGD5cCvhCseq//2OMLEQvwcU+weBeU3KltmqLVqxneX5ESdR?=
 =?us-ascii?Q?K2qEaQWqJO7ZslESaN55Ar26Q5Nap1kVkTA/yB6nrfe0pXrnefW/IzBVWvRI?=
 =?us-ascii?Q?4PypSKh11lKzfX70xfQ9WJRsFCo85etH95ed1SSA+0sw/307IifB+vMf0gUh?=
 =?us-ascii?Q?jICmu9Wfw/As/K2W1dHiMB5wD/ZjhZILHTdbtDxw3KL3/rZq5rCDNfzIviEK?=
 =?us-ascii?Q?j5ZDyxOPp/YkDDLuV8KP8YbJB5WsN5QU4FBmxQrkIZ46j0AbZj9DSsqYYuX/?=
 =?us-ascii?Q?UkzbmX58TRgdaJ05o/+juobKEtLqKY6eGdgq+SxvqM7ZFJ8k21R9+nzX0Jvh?=
 =?us-ascii?Q?AoC67TVqtjgZjcwiFksEmZxt2LC3cLE49kGYb3ZOdOpJuYldDRdPNTXqnW8G?=
 =?us-ascii?Q?52fQrTUqQJ4mQNjqRai25M4XsRa4/XgLRIuuxXTJgklETjEubjR0+t2jzsd8?=
 =?us-ascii?Q?L4Zjl0blN3XsudITNAinfxXtuvzBaScjgLWjXUNeYUf4TB23TSIMEfYoqiz2?=
 =?us-ascii?Q?uxuEot+TKFqiDCwTKs2Yr2qoH7hM2knmh09jZSsDk2AQ921J4bPmUUTuO1HY?=
 =?us-ascii?Q?ss3xylGDa6WBUGmkJmR+mnWI5cfNHBh2JXHFKOGhlq9WR3yy0No0DVFz97NP?=
 =?us-ascii?Q?zIxyD/dTowyy5akGBtpzamW0HHSOe+Jz7bgtiGjecBQIpztrKSaqs1HYluPd?=
 =?us-ascii?Q?gWME8d4rwK52gbb5fOCz6gKJf64q5zhmtJqC4FjouXiSd2d92ZvXbl4MMD4T?=
 =?us-ascii?Q?QRc17C2p5gM3dwXWBKDO3ZFWPxQNzQTca4S4V9Zfik8NdC4Z9kMlqxtFMlX8?=
 =?us-ascii?Q?sg9x9TfH8ZhGu7BK98o=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74ad122e-f86b-456c-e189-08db2ebd66df
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2023 12:18:41.4732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J4KfEENiDPk9s+MkJKVuPh5Y0xUiRnQV/0G+bARftggNEXG8iFMrJWlStw66d0P7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6562
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 14, 2023 at 01:18:36PM +0800, Lu Baolu wrote:
> The global rwsem dmar_global_lock was introduced by commit 3a5670e8ac932
> ("iommu/vt-d: Introduce a rwsem to protect global data structures"). It
> is used to protect DMAR related global data from DMAR hotplug operations.
> 
> Using dmar_global_lock in intel_irq_remapping_alloc() is unnecessary as
> the DMAR global data structures are not touched there. Remove it to avoid
> below lockdep warning.

Tested-by: Jason Gunthorpe <jgg@nvidia.com>

Solves my splat too

Let's send this to -rc please

Jason