Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f4420d0-2f86-7294-01e1-6806ef7e4686@nutanix.com>
Date:   Mon, 27 Mar 2023 14:59:37 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: [RFC] memcg v1: provide read access to memory.pressure_level
To:     =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Shakeel Butt <shakeelb@google.com>,
        Muchun Song <muchun.song@linux.dev>,
        Andrew Morton <akpm@linux-foundation.org>,
        cgroups@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230322142525.162469-1-flosch@nutanix.com>
 <20230324150350.fu7itbqqvtjmyf3s@blackpad>
Content-Language: en-US
From:   Florian Schmidt <flosch@nutanix.com>
In-Reply-To: <20230324150350.fu7itbqqvtjmyf3s@blackpad>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T296dkRnUVArS3d2VllGYU5aOG9JQ3ZVL0xGQ1QzZHRxblpYTHJic1J3Vk12?=
 =?utf-8?B?SzFuQmRNaUJYQm02TnpNRXpLNGRET1U0ZEFTOEZPaVdXN0FQWWMybmVwbERO?=
 =?utf-8?B?WVVpVGJkUDdwVC9nZ2tXM240aXlxTmFlRnV3L043bmxVOWFBNGFCbThHeURP?=
 =?utf-8?B?MGtLcFMzenpmZVNVNm1uZElSa1pYOG5SN2pyUnUvZ3B2ZkRmRGVQVGgzVWh5?=
 =?utf-8?B?TGlLUG1YajVKTnBoaGpiZXJjdzBvbUorMjgxZXVFLzZMa0tUQk5ZNGJuK0M4?=
 =?utf-8?B?enlLQjlFbDQwUUR6V2w1NXFJYm5sRi9MZURrRnBNbUk5ZUJpYXJvajdDUXZa?=
 =?utf-8?B?bWJEc3FQdWVoWWN0eGxidGxIS0l1am9zd3ArSnFHUU51bTAvYkNieXFIWWtt?=
 =?utf-8?B?NnRueVlNYUhtVU56ZlkwcGd3diswb3k3MS9kNEd1S21lc0VSaS95WFVXZ3J1?=
 =?utf-8?B?dlk4OUx2clpRanNmUFd2d29PemZVRTY1c0p3K3hlSGlpbXRsd3U5R2s5U1V1?=
 =?utf-8?B?TkVDaThCbUt4UGticnBSOTRVWGR6Tis4a3FYTHo4SE5GUythem5lVG1xbk8r?=
 =?utf-8?B?SHBkd2lqMm5lSXQzVXMwN1NuR1NSNitVUDZESFdWa05GRk9XaEJCcmdleVFh?=
 =?utf-8?B?cUtYSU5nN2h5SFpvUWM5SG14S1ltcXhrcloxV09BUW5xdjJudWJtNWlOV1Nj?=
 =?utf-8?B?MlZTTUcyN0pIZVBqYnYwRTZOTFhXWXdQbEJ2S2M3alZ4VE1pcy9TOFo2KytO?=
 =?utf-8?B?TmFXc3JaUXlFZkZxTGFvM1cwRm5VZjFWblk2T2VYTzNYeG13MjhRUko4RTJn?=
 =?utf-8?B?MXRvYmFTN2hPdHQwWGdvSUs2d0JydjRPTDV1VUJ4WHpueHExaW50SzR0UWV5?=
 =?utf-8?B?TnU3YmhMd0svK3VZUTVKUFpCMFlldm41MXJ1R1kvN284eVgvZlVpNGtJTU55?=
 =?utf-8?B?NUlob1Y0SEpHSmpiaDAxa252akprTVNkTWxTVit6WGxjcVMrVk1IcFN1eWVr?=
 =?utf-8?B?cm40VlE5aUdNS0FIV3FmQzE4YTltK2E0cVJtakgwOVk1Yjk3b3BWbnZ1L3VM?=
 =?utf-8?B?RkkyNEVsSDlNT2VISDlFZ0Z5ZDhONVExblQyOGRqN1l3Q1ZWVWk0dmNhVWZ5?=
 =?utf-8?B?andCaE1mVVhHaVp3eTA4OEhkOHRJSE5ybnBXOGZQOFRYbzRYVVMrS051UEt3?=
 =?utf-8?B?MFFlYm9OUWJkRUpNcDAveEpYY0VtODZHSkhFY3RSWWtPVnVKdDdhanlHN2dV?=
 =?utf-8?B?WGhGTmJkZk55RmMxZmN1QmFQaW5mVnFJWmlkdVdxYnNUd0xPdHBrZlQxQ0hs?=
 =?utf-8?B?dkVtUXg1ekdWYkVrMStMK0RiWGhFeFR6dnlMdVpObGNPQXpNTzgzRUp4NHQ0?=
 =?utf-8?B?ME12T0VZaGN5eCtIU1k1ZExGdHgwdTE5SjIxQy9lbXF2R21ITGhTM0tIQ1Br?=
 =?utf-8?B?N0VGSTN0a2d4dlhoYzdlS1VheUNSRzlHNHFjbEM5SFRvNzhDWEMvTGJadXZR?=
 =?utf-8?B?cmlFUHQ2aGFHc0trM1pCRkxIeGxxSUJibUpzN3pUaGpra1hFNS94ZmJjMDJy?=
 =?utf-8?B?VmJtM2tIMEtPbUFyRWFWb05PSmtQYmFBY2dtZzBiQ3VuR2hiMHdJZTRDRkpM?=
 =?utf-8?B?Z0ZWYllsUlcrWXRqS1ZqS1ZRTjBURTVXaVZhVVlFMkNUejVtOUZkOVdmdHRw?=
 =?utf-8?B?V3NqaEhraUo1V2srNVVVRUFKNURXUkliRjM3bVVtTVpFeXNSZ0JnbG4vMEtB?=
 =?utf-8?B?TkxZWEV4VnRubFRIY1Jhbi9xRVh2UTZsTjZybFhWeVE1NXVVbHlTemI3MG9v?=
 =?utf-8?B?MHB1SXhYZ1hwSUFOWStNZ1YwdkNkdVJuTHhMVkRFVFRQWlc3eDl2OXJ4UWEy?=
 =?utf-8?B?Q0lYSUlJK0dCVzZpK0F6WC9BckRjZ290NGNRRG90czVDQU56WllUWkxOMnFJ?=
 =?utf-8?B?OHI4QjdiWWp5c240N29wc3hWQ2VQNWxWOWNVd1hRc21QWmtpb0dsZ3ZrOGds?=
 =?utf-8?B?a1ZKRytJMFBFZFZZSm5qK1UzVlluZGc3Sy9KbGJBZW5ZR3ZjL3Q1YUh6ampE?=
 =?utf-8?B?NnhrZ0NsTk5ncmRxTWlQUG9kSlNhMmNwazNicy91SXVINHdBZDV2d3Voblg3?=
 =?utf-8?B?VjdRRlZjUmV3UkZXRnBwVDc1am5ZQTRyVnFORkF1Y09abXNzSTloTWNGUDRT?=
 =?utf-8?B?M2c9PQ==?=
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83713e37-0f3a-42cd-42c3-08db2ecb877a
X-MS-Exchange-CrossTenant-AuthSource: BL3PR02MB8217.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2023 13:59:49.0976
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RSt5OCEvB83rBl4SZg2NFJ8VMYGyGa4smz+rAqmd7pLVDeHTAfoJrekD1dM1Ma8OOk1/9pUIW/IIwECF1dHlT1A0cxT978bknJzNYj3gRtQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7629
X-Proofpoint-GUID: updZuJLp8r7V3RxbuJolT82p6OJ0z8o0
X-Proofpoint-ORIG-GUID: updZuJLp8r7V3RxbuJolT82p6OJ0z8o0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-24_11,2023-03-27_01,2023-02-09_01
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michal,

On 24/03/2023 15:03, Michal Koutný wrote:
> On Wed, Mar 22, 2023 at 02:25:25PM +0000, Florian Schmidt <flosch@nutanix.com> wrote:
>> cgroups v1 has a unique way of setting up memory pressure notifications:
> ...
>> There are several ways around this issue, but adding a dummy read
>> handler seems like the least invasive to me. I'd be interested to hear:
>> (a) do you think there is a less invasive way? Alternatively, we could
>>      add a flag in cftype in include/linux/cgroup-defs.h, but that seems
>>      more invasive for what is a legacy interface.
> 
> You can (as privileged user) modify file perms in userspace first (e.g.
> chmod o+r memory.pressure_level) and then it can used by non-privileged
> users. (Or do LSM prevent you from that too?)

That's true, we can work around this in userspace (though it means you 
need to give the process additional permissions, to change file 
permissions on top of just reading and writing).

Though considering that the memcg_write_event_control() explicitly 
checks whether the caller has read permissions on pressure_level, it 
felt sensible to me that the file would be created with read permissions 
in the first place, just like all the other files are created with 
permissions that are suitable for their immediate use without having to 
manually change permissions. The current implementation feels 
inconsistent in that way.


>> (b) would you be interested to take this patch, or is it too niche a fix
>>      for a legacy subsystem?
> 
> I'd rather not extend this "unique way" with additionally unique dummy
> helpers.

I understand that this is all code that has no modern user any more, 
which is why I tried to keep the fix as self-contained as possible.
Another option would be to have a special handler in cgroup_file_mode(), 
but that feels a lot klunkier to me, and leaks a v1-specific behaviour 
into the shared cgroup code.


Cheers,
Florian