Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <09fbe342-7bf2-fd51-f401-d88e787078a4@linaro.org>
Date:   Mon, 27 Mar 2023 16:12:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
From:   Neil Armstrong <neil.armstrong@linaro.org>
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH v2 2/3] perf/amlogic: resolve conflict between canvas &
 pmu
Content-Language: en-US
To:     Marc Gonzalez <mgonzalez@freebox.fr>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Jiucheng Xu <jiucheng.xu@amlogic.com>
Cc:     Marc Gonzalez <marc.w.gonzalez@free.fr>,
        Pierre-Hugues Husson <phh@phh.me>,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230327120932.2158389-1-mgonzalez@freebox.fr>
 <20230327120932.2158389-3-mgonzalez@freebox.fr>
Organization: Linaro Developer Services
In-Reply-To: <20230327120932.2158389-3-mgonzalez@freebox.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/03/2023 14:09, Marc Gonzalez wrote:

I'll fixup the commit message while applying.

> According to S905X2 Datasheet - Revision 07:
> 
> DMC_MON area spans 0xff638080-0xff6380c0
> DDR_PLL area spans 0xff638c00-0xff638c34
> 
> Round DDR_PLL area size up to 0x40
> 
> Fixes: 90cf8e21016fa3 ("arm64: dts: meson: Add DDR PMU node")
> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
> ---
>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index a5653ab1f0b43..1aab65bb5f578 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1585,6 +1585,12 @@ canvas: video-lut@48 {
>   					compatible = "amlogic,canvas";
>   					reg = <0x0 0x48 0x0 0x14>;
>   				};
> +
> +				pmu: pmu@80 {
> +					reg = <0x0 0x80 0x0 0x40>,
> +					      <0x0 0xc00 0x0 0x40>;
> +					interrupts = <GIC_SPI 52 IRQ_TYPE_EDGE_RISING>;
> +				};
>   			};
>   
>   			usb2_phy1: phy@3a000 {
> @@ -1710,12 +1716,6 @@ internal_ephy: ethernet-phy@8 {
>   			};
>   		};
>   
> -		pmu: pmu@ff638000 {
> -			reg = <0x0 0xff638000 0x0 0x100>,
> -			      <0x0 0xff638c00 0x0 0x100>;
> -			interrupts = <GIC_SPI 52 IRQ_TYPE_EDGE_RISING>;
> -		};
> -
>   		aobus: bus@ff800000 {
>   			compatible = "simple-bus";
>   			reg = <0x0 0xff800000 0x0 0x100000>;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>