Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2961308rwl; Mon, 27 Mar 2023 07:33:17 -0700 (PDT) X-Google-Smtp-Source: AKy350anOKe2j648TlQj3WyUGNxzufEYuV6jLizLbInRrDHG0L9DbbXCs92bnCXCZaMJ7t4lkB/4 X-Received: by 2002:a05:6402:125a:b0:4fb:4f1a:d4e1 with SMTP id l26-20020a056402125a00b004fb4f1ad4e1mr10804972edw.37.1679927597723; Mon, 27 Mar 2023 07:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679927597; cv=none; d=google.com; s=arc-20160816; b=lj9IdFVf5hJ7IB2Rb7NBpmFxyrYcCBsPl0jh6F+JMHgaMsAJaghRfV4gekucA9bgEu WPE7WZIdbnAQmOeMhQq8/dLocslDJhCLB8+VsilmQTFe4L1L2eFPasujwE+K1s/PzVYD /M5glpmDiLyPszQsLTISzDhj/KqmUvV7lFdYDoRffGg3Jqpz9MnlVqBfqXufIuIJ+5Pd 40dwYZKcBQ/C1ILNGJl+JWTHoM/YXcIBJsYSC4/utDGW2ICB9sVIx48suFKrFPWTDaum uVaGYMFepUPOxKcJyvhQvcE8YBPiVEWwSIrC0uGhhiH824ww4SKTKztYIfPtvX+AnAi3 xuYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=b9eLalqstdpKeNqF0JPU3M2QxGoZ4TRTo+/fHn6qaXM=; b=bjpwVZh7EAHBHEP6vvR57vU/idU2IzV2jZqXUwYD6GPIqymCuneAZb8PVaSZu8OGrq os+HbeXLqgpjFg6qd6y73qmON7QWKk7N2X0Rpho1r4bKbNkRooFTrJ97eb7aPioAhwnq 3Vx6zDVkUy4SiwKvzDw6yo5j9bMntCiYXe7TwKZr5txQQzhHQSkIsQ9MGNmXXQTk2G20 pckDKMFa+aVFtLRZC973UrC4AevYyfPSuB99rPcludOuaOmUp9QidYxQTIEAfL3WsrJ+ 6dn0rG/O+SLtyRvdxq9nCu0WDo0qKm7Aak4NlfbYoJ4Rg3YggSrCAuOFRus7sK9YMQEQ OEhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DMv4vCRr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020aa7d608000000b004aab3450a00si6320233edr.498.2023.03.27.07.32.51; Mon, 27 Mar 2023 07:33:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DMv4vCRr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232742AbjC0OcK (ORCPT + 99 others); Mon, 27 Mar 2023 10:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232632AbjC0OcF (ORCPT ); Mon, 27 Mar 2023 10:32:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAF994488 for ; Mon, 27 Mar 2023 07:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679927422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b9eLalqstdpKeNqF0JPU3M2QxGoZ4TRTo+/fHn6qaXM=; b=DMv4vCRr6yispJ+K8pSFWE3OgHWUGJlt1LVJJ+IlQnBRdJNedrCRPcH0Jk1OEcH9N4T56v qlT7kGIwRD0OFnGQejO3IJqir8OxgKHOOKmVZrtTvBnIq/Qe8vTEvrE2ii6be9dER/llA2 90oWo/tLUqqZnmT3S+slFFeUfVTclis= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-Z1AlmFmWNT-6e9yQScYTew-1; Mon, 27 Mar 2023 10:30:20 -0400 X-MC-Unique: Z1AlmFmWNT-6e9yQScYTew-1 Received: by mail-vs1-f71.google.com with SMTP id s12-20020a67c38c000000b00426234007dbso2637956vsj.1 for ; Mon, 27 Mar 2023 07:30:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679927419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b9eLalqstdpKeNqF0JPU3M2QxGoZ4TRTo+/fHn6qaXM=; b=zSRSOAKyvVk7ep94M98HCoHrdv9QnqIQomzPIrZBhtweuEpoTvWgBFswk1G+qM2jum 4ERGjgN57nkfQzxcRiCe+uIVq72Do9v91/YxLS06YIlE4paDmHYYg3B97iuIFoDqCd93 JPxyqWnDuAZSIdB1JMg/1Mmxcyu5mVe+FjoGWwN+CcLXP6FAIWvQ1JFEZ8/bdxuLGaGa J/Wbr4wP6hdYVTS7hkzExiWzXR7fRPcVf4rEj423cI6P6Wu8Rq6zT5eXI3h80X7kEEQj fK/dXL8L2RywEvonx5OymlZay1c322jFdK2Pjek320FeyqnZvZKWpuchANB4RUSXB1lY pcmQ== X-Gm-Message-State: AAQBX9ccKNxuyttQjswRINALshG21381lO4DjDEvhM8hqPOqZrXTEuAy 4A2zzPHOYcbgw4puRglcIRGhBGUaJMk2Gckr0NSF2CJGen+Zj/pel/jaGrw4Bujy3RKl19kZO5X olQKIoFAD9k85wFiVGrMgvtn8VMAUB7ix1/kEno1Lm+aCN02lDsg= X-Received: by 2002:a67:d38a:0:b0:425:f1d7:79f7 with SMTP id b10-20020a67d38a000000b00425f1d779f7mr4978431vsj.1.1679927419560; Mon, 27 Mar 2023 07:30:19 -0700 (PDT) X-Received: by 2002:a67:d38a:0:b0:425:f1d7:79f7 with SMTP id b10-20020a67d38a000000b00425f1d779f7mr4978424vsj.1.1679927419307; Mon, 27 Mar 2023 07:30:19 -0700 (PDT) MIME-Version: 1.0 References: <20230322093117.48335-1-likexu@tencent.com> In-Reply-To: <20230322093117.48335-1-likexu@tencent.com> From: Paolo Bonzini Date: Mon, 27 Mar 2023 16:30:08 +0200 Message-ID: Subject: Re: [PATCH v2] KVM: x86/pmu: Fix emulation on Intel counters' bit width To: Like Xu Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2023 at 10:31=E2=80=AFAM Like Xu = wrote: > > From: Like Xu > > Per Intel SDM, the bit width of a PMU counter is specified via CPUID > only if the vCPU has FW_WRITE[bit 13] on IA32_PERF_CAPABILITIES. > When the FW_WRITE bit is not set, only EAX is valid and out-of-bounds > bits accesses do not generate #GP. Conversely when this bit is set, #GP > for out-of-bounds bits accesses will also appear on the fixed counters. > vPMU currently does not support emulation of bit widths lower than 32 > bits or higher than its host capability. Can you please point out the date and paragraph of the SDM? Paolo