Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eea970cd-d781-9d4c-e020-9086505a4ba7@deltatee.com>
Date:   Mon, 27 Mar 2023 09:48:08 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Content-Language: en-CA
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230327073604.5449-1-cai.huoqing@linux.dev>
From:   Logan Gunthorpe <logang@deltatee.com>
In-Reply-To: <20230327073604.5449-1-cai.huoqing@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
Precedence: bulk


On 2023-03-27 01:36, Cai Huoqing wrote:
> Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
> because pci_p2pmem_dma() is already removed.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>

Thanks for noticing this!

> ---
>  drivers/pci/p2pdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..4f1798ecf38f 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
>  /**
>   * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
>   *	the specified list of clients and shortest distance (as determined
> - *	by pci_p2pmem_dma())
> + *	by pci_p2pdma_map_segment())

Maybe we should just remove the reference to pci_p2pdma_map_segment()
completely. I don't see how that function helps the reader any more and
is really different section of the API anyway.

Logan