Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3092604rwl; Mon, 27 Mar 2023 09:07:26 -0700 (PDT) X-Google-Smtp-Source: AKy350afrO33o7lMSmW40hweqPny3rlN4m1btLFSTNTvQjOySMbmOeC2hgHxd3V/qgghvf5Ifc+5 X-Received: by 2002:a17:906:8a41:b0:930:18f5:d016 with SMTP id gx1-20020a1709068a4100b0093018f5d016mr13149678ejc.15.1679933245733; Mon, 27 Mar 2023 09:07:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679933245; cv=none; d=google.com; s=arc-20160816; b=D33NppNOFnjS4HLPp9YkgZm+9g8U01EKM3tRLP/gLCVr9k64qj7AYTfq/OqkeVu8GQ zoY4xVo8vLKUf5K9NXyhXloudGsD0gNNSEgllAVmB8r4VBeNfeJapaoTOJX0p2ebbVTD CPPiPWLDTdws+No4p01IfDFnP/3UcqBbHuCyemkXtJRvlZEmkilhdGV4KC6zNaKUF+j3 tIAprrEyoI6o2RGjFnKicbDTxUDBX8vmfKjmQRF3sMJprHGnLpoAqBVYkLcSW1bcOhWQ mJd/9J95tZiQ5/2Nch2SdAQjGxWya25n1yxwvDZMcikinM8CicLVrxXLNGfFUOOYUGta nweg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RGwHI36+26alMOPcJARCf4i+u/nuff7mObHUT3LcJRU=; b=FP6O6yhexFpV5RzIgRnPknVKtoj20/mxjxDMwzY4tjcYIfP0z6r4/JuBKfzyhNcOb5 UIWvxiphReI1qYztSx98fkFfXpIA0iK1VxuarGM3K8aanWShvfjCPNIHNYPrkiedFOjo PL6Bc0Lb4vVZIWW8xVMJ2Dw3yVeRa2xQKLhUP2BABMRYyah0v0xZ0AucH4DMnAbRctsv DzElh/GwdNlaR077Aw4GI4p3nNicBSnCYIIgqDFFrwTv0oFAdnRAWQcjw+QTFAu+fnYa BCplCrrl1N0MF+qD5jahmjpTSkFHt27yulqqGATQr3sPzezCdpZSU8CK3a99ZRDZI/w+ joFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="LPLf/jCv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lc22-20020a170906f91600b00924c79a4314si26792674ejb.668.2023.03.27.09.06.58; Mon, 27 Mar 2023 09:07:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="LPLf/jCv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbjC0QFS (ORCPT + 99 others); Mon, 27 Mar 2023 12:05:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230289AbjC0QFP (ORCPT ); Mon, 27 Mar 2023 12:05:15 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64A74271D; Mon, 27 Mar 2023 09:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RGwHI36+26alMOPcJARCf4i+u/nuff7mObHUT3LcJRU=; b=LPLf/jCvgk6BbAdu2sWsjs0oNX 30l+yYDMt7lIPUZlX1xLPKvd+VVVQITd3MBjp55UXnh0lC27yas9PjZ1X8/Ke/FN2w5Z7mgrMqRNS NMe2iIKVClT29RE+YYzmxZbB3MjqVTlPCvQNedD6+P2DTM3qoHKrTsXd9k/l+Z6LWIlrLqO0i0LPP WcUrCoUENmgBRd1TwHHhU6kKgkRvL9EW+Kwg4gKazSQbHimCznogGlrnIrlhrYbEsmEYHmZgBhRO2 txegvcMIwswcdkNGLcJijBEGxeQVIVJr1oRDPP6IWPp68b1YWWkcPAIa7dwiPZZpdkAy2Plhs+eAH tVStJIQg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pgpLM-00Beeh-0e; Mon, 27 Mar 2023 16:05:12 +0000 Date: Mon, 27 Mar 2023 09:05:12 -0700 From: Luis Chamberlain To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, "David S. Miller" , "Rafael J. Wysocki" , Bartosz Golaszewski , Eric Dumazet , Jakub Kicinski , Jens Axboe , Johannes Berg , Linus Walleij , Minchan Kim , Miquel Raynal , Namjae Jeon , Paolo Abeni , Russ Weight , Sergey Senozhatsky , Steve French , Vignesh Raghavendra , linux-cifs@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: Re: [PATCH] driver core: class: mark the struct class for sysfs callbacks as constant Message-ID: References: <20230325084537.3622280-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325084537.3622280-1-gregkh@linuxfoundation.org> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 25, 2023 at 09:45:37AM +0100, Greg Kroah-Hartman wrote: > struct class should never be modified in a sysfs callback as there is > nothing in the structure to modify, and frankly, the structure is almost > never used in a sysfs callback, so mark it as constant to allow struct > class to be moved to read-only memory. > > While we are touching all class sysfs callbacks also mark the attribute > as constant as it can not be modified. The bonding code still uses this > structure so it can not be removed from the function callbacks. > > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Luis Chamberlain Luis