Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3119502rwl; Mon, 27 Mar 2023 09:27:06 -0700 (PDT) X-Google-Smtp-Source: AKy350YI9e7D7qsM4cmS0vcqSVZADmO2Q7vjGOsTZGo7MZl1GFg3+AYdDhch++OVCD+/qX+B0pUR X-Received: by 2002:a17:906:9f18:b0:930:f953:962c with SMTP id fy24-20020a1709069f1800b00930f953962cmr12104589ejc.1.1679934426557; Mon, 27 Mar 2023 09:27:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679934426; cv=none; d=google.com; s=arc-20160816; b=C+5nEH5jJu/6YgSy967YeDldKpmykQ8jbsxzfRYO9PybzNFhO5S2Bc6dbBmDtx/mAz TLHL+noYueG3/iKfKRDAjIukhZ+EPSC/QnPACTTUASPf9dkU5sKk6tsJjlIU93f6x2qv 4+Y3hPPEvu5REAckQ5BokqQixq/g2RAGZu45EqBLbK5ZSqxeoCq43dogXoaqA0VT3DLx CI/43cmX+57ouITZtlcDJwrMIlyPVxjatHtUvLxw6MBzPvr7C+z2d30P/AS/vq6W1TyZ rb3nO/KgS3t+G02v/Wnxawpp18r+bHybj8SLgyeFQWxGrTvUZ0RbK465n8Yw19X6UPT8 Oapw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=QlnmibugJa5DF6Dbq9WO+z/EeYR1Oyku4Ibk4pLFdb0=; b=bKWYujcje23wK9okAAGNmL5Vq2Bl1Ut1JmAj3xEI8un2+PJ4YiGB9vBN/t4jJzU1AR 9kvPzw28GtIEkky9Epbe5gBJ0/YKX9XqcwezdEBZIkwKGHOD1yUAKTSkdVPic0o3Uye5 l1Kn3fy0VXRGGHZ6SVK2Aj9D9YoxplH3TnpDx/p6rW01tGqrM3qvx3H4DMoTWk8e/lCc OQV9Yx8OLtmgLADPSxGfGI7WqyDv6FCcKt52fD0fldw+vhjNzFmVBoAQo4PG+0IQcWTx DXVvSV+fOldkmYDTmxKjwvo9d9QQZlPmCdoo+CpaB7Mow7T7bHU+XxsTvGPC0vZv5h2c 9qSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ER0K0555; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id tg3-20020a1709078dc300b009333dc25e58si22994939ejc.109.2023.03.27.09.26.41; Mon, 27 Mar 2023 09:27:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ER0K0555; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232025AbjC0QXm (ORCPT + 99 others); Mon, 27 Mar 2023 12:23:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbjC0QXk (ORCPT ); Mon, 27 Mar 2023 12:23:40 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3502BC; Mon, 27 Mar 2023 09:23:39 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id eh3so38451265edb.11; Mon, 27 Mar 2023 09:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679934218; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=QlnmibugJa5DF6Dbq9WO+z/EeYR1Oyku4Ibk4pLFdb0=; b=ER0K0555mp6hpb9v4Rjrc+Tt4pCLw+n8H4ax9oXtyxCQNDdhs9UE5bXkmyGYp9S1KA PVjPvcnf9dGCwNsNuohIfFXXjtEgbmAFotXzXvgPPaL/QlTRi6NudTosKtkuA/X4qMTh rbHJJtQRzFRioj62rSnd2Nre4PBumUWfQeSTzLCydRK6M5bhVJKkrV7F9KODRFvfAKEx aTegErg9WmpR6e6+Va8o93hsCN4CA/7nGPeKxr5Z1zz4HLWJreuV5xAvzJK8v4LYq1Re fiu4gGWTWepmNlTCUCKxnyFXZntVhLN6GPel5B5LlhUo4H+OzjwGc6r7qEQDWw0aOAAE y3GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679934218; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QlnmibugJa5DF6Dbq9WO+z/EeYR1Oyku4Ibk4pLFdb0=; b=KgANc3XEjAbI9JZ4SuhFRvorQxyO4vWKq3aqm/HoziuQCYDoJK6aCECC4aIN6IGerP cCcUPJR0g9NI6kHPmeIxJvdURfIo+aObhrAFdkve+N0aBQ5GqikZaTwT2B4Z4GXHokQr mDbJ2kfqA1UcpoUnaO4GglZBr+kXozAuVSoYzmOeVv68DFmPJWnKPdr9B9Nv+kc6cPcG Yot6IF6CtIgq0xGGPwEW4AUGYfVyvDyotZzesIrNoKtvXdqDaB8o7kWAD0cZoi7+eFIS JBR7Z8DfLyKXyRHjaTInv7+MGTFNuXLPDzOcUQCrJsKKpOceDi71OxERiH9mmj/69mHB BDmA== X-Gm-Message-State: AAQBX9cA2RIw7N7g3z+QVX69yxaCMCHXXy2fiw+wJhP1ms0cePfacHbU clZl90C+k58kYcpcmOPP2HHHDBgtWcdPB/wRdh8= X-Received: by 2002:a17:907:6e29:b0:93b:cd04:28 with SMTP id sd41-20020a1709076e2900b0093bcd040028mr6380267ejc.10.1679934218234; Mon, 27 Mar 2023 09:23:38 -0700 (PDT) MIME-Version: 1.0 References: <20230327-tegra-pmic-reboot-v3-0-3c0ee3567e14@skidata.com> <20230327-tegra-pmic-reboot-v3-2-3c0ee3567e14@skidata.com> In-Reply-To: From: Benjamin Bara Date: Mon, 27 Mar 2023 18:23:24 +0200 Message-ID: Subject: Re: [PATCH v3 2/4] i2c: core: run atomic i2c xfer when !preemptible To: Wolfram Sang , Benjamin Bara , Lee Jones , rafael.j.wysocki@intel.com, dmitry.osipenko@collabora.com, jonathanh@nvidia.com, richard.leitner@linux.dev, treding@nvidia.com, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, Benjamin Bara , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Mar 2023 at 16:54, Wolfram Sang wrote: > For the !CONFIG_PREEMPT_COUNT case, preemptible() is defined 0. So, > don't we lose the irqs_disabled() check in that case? Thanks for the feedback! PREEMPT_COUNT is selected by PREEMPTION, so I guess in the case of !PREEMPT_COUNT, we should be atomic (anyways)?