Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230322210227.464-1-mario.limonciello@amd.com> <20230322210227.464-5-mario.limonciello@amd.com>
In-Reply-To: <20230322210227.464-5-mario.limonciello@amd.com>
From:   Mark Hasemeyer <markhas@chromium.org>
Date:   Mon, 27 Mar 2023 10:37:25 -0600
Message-ID: <CANg-bXBBP61c1kUSKz6fgg2NfjHBO0sgXmqvV=AzUWBket6UFQ@mail.gmail.com>
Subject: Re: [PATCH v6 4/4] i2c: designware: Add doorbell support for Mendocino
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>,
        Grzegorz Bernacki <gjb@semihalf.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

>  static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
>  {
>         struct psp_i2c_req *req;
> @@ -87,7 +101,7 @@ static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
>         req->type = i2c_req_type;
>
>         start = jiffies;
> -       ret = read_poll_timeout(psp_send_i2c_req_cezanne, status,
> +       ret = read_poll_timeout(_psp_send_i2c_req, status,
>                                 (status != -EBUSY),
>                                 PSP_I2C_REQ_RETRY_DELAY_US,
>                                 PSP_I2C_REQ_RETRY_CNT * PSP_I2C_REQ_RETRY_DELAY_US,
The timeout error handling message after this has "acquire" and
"release" flopped.

> @@ -275,6 +291,13 @@ int i2c_dw_amdpsp_probe_lock_support(struct dw_i2c_dev *dev)
>         if (psp_i2c_dev)
>                 return -EEXIST;
>
> +       /* Cezanne uses platform mailbox, Mendocino and later use doorbell */
> +       rdev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 0));
> +       if (rdev->device == 0x1630)
> +               _psp_send_i2c_req = psp_send_i2c_req_cezanne;
> +       else
> +               _psp_send_i2c_req = psp_send_i2c_req_mendocino;
Thinking about naming again, perhaps "mendocino" should be dropped
from the function name as the logic applies to all platforms except
cezanne.