Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7539193-8374-cda6-f535-360a4a8eab22@nvidia.com>
Date:   Mon, 27 Mar 2023 09:58:19 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: [PATCH V4 04/10] dt-bindings: timestamp: Add
 nvidia,gpio-controller
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        robh+dt@kernel.org, timestamp@lists.linux.dev,
        krzysztof.kozlowski+dt@linaro.org, brgl@bgdev.pl, corbet@lwn.net,
        gregkh@linuxfoundation.org
References: <20230323012929.10815-1-dipenp@nvidia.com>
 <20230323012929.10815-5-dipenp@nvidia.com>
 <f523c155-7d05-2034-27ea-e2e56881c0bb@linaro.org>
Content-Language: en-US
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <f523c155-7d05-2034-27ea-e2e56881c0bb@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWJZd0tUY2FuR2RJbVRnOS9ZMGl5d0NsMytneUdKREtjTi9rQk80VWt4d1g1?=
 =?utf-8?B?NWVock9oeHpSdVprQUFhYVE3eTNsb1N5WDZPblYreFBwUnRwUDFPYTFzV2Fw?=
 =?utf-8?B?NERsOGM5SmlwK0JXK2xSeGhRUTV0OCt2d2VSakM5c29WWUJNOGFPOTRtRW91?=
 =?utf-8?B?SXVCcTZLKzh1MTdabzZDRTA3c1lHWXdKN2hlV1VvRFZUalZEeVdYeURtRjZy?=
 =?utf-8?B?RFhpVkFOMkFRbTF6bklJMHBGUHJHUlBvN0NJRDl3QmJuK3I4YUkwU0tRTWRk?=
 =?utf-8?B?RjZ4dURqUUNBbGhNY2xMVk5pNnVYZGJEUVJKZVpPamkzWGhjZXR2bHJyYjBE?=
 =?utf-8?B?STBjUkdNQXd6TmZMMGU3bTJlUldieFNVQ1UzbTZOblZNUFdhejVlSThwdjJ3?=
 =?utf-8?B?bEd2Q05sUmZyUDB6djEzUEhDWVlveWNlbEcxRFB4Uml6Y2NiNWh3dkZDWU5u?=
 =?utf-8?B?WWk0WStmcVN0U3ZSRC9OUXo3MjBPSEdyaHpDRGVKeDV1ZktEVjVrWnJIbVMz?=
 =?utf-8?B?cmZaZWVaVDdVbnE2bHRiVElFNEtRSXYrZWU5K0kwMzVHWHIyWlgxVlYzRzJH?=
 =?utf-8?B?VlI2blJ6NWh5Tks3S0hXWUtncitJbFJaQkdOaDBaSHdhektRSElpMmxSdU5P?=
 =?utf-8?B?SS9pWVkvUy9hejBDOUhuVDJpeFBiWWVLQWViLzJXZEt0aUJqVWdpVGE3c1p0?=
 =?utf-8?B?aGFtMEtnTEJENkpCTjZMYUViTGFJbHhlZlA0Q1pWbXdvT2thQjJadGlGN2Vz?=
 =?utf-8?B?YVlsVjkvc2EvZzFtSlZ3VFhpNmRnQ2VOdEF2VjBiRis5SXVSNWd5NEFhNXBY?=
 =?utf-8?B?WUI5ZHB5amdQN2lWbEdwK2pjai9CdkpOMzJoeU9aMGZaU3BVeGNZWE5weTJo?=
 =?utf-8?B?d1VGZTFhR3FrMGc3UC9MVmtpSWhWd1ljYnJza2liUzVBdkhPUTJzVVVkNk02?=
 =?utf-8?B?dTRYTU5YNnprWGEyU2t5am5HU3c0SlQrL09qa0phbmZjZURLR2lnL3hqVW1B?=
 =?utf-8?B?VXl0VzFERFlaS0VLOUVPcDhLM1pMV2pyYmdna1lVOTEwODBsMnc1cmlmWUJY?=
 =?utf-8?B?ZVV3TjRLcTl4TlB2VWhOVnF0aTJPUCtLeVpKRUFlZXlGY0I4YUZIQkROcWF5?=
 =?utf-8?B?WmozdkFiVzBDM1dCckxLTS9pWW54Yy9OaWQ4ck4wemZZNllGSnRncDk5VXY2?=
 =?utf-8?B?S0x0UXN5b3cxb3liOFJ1dnUvbDZRalBJd1N2dGdKTEkyQkJyRmV0MFQxa1Zn?=
 =?utf-8?B?WmNiQ243Y0RCWm13MFhuNkFkcTZXWlNXWE16WVczMWlzS3FMajJrUkFKbGh2?=
 =?utf-8?B?RnlXQmRMSHNmbTJ1cXRrL0tKaGVkVkptWlRrZ3F3NHdCL216N2N5NGdPQ0Uy?=
 =?utf-8?B?RVgvVDduOUluY3hOLzNYQzE3dTdEdDJISUcvZDJlL2Vnblo0S0NYNU5QTHdT?=
 =?utf-8?B?aEJaU2F2enVsWnZ6Y1VFZGdsQmZrVHVDdXhVVWhJOUs4RzRDVGU5UDRoSUhs?=
 =?utf-8?B?ajRtSnIySjF1ZmxmUW9aeHlyYWRSdDBBbzRZcnlBd2lVNE5zY2N3bkprQTdm?=
 =?utf-8?B?SExmT1FrcWFBNEZhU1FsN28wZHNzdytGVlN4NnpkRThEbUtMeEV4K3hqRE9Y?=
 =?utf-8?B?MFVMZHVIYjdiL3FGVUxhK1BwSUVnMnp3RVl4Smd3L2tScDB2bnpQamdaQUlh?=
 =?utf-8?B?dlZ0WWFRdFFvNS9JQmVrM1ZlWlRCQ3ZmLy9PaXRTcXlONXVqanpqcXR5bmY4?=
 =?utf-8?B?bThpV1lGM2t0U2x2eU91elJMQUJsVVYxWTB5SVdyYUpNSjd3MnVEZ0hxUjU5?=
 =?utf-8?B?MVFLaHR2dWxWRDVucDR1bDZ2UnF5OGp1WDRLN013MC9za2JrWXBqODRXcG02?=
 =?utf-8?B?Nm5KQ0VzUGhXL0phVHlpb2RUNmJMbHFWMnhmeW54N2VxNk5tVnpsUStNaHBM?=
 =?utf-8?B?NC9jcHVleG13UlZ4dUIrTVkxNjVkQUtXRU12T0lkelU4OTNDNkJ6dDIwaE1V?=
 =?utf-8?B?V3ZyR0JPWVgveGJuS1YwQ3B2K1JqYW1UTm1iQ2FuandJKzNtTVlMc25iV3Fx?=
 =?utf-8?B?TVN3NFNRcnBIdWt5R0o0WGtUcDZwbW5UeEtRMy9BZ1J1bnBkOTZhZ3loR251?=
 =?utf-8?Q?gdYHrE9cske7QRlgfddiNx55/?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a03d6718-78d9-4148-bd40-08db2ee47b11
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2023 16:58:25.7934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T0DNxkfJn8/pcETd383TL8J5MhpFMc2YqMGyS3diV5zkCgGiLMmGgmMRIO8i1d4jY22pLX0NCwPAAZfZu5cCAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8325
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        SPF_HELO_PASS,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/25/23 4:07 AM, Krzysztof Kozlowski wrote:
> On 23/03/2023 02:29, Dipen Patel wrote:
>> Introducing nvidia,gpio-controller property from Tegra234 SoCs onwards.
>> This is done to help below case.
>>
>> Without this property code would look like:
>> if (of_device_is_compatible(dev->of_node, "nvidia,tegra194-gte-aon"))
>> 	hte_dev->c = gpiochip_find("tegra194-gpio-aon",
>> 				   tegra_get_gpiochip_from_name);
>> else if (of_device_is_compatible(dev->of_node, "nvidia,tegra234-gte-aon"))
>> 	hte_dev->c = gpiochip_find("tegra234-gpio-aon",
>> 				   tegra_get_gpiochip_from_name);
>> else
>> 	return -ENODEV;
>>
>> This means for every future addition of the compatible string, if else
>> condition statements have to be expanded.
>>
>> With the property:
>> gpio_ctrl = of_parse_phandle(dev->of_node, "nvidia,gpio-controller", 0);
>> ....
>> hte_dev->c = gpiochip_find(gpio_ctrl, tegra_get_gpiochip_from_of_node);
>>
>> This simplifies the code significantly. The introdunction of this
>> property/binding does not break existing Tegra194 provider driver.
>>
>> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
>> ---
>>  .../timestamp/nvidia,tegra194-hte.yaml        | 31 +++++++++++++++++--
>>  1 file changed, 29 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
>> index eafc33e9ae2e..841273a3d8ae 100644
>> --- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
>> +++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
>> @@ -51,6 +51,12 @@ properties:
>>        LIC instance has 11 slices and Tegra234 LIC has 17 slices.
>>      enum: [3, 11, 17]
>>  
>> +  nvidia,gpio-controller:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description:
>> +      The phandle to AON gpio controller instance. This is required to handle
>> +      namespace conversion between GPIO and GTE.
>> +
>>    '#timestamp-cells':
>>      description:
>>        This represents number of line id arguments as specified by the
>> @@ -65,22 +71,43 @@ required:
>>    - interrupts
>>    - "#timestamp-cells"
>>  
>> +allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - nvidia,tegra234-gte-aon
>> +    then:
>> +      required:
>> +        - nvidia,gpio-controller
>> +
>>  additionalProperties: false
>>  
>>  examples:
>>    - |
>>      tegra_hte_aon: timestamp@c1e0000 {
>>                compatible = "nvidia,tegra194-gte-aon";
>> -              reg = <0xc1e0000 0x10000>;
>> +              reg = <0x0 0xc1e0000 0x0 0x10000>;
> 
> This is not really explained in commit msg... are you sure you tested it?
I have to revert this part back in next patch as when I upgraded dtsschema it gave me errors.
> 
> 
> Best regards,
> Krzysztof
>