Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230327122948.4323-1-johan+linaro@kernel.org>
In-Reply-To: <20230327122948.4323-1-johan+linaro@kernel.org>
From:   Steev Klimaszewski <steev@kali.org>
Date:   Mon, 27 Mar 2023 12:31:13 -0500
Message-ID: <CAKXuJqj59JzodbjFQNndyHXC0H0dHbG03V2w8293yaQUpjNdHQ@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: fix pon compatible and registers
To:     Johan Hovold <johan+linaro@kernel.org>
Cc:     Bjorn Andersson <andersson@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 27, 2023 at 7:30=E2=80=AFAM Johan Hovold <johan+linaro@kernel.o=
rg> wrote:
>
> The pmk8280 PMIC PON peripheral is gen3 and uses two sets of registers;
> hlos and pbs.
>
> This specifically fixes the following error message during boot when the
> pbs registers are not defined:
>
>         PON_PBS address missing, can't read HW debounce time
>
> Note that this also enables the spurious interrupt workaround introduced
> by commit 0b65118e6ba3 ("Input: pm8941-pwrkey - add software key press
> debouncing support") (which may or may not be needed).
>
> Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/bo=
ot/dts/qcom/sc8280xp-pmics.dtsi
> index c35e7f6bd657..a0ba535bb6c9 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> @@ -59,8 +59,9 @@ pmk8280: pmic@0 {
>                 #size-cells =3D <0>;
>
>                 pmk8280_pon: pon@1300 {
> -                       compatible =3D "qcom,pm8998-pon";
> -                       reg =3D <0x1300>;
> +                       compatible =3D "qcom,pmk8350-pon";
> +                       reg =3D <0x1300>, <0x800>;
> +                       reg-names =3D "hlos", "pbs";
>
>                         pmk8280_pon_pwrkey: pwrkey {
>                                 compatible =3D "qcom,pmk8350-pwrkey";
> --
> 2.39.2
>
Tested on the Thinkpad X13s

Tested-by: Steev Klimaszewski <steev@kali.org> #Thinkpad X13s