Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3219578rwl; Mon, 27 Mar 2023 10:49:43 -0700 (PDT) X-Google-Smtp-Source: AK7set/VQy6Lavb/WLKYPjPJSuKDZ0PWU71I/15ECnXpSwfl7HnXdAs0Y7+RaFSGFfUKHXHQOrm0 X-Received: by 2002:a05:6a20:2d99:b0:d5:b3d1:bff9 with SMTP id bf25-20020a056a202d9900b000d5b3d1bff9mr10225386pzb.52.1679939382808; Mon, 27 Mar 2023 10:49:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679939382; cv=none; d=google.com; s=arc-20160816; b=SQPQh3tNdd/EeqXwUr4ufqFLk9uLx2XQxfpFJII5brvxBHErDUiMTEhCiNguZfqhKc h9/JM7GvL//VOJXBnCPF7U0Aqm5tANo1n/z4AsT9RqGYpZsTytr8PTP3OMeZWKkQqNtH DPuo/0qRukf5QohB/ax8hKTHZpnZ8oAUBwxqbt860pDB/+RRICcgU0wlgaiMfRvkxDfW 5DduWEq+9kKeUQUhLGFFjOklrlUUKLK7adjyAEmADFEmmL0ofXhchluH48rGQ+H7zPdi Tmk8UiR8HSxHbufpqxVNw4zrK18NiMm0l26S6Fnen05ZSi83aY0rN61bJqIG2dmhtJwZ GlTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=fmENmbS6YfOGCbil7lKj3DcV2u8EJhaYQuM6f42l51Y=; b=W6cQlkMWX/Zar8GUsumJBFK7qZZgeyjjaX+kqpX4k0c56M/vy8OOeWRQUVJ1ZmLCH8 aM61OYSZrzKJctytI8Z8/DZJffAM2A6OvaIwK57AQYX52CTnh336GyZQDCPKhAxMhbPL HK+itYl5zlBh5TgiXITqckRbbOiCFp77j1m21PoyqDbRF8S/uNCoy7ZpLGcUwT4Fc96e yFHlF9GpyZiaK2T6+3hjt74IqI6ZRV4RO8NSURlRForKjdlE2dmWwQmC9wIZkYUjlZav pmOCjOUMKBNN1fJXz25RltY6PLQyBd5orRivQdUOuyNxKnNu6dDroaLtmIKQjn1r4T1m RGXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nhWgKJZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m2-20020a62f202000000b00627e9b0d5d7si22377899pfh.354.2023.03.27.10.49.31; Mon, 27 Mar 2023 10:49:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nhWgKJZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229946AbjC0Rrh (ORCPT + 99 others); Mon, 27 Mar 2023 13:47:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjC0Rrg (ORCPT ); Mon, 27 Mar 2023 13:47:36 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC40D170C; Mon, 27 Mar 2023 10:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fmENmbS6YfOGCbil7lKj3DcV2u8EJhaYQuM6f42l51Y=; b=nhWgKJZdcJr3P9s6ucypYywMfE 4Kt1OJhrAyyN06VLI/MFIvlrlLN5hdFHHyyzncvo1caPmR725nd9bjgxoeaVDvbiF3rm4UzIqVCXa u6khJw9B9dTbNUQAfusDEdSipEZu3L/qxKmW91j4BLoqCKktu/sXGMdK5+CF7Jd9NvsOgh6tGzNG0 2BeoQSw8+lmEkihHVIgidX7dCg2701aOMxqhixXsH89OSoZ65PHjG/ftQ/qtu6TlBoUGBoEoIIF5V BPDheF5+Q07wxCQqH5WoPUnGg6+kwxYCDmchHEqek6K4ybBcjRGxXtXsdwaAi3t00QIiGtoH23jWS g3SySQJw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pgqwQ-00BwSV-0n; Mon, 27 Mar 2023 17:47:34 +0000 Date: Mon, 27 Mar 2023 10:47:34 -0700 From: Luis Chamberlain To: Viktor Malik Cc: bpf@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Nathan Chancellor , Nick Desaulniers , Tom Rix , kernel test robot Subject: Re: [PATCH bpf-next] kallsyms: move module-related functions under correct configs Message-ID: References: <20230327161251.1129511-1-vmalik@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327161251.1129511-1-vmalik@redhat.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2023 at 06:12:51PM +0200, Viktor Malik wrote: > Functions for searching module kallsyms should have non-empty > definitions only if CONFIG_MODULES=y and CONFIG_KALLSYMS=y. Until now, > only CONFIG_MODULES check was used for many of these, which may have > caused complilation errors on some configs. > > This patch moves all relevant functions under the correct configs. > > Signed-off-by: Viktor Malik > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202303181535.RFDCnz3E-lkp@intel.com/ Thanks Viktor! Does this fix something from an existing commit? If so which one? The commit log should mention it. LUis