Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Tom Rix <trix@redhat.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
Thread-Topic: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable
Thread-Index: AQHZX3qZkf0OWayeHEahRMboOzTx+K8O7Z4A
Date:   Mon, 27 Mar 2023 18:02:38 +0000
Message-ID: <F961DAB1-FAB2-4F65-AD5E-0B804F93FB64@oracle.com>
References: <20230326003222.1343671-1-trix@redhat.com>
In-Reply-To: <20230326003222.1343671-1-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AYiTHxSlEfftyvr9ku+YhNOFI91M5du0SGFA8lYkR4quXP42tXMlNoQ4g24I?=
 =?us-ascii?Q?Dag5YWoUh7kmgGBrB0RIaFAgj3Pe4d7/vdopEZxFx8T+2kuftfCqUV5hYJ4j?=
 =?us-ascii?Q?k7OwHLFx4YfTEf2s/lt509sE0jhTdU8/MNO468uaxR2neWxqgF3OPsDOsT88?=
 =?us-ascii?Q?SQ+AagEb1XedQwgXid3POCqcyHp12DDdM1OTnNztppbNX48tb0pzeaKrYrsH?=
 =?us-ascii?Q?vLQGTUmAnPBDgQ9rVNp5qu6WNP3jj7N9RWKSrsuUDSC0vCGl/9qhvgV77Phe?=
 =?us-ascii?Q?o9wuXMe8IIUA+g3l1Xn2Hzn7Ls18Hs622arEGYTsn4jniRFKcRQKvjjc44px?=
 =?us-ascii?Q?dpcWP4dxsZOXPPNHEs0HASOj3fHgYij6GXxHZ7oJdVWyq/UCQkGFa5wEH7A/?=
 =?us-ascii?Q?Fxen9DeY+cALIiFwtjEw33+omgBgZGYXhlaBeuCexzzyvgsySiJJE2DpTUXW?=
 =?us-ascii?Q?zybyU03CaVCA6dbpz77OS0MP6Hkyx+ETvGrZntYyhRoZ+HYadUsQq7aOAEPU?=
 =?us-ascii?Q?qg15O+5DM85AeXvNj3wVYbq+94GKD/YQCMTjN5MnlSM/J83xxSwnhKD3JX0s?=
 =?us-ascii?Q?sVI15l/0e6Dy80ORKwfwGecoPhb4+jxI0kMF4vcmb4sDaWFJsiaRz/ZhJokM?=
 =?us-ascii?Q?9oee48nzLQpI73+XV+cUNe1kUv1v8rN6LAdSS873Eid30Ryvi4w2yXHRTxdi?=
 =?us-ascii?Q?F0a7/RcQgcck23YWsuMBOAjKAV0g85F8KXi4EQLa/ptM4z5dcB/kvu5lfEOs?=
 =?us-ascii?Q?20n4Q59j7Lq6bD7bCNMAgnZy0AyUICfJLc4SFFL/6J8M6e5vg//832c2s8Ir?=
 =?us-ascii?Q?BT0PUtMRFhvb4L5myg93hW3S2LxWL8FuaKPBPUA9ZPnZgyce83jmfewf8smO?=
 =?us-ascii?Q?PAAoxJZa2KQUa13HC+kp43euSKnCNf9x8l08nemA1X8rrAyw4koPJztmT6o/?=
 =?us-ascii?Q?uS/a+YaVXPqtNMP2LbZxRalrXWHw/N9feDhyUb94D3O19eWI057PE2+rI/Av?=
 =?us-ascii?Q?zb5rfSvkAvZaf8IyuuSTSNcnzLxwlzKEEl+y9ZASTEj4COQJEFRjvDI6PbHt?=
 =?us-ascii?Q?kojhUOLVzFGMt6eeHkRUMTcHs4QMlUyfOBagSku4IXMGKumn1I6aPyJhhPyW?=
 =?us-ascii?Q?atwHMRIP1vrt79zMfsVnLdJ4GU6Asgb2d5NPWkKAEzCY0o6Iz9gjmuybJDzn?=
 =?us-ascii?Q?EO3LMqv+1CF2lDbLzja/BjwtuqsuOONVytFWPmW1QyOV/a86sPMsOdbYoxkn?=
 =?us-ascii?Q?vtgzdE4WdURPDNV8OQQdeSeWkPeu1VnNO3Jok4wMy4RhqBUgrvMUV74hwvIZ?=
 =?us-ascii?Q?DB/w08v1Sd6S7/I0jekVrxH3LwfQVk206+qG7LfN4WnC5YFg3LLanuERn0+D?=
 =?us-ascii?Q?CCN3gCf2ldWnkFTLalBRvCLuIfcqi2ptZLP8iK5T3rSGjr3vy3kRnv4rh75c?=
 =?us-ascii?Q?PcCv5v1KmrwxawAkAZSMSuTxq3ghC0ngtAM/IMx4GjKBRL0ieF+7H2HfGQcI?=
 =?us-ascii?Q?I38FceXvf0FOTsO/2hDFbeYJ4QHvoMvsXVd9VCQqslT4cyTTGgMMP9IAEw4G?=
 =?us-ascii?Q?A4+avg2XK/sXVxFe8sAn/iHrHH384zpBgeVU3paXQOtQBvf2fzqNP8LygOmz?=
 =?us-ascii?Q?zbaulNxg+Ow+14W2EOFE8ifBM45qsvhSmlu0JhmBoS/x?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <95E1E1CCD3ECCD4785790932998B4BEB@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Xk3pF97ZosR9RNHv+A7qvA2OAHg5DxrhD5y9wwCgKbykydlBXwcnz38s9wP+BjMdzs/WjDj4IERcpuiJb5y0eu10inDEkhdUj9p0ikDn2IvlN+V+vAicZYEOdAmebXEUvECAKqkoDGb+jARPZnfeqYWs74NoLkHtG9TrP4rW2VTIRZzAkSL/N0Jq5NWOENt+vCUsX9RsXmniW3YwpcZDMEBNpTQGGWmKuUvm0E/f0xzQ/8PJvjReQhhci4/zc6Nx1aB7moxCtb14ww2/9ye8rt5phsYSAfRS96bUD83iYBeJdEVUTunkr2gcJXOsm554qpQk/JvGjnKchqSbKpBPaGeNxoihzxbDmioAhzYqQZxqXgOgnF96p+2nXTw1SkR4VI5b5UmlRN1uJLvXdL3gHK4iPtYhwII2W056C6gAlpuwOJEdHMjCnJg4380Kat4bByns8HOQRy5onzn1mFkvDidIB8sjBA77Bkta52n5Dj1mVVDi+LMwu9u/AXzp+t+3z9nvNhLYkjl50tNWso5MatHJuzXIPNvu993gXiHl/sWSisL3dask2A/H0CaouzXyx2P9NZf75X+fpT46V7P2Jm5+66wpfsw0iBovtMpIKkgQVrHM+lmKpYYM/B9aoeAfwpxJLVTuT0cnptlXLmQnESW7xXk4mj5XWpXvLYvCqcnIAqNEw6Dq5p/uVnCWZTxgFxIzT6HI/7U8wd9C6My2rnnbvJ1iOwzG4Vo+f81yd7QwhAbLGYGvDwrTSuVXVcr0W0dwlsRkVaQ6JlcksPo8grA4EU4l22OB1+r7jNoQTAKSXH89kUuoFoPO72o0x2wjGVfJp5E752a7PITwSvv2sY8bK13L9rXsc6oWI42ET4PCY/1wRhaOSS8B9H7H1YSzqaRfMsYVuijQXmuRJDlHy4DtJDMRK96PYKOKQg5WyOs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 352000e3-86b4-4530-2f4e-08db2eed73e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2023 18:02:38.9356
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yq7zC5lFVeN8EBWomVFuw1YrXRyr8DPC5qD7Al3ZPoCuFp6SD9/iu/yPhntWFC9az9O7rgHY7KnX5WiFl6mR2tQYnWmYp6ZLsrK860G2BdU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4118
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-24_11,2023-03-27_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2303270147
X-Proofpoint-ORIG-GUID: MksLhkmb5XlN_fK4YoDqAhp6r_llCjov
X-Proofpoint-GUID: MksLhkmb5XlN_fK4YoDqAhp6r_llCjov
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 25, 2023, at 5:32 PM, Tom Rix <trix@redhat.com> wrote:
>=20
> clang with W=3D1 reports
> drivers/scsi/scsi_transport_fc.c:908:6: error: variable
>  'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable]
>        u32 desc_cnt =3D 0, bytes_remain;
>            ^
> This variable is not used so remove it.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/scsi/scsi_transport_fc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transpo=
rt_fc.c
> index f12e9467ebb4..64ff2629eaf9 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -905,7 +905,7 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_le=
n, char *fpin_buf,
> {
> struct fc_els_fpin *fpin =3D (struct fc_els_fpin *)fpin_buf;
> struct fc_tlv_desc *tlv;
> - u32 desc_cnt =3D 0, bytes_remain;
> + u32 bytes_remain;
> u32 dtag;
> enum fc_host_event_code event_code =3D
> event_acknowledge ? FCH_EVT_LINK_FPIN_ACK : FCH_EVT_LINK_FPIN;
> @@ -932,7 +932,6 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_le=
n, char *fpin_buf,
> fc_fpin_congn_stats_update(shost, tlv);
> }
>=20
> - desc_cnt++;
> bytes_remain -=3D FC_TLV_DESC_SZ_FROM_LENGTH(tlv);
> tlv =3D fc_tlv_next_desc(tlv);
> }
> --=20
> 2.27.0
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--=20
Himanshu Madhani Oracle Linux Engineering