Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3278051rwl; Mon, 27 Mar 2023 11:38:35 -0700 (PDT) X-Google-Smtp-Source: AKy350bMG8xnzBWe3DgpcFr4oes4gp5TNlk/JkzmyuCbBLn2Q9h1xOOaUASVn+kmZ+Zgob4VmObJ X-Received: by 2002:a17:906:a15a:b0:8b1:3a18:9daf with SMTP id bu26-20020a170906a15a00b008b13a189dafmr12672760ejb.74.1679942315153; Mon, 27 Mar 2023 11:38:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679942315; cv=none; d=google.com; s=arc-20160816; b=I9ArTMy02U+h4NGZ979gNyTba1i9ca5nauRonCD3W/xDpMAbWtu18Bks6h3Anv/UFp wmb9BmYE4iKowiO1pzFbUT7/07JbQ6zJA7NJzE5OYsi56b21eHFePdtP2jgodIgTupkh rJrASN4AlR36VulUHkf6LOQeLQgpqlugBNJTxqKb+T/JstkDzeftSJs2Rw/Pwt43lV7r 6xSMrM4h7X9tKQZjADW+g+fkT5H9P1ua2F+Tmrs37pHOlI9iO/FiQ2au1H85sHuhdh/6 0AX/6fXjXvpFXyBmtKFbC8JNNyxwBI9sjjV5NKzWmPCytla1AQ+3cW3LGIIP56KEJKw8 fQzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=7o6r6784pPUO2ZmV+U6zKpq4kzlG08gwo4Hlwv9hSrU=; b=qWacs9N/oNdtKlR6XrPFJo5BHBFBUfpmkuxKaJ9lbnKrVYsTDXFCYP/xsUNMtxvSKZ +r2WfGKF3S8piqbg5nXOvarnwdYk1h5cbBRASvziHO9MotQ7X5+dVgXUIfhuQ2THnsXi alxyjOMoM3b6hAGyX0rEUG4cKMctWgss4E66ZCOeX2dLIRUzHK2NlD0JysSolOuToWZ7 Uaejm3AiBN4eooI052t/9W1+kzbkbcE/nmJsYmEITHr17B02E/sR+vmYUDwVpBSfKwVG bXMqPeg9MQXheO8Egm3i6JSzEmWmgla3KgFVkecly5pwSIrAFFBjZ2gIQG2xD1+PM8XA R82A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=sdQo+TK6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a170906825100b00934d983a240si20468953ejx.280.2023.03.27.11.38.10; Mon, 27 Mar 2023 11:38:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=sdQo+TK6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231881AbjC0ShL (ORCPT + 99 others); Mon, 27 Mar 2023 14:37:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230461AbjC0ShK (ORCPT ); Mon, 27 Mar 2023 14:37:10 -0400 Received: from out-20.mta1.migadu.com (out-20.mta1.migadu.com [95.215.58.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA52C3AB1 for ; Mon, 27 Mar 2023 11:37:08 -0700 (PDT) Date: Mon, 27 Mar 2023 14:37:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1679942226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7o6r6784pPUO2ZmV+U6zKpq4kzlG08gwo4Hlwv9hSrU=; b=sdQo+TK60P7btFfKoJ71OOACvu1F3dGGHIpQoL0hPQbcScul6bOD8kiwsGjTgIWcy+h+6w YFL/ZLGiU2b/OjG2Dy3wWTacnrE++v1Lns5Aj1fcP4BeqND/dIdqa8zLImgln2jniLX752 g/Rgzu1ONn6bp1u0apPqxA9ek7wreqY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: "Fabio M. De Francesco" , Alexander Viro , Benjamin LaHaise , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org, "Venkataramanan, Anirudh" , Ira Weiny , Jeff Moyer Subject: Re: [PATCH v3] fs/aio: Replace kmap{,_atomic}() with kmap_local_page() Message-ID: References: <20230119162055.20944-1-fmdefrancesco@gmail.com> <2114426.VsPgYW4pTa@suse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2023 at 02:22:46PM +0100, Matthew Wilcox wrote: > Or should we just stop allocating aio rings from HIGHMEM and remove > the calls to kmap()? How much memory are we talking about here? I don't think that should stop us from taking these patches, but yes.