Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 12:28:19 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Viktor Malik <vmalik@redhat.com>
Cc:     bpf@vger.kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH bpf-next] kallsyms: move module-related functions under
 correct configs
Message-ID: <ZCHuU4Wui7Dwmdm2@bombadil.infradead.org>
References: <20230327161251.1129511-1-vmalik@redhat.com>
 <ZCHWtptOwPPtUe+u@bombadil.infradead.org>
 <c076e249-705a-e1bb-c657-f80cd4f2145b@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c076e249-705a-e1bb-c657-f80cd4f2145b@redhat.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Mon, Mar 27, 2023 at 08:20:56PM +0200, Viktor Malik wrote:
> On 3/27/23 19:47, Luis Chamberlain wrote:
> > On Mon, Mar 27, 2023 at 06:12:51PM +0200, Viktor Malik wrote:
> > > Functions for searching module kallsyms should have non-empty
> > > definitions only if CONFIG_MODULES=y and CONFIG_KALLSYMS=y. Until now,
> > > only CONFIG_MODULES check was used for many of these, which may have
> > > caused complilation errors on some configs.
> > > 
> > > This patch moves all relevant functions under the correct configs.
> > > 
> > > Signed-off-by: Viktor Malik <vmalik@redhat.com>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Link: https://lore.kernel.org/oe-kbuild-all/202303181535.RFDCnz3E-lkp@intel.com/
> > 
> > Thanks Viktor!  Does this fix something from an existing commit? If so
> > which one?  The commit log should mention it.
> 
> Ah, right, I forgot about that. The commit log is missing:
> 
> Fixes: bd5314f8dd2d ("kallsyms, bpf: Move find_kallsyms_symbol_value out of internal header")
> 
> I can post v2 but I'm also fine with maintainers applying the tag.

That patch went through the bpf tree so its fix can go throug that tree.
So up to Daniel if he wants a new patch.

  Luis