Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 15:43:58 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
        Suren Baghdasaryan <surenb@google.com>, stable@vger.kernel.org,
        syzbot+8d95422d3537159ca390@syzkaller.appspotmail.com
Subject: Re: [PATCH 8/8] mm: enable maple tree RCU mode by default.
Message-ID: <20230327194358.so2wrir277l5phlm@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
        Suren Baghdasaryan <surenb@google.com>, stable@vger.kernel.org,
        syzbot+8d95422d3537159ca390@syzkaller.appspotmail.com
References: <20230327185532.2354250-1-Liam.Howlett@oracle.com>
 <20230327185532.2354250-9-Liam.Howlett@oracle.com>
 <20230327123849.f2b9db25baf367e3c77fe072@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230327123849.f2b9db25baf367e3c77fe072@linux-foundation.org>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hIDdvPIf6Wt7kMZ3TH+P5c8Gx6F0VYILNOlEnbNBBTB+ADLUAxqMi0ZG0Tnk?=
 =?us-ascii?Q?SBG1PLREtKbCgmtkjvLkX9aV+kQJBQyGN33pyguXcgA1z5ApDx68B48BaRRx?=
 =?us-ascii?Q?+eiM7OIh2M/+r4bQqYLQwnuODWTwIWe9nmlacK60kdwupcXx9nYJAYtXZm9N?=
 =?us-ascii?Q?flb5rg1ekG8Q2hZFhOmEHubXtuKDeByLw6JI4vbQa1o3xgEqPDX1hMhxoIi9?=
 =?us-ascii?Q?4F3G8ExeVhQ1HqH0LvAsI7MhmmwFCHVAhZseImmtExjtegtYfDqjVRaN4d43?=
 =?us-ascii?Q?BwjL8wr4zULnleh7DfEJIfcumKBTHSHivwN5/6Dps4uBUDKMT+XI9UzTAmP8?=
 =?us-ascii?Q?WppvoGxIexYiODiag0ph42A4ZbaxEJL5V4kr0hb2ltWr9rJ7pjvgiOdsUGNW?=
 =?us-ascii?Q?czRmjZ3T6LO8QKQ62ff7N0x4JxjdT6+HkR3is4suLWOk/37haPkxE9VWNPd/?=
 =?us-ascii?Q?opgYXfrKlIrXmdZzqpct6a2hcit1MWBOPqgxgMnGy7G3mVuLao1NI4jPL/IV?=
 =?us-ascii?Q?PzNWzhreEC4jnuW38rBwRM2NpT4YGyJIvXGQY3gQLUf4Vxgdr6vLfaopz3Rg?=
 =?us-ascii?Q?9XCXWROsGIb/V8bqnHnEe0llKxl/VI5tWWffvANlH6dAjGZyJjP7hXTmVsH1?=
 =?us-ascii?Q?ecoI03nSP/EtIgxXBQxXUVcIv7OPqzgDjbj6H9u0eYDFFn4M8a9fSjAdF940?=
 =?us-ascii?Q?2YRq1CF+3YSwqsHqEEIkeWG+KuYkQB7CmgeOszMZjlJQVcO0ejb55ZqubJNM?=
 =?us-ascii?Q?CHSd8O9iOPvE2xoWJwWVisR+Z/Nhu6hvc8dtvQt+6tKzOf5ZIDnbikBxXH/b?=
 =?us-ascii?Q?FPUygq8Jyp2sIQee81rG07Qt7et5bM5p+27Hzo1WmYhSxFCv+uQ4HwZrRrKh?=
 =?us-ascii?Q?jnmoryO+yo9gBy+vMrxGIBRMjNpWr/+ts+8CQoqnJDjrR+M8lP7r6xRTWtCR?=
 =?us-ascii?Q?o2bEi1ZmFVlHq9zgujjOI4Bmo6FVmd08cs/HCH3IOFngPoSMV2cgz/JYkQ5p?=
 =?us-ascii?Q?Q/3CTua1K152Dbeij5hbwYvPm5nsAXh5fIR8SpAK3HvF7nmEkAnfBXqdt/9i?=
 =?us-ascii?Q?b9FXC2Ej1pV4SmWNAM2X7vKGdFyWwJWJT237qBmdsP2+cpyYgT2MWOk9/zcq?=
 =?us-ascii?Q?4fjEKkrZ1GLxs5tGkfxPqyMX+/h/hHFhV8CWyE6C+XUc7c72I0EzR9bAxwb8?=
 =?us-ascii?Q?+MAvLMNz8nlKbFTHt+rxRO1wIs4hAhLxrW5e2ee5HP/oHyvn16ovj+2R4u07?=
 =?us-ascii?Q?wWmea3Rbs8+BNKxKjPZDovmawnRzZ49rYyH4BRcxlzzSoE06OrZuEPvj3kK0?=
 =?us-ascii?Q?KlbWKwZIr5RExxGUH2u1hxCUA1C/GOX1+kqZSdvmCxaR/eRuLcV8qm2q3Vti?=
 =?us-ascii?Q?ztOP4PjHSB33gAdhwQF/BfHQi8BtAjZBdZ1ctD33Bq32Mi/D4h+ZbKJc3r7L?=
 =?us-ascii?Q?MtUHS/+Vd0me0DMYmS0YhglAuLSgUmOrvVHErzQ97RcK7KI2q1R7LnE67MNg?=
 =?us-ascii?Q?zaDLzg7qfl51Ck6+mszh0pkARJzSJ43a4Pgg0h5YKYNSMPVYqVEvPs0fwfCM?=
 =?us-ascii?Q?PcTHLc081OMMQyPDlZd1C5Ocoxnt2iFNrgauOP9aVmOnpYUjW8HVliEx7XD2?=
 =?us-ascii?Q?Fw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?ntmb44/vSK9g0w5KLEAI94i91G7nLzgekkYPtIWS2rYbH1ISQYrjDdKa5Tgh?=
 =?us-ascii?Q?BzjwRlOThESRdKM844lEkL9nY0gPhZsJcv5D/aK3ddBNNEKNq+NiKvY3C9iL?=
 =?us-ascii?Q?t9KsVUCwNSsSW40Pw5qbxcLlyJCn6r+Ss22undXdwSSnxaMWdfQBY5v8Gx2O?=
 =?us-ascii?Q?skyGHd82CMmQX+PwY6nCY8qCaKy7Nfsxa5cnIo1sIvcUyiV5SUegmjSFYX3W?=
 =?us-ascii?Q?MqARoA4zoehiF48yBXR1xY/AgyLzD2P6MfKYQet/GGoxh7PJtD4zOHPRQ6SA?=
 =?us-ascii?Q?3WCZjz4HS2ytZfh9ixOttl8dfyvztteJCE+T7aXFFq9tmDM54zyL6pCyYQ0n?=
 =?us-ascii?Q?wOFEvG1hMU3OA87b4O8d9nBPDwG08pcNbtXGhIaomljWyi37S6tWfVZtVgzw?=
 =?us-ascii?Q?wnbR1r8gHf48ql86k48L/KD3QefqsKKyS4gfidcmp6l4SEy6e3eTMc+XmVpX?=
 =?us-ascii?Q?a94FTP0lcn3IAHD96HUtIvvDRZb8D09ZEDsDncwOyv1ZuCRsTwff450PnvBW?=
 =?us-ascii?Q?gLHepXtoYxosxYeHA1TWsVu2rzi5/hn8FH4UM6m34oeGW2NjsQq+IQcIlEYZ?=
 =?us-ascii?Q?QYt/kppCXgSL42BTute8ftA8olbN8Z3aGhLZ01SvPRlZa4eunDIMwMMBVoLb?=
 =?us-ascii?Q?4I0IrjP2FWenrsMrXZ0A4m2e834IHhIIEBv6MVq+J80nkZiazF8ELn4ttS0/?=
 =?us-ascii?Q?mulxLf19nxO0sIQV9516SwkaBz4w7TBUhpRYm59Y19KODL/iHCqzkjL3Jv3z?=
 =?us-ascii?Q?59VSy6DvN1Aj9di+k0z+WKhi5FvOgOhqTv5GG86WB5DLichT++lqujp+oBnb?=
 =?us-ascii?Q?Qj1pv0p3kCVjVW0NzPHbbJ+guiuauu038wo7h9Ec2hQiRJf+jvQ/hR7QTQOK?=
 =?us-ascii?Q?tNTM/Nl0E27Ip95zcmGT6laGyYWaNLL2Ez+fVGN2WhrTdVbgabaJ/y2W+wN6?=
 =?us-ascii?Q?8QfjXphRK71T3pu9zekGEjz7u9v8lZnM+5xr9UunXgpUHkhPoT5GZtpdo5bH?=
 =?us-ascii?Q?7M+X4Fxo8TR9dxunIVZYDYD88A=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c94488c-8607-4f35-90b7-08db2efb9d05
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2023 19:44:00.9874
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jU5wJXmPeh086yhZZxb8fZhio+vPCx6fVILK1Vwm5R23D4u0okX8ni1/z6edBJG3FJxM0K0pTjJXVZISB+uMLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7370
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-24_11,2023-03-27_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=369 adultscore=0
 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2303270161
X-Proofpoint-GUID: YyI7CtTuPrC53UeHbdad_GC9DOTcBea4
X-Proofpoint-ORIG-GUID: YyI7CtTuPrC53UeHbdad_GC9DOTcBea4
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Andrew Morton <akpm@linux-foundation.org> [230327 15:38]:
> On Mon, 27 Mar 2023 14:55:32 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> 
> > Use the maple tree in RCU mode for VMA tracking.
> > 
> > The maple tree tracks the stack and is able to update the pivot
> > (lower/upper boundary) in-place to allow the page fault handler to write
> > to the tree while holding just the mmap read lock.  This is safe as the
> > writes to the stack have a guard VMA which ensures there will always be
> > a NULL in the direction of the growth and thus will only update a pivot.
> > 
> > It is possible, but not recommended, to have VMAs that grow up/down
> > without guard VMAs.  syzbot has constructed a testcase which sets up a
> > VMA to grow and consume the empty space.  Overwriting the entire NULL
> > entry causes the tree to be altered in a way that is not safe for
> > concurrent readers; the readers may see a node being rewritten or one
> > that does not match the maple state they are using.
> > 
> > Enabling RCU mode allows the concurrent readers to see a stable node and
> 
> This differs from what had.  Intended?

Yes, this is not necessary.  The scope of this tree is limited to the
function do_vmi_align_munmap() and so we don't need to free the nodes
with RCU.

Thanks,
Liam

> 
> --- a/mm/mmap.c~mm-enable-maple-tree-rcu-mode-by-default-v8
> +++ a/mm/mmap.c
> @@ -2277,8 +2277,7 @@ do_vmi_align_munmap(struct vma_iterator
>  	int count = 0;
>  	int error = -ENOMEM;
>  	MA_STATE(mas_detach, &mt_detach, 0, 0);
> -	mt_init_flags(&mt_detach, vmi->mas.tree->ma_flags &
> -		      (MT_FLAGS_LOCK_MASK | MT_FLAGS_USE_RCU));
> +	mt_init_flags(&mt_detach, vmi->mas.tree->ma_flags & MT_FLAGS_LOCK_MASK);
>  	mt_set_external_lock(&mt_detach, &mm->mmap_lock);
>  
>  	/*
> _
>