Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3395921rwl; Mon, 27 Mar 2023 13:27:06 -0700 (PDT) X-Google-Smtp-Source: AKy350YU8T3tHlytU3Vxufn5a52PzFIDs8Zlkygz3Yq3bMVEHm9kcLLwnUt+jXIuYDK8Md6V3OlJ X-Received: by 2002:a17:906:eb8d:b0:8b1:76ca:f228 with SMTP id mh13-20020a170906eb8d00b008b176caf228mr12184171ejb.39.1679948826197; Mon, 27 Mar 2023 13:27:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679948826; cv=none; d=google.com; s=arc-20160816; b=A7FepDcQCuGghUvCOKQmCnJL5bR4fSlWuoa4TrjsLRjBcvP7snZ6lSJfVPSYUb6wmY r6HbLO41Rs8uL7kkAhyvF6INkIu2KRHs/ABpuK1xyLbRLVX5c3iQqrs7LBN1eWwzDgg2 d5Yl1HMHHqQo/r1WAmtfAPhpUAYFEsyec6BYs9ZShdYGTY/KbH5GA4BBe5j/Y36pTKdU T/ECcypNluqzbGe0iKSOBUFRsjRvA1i9i2KrcgOn6r0cOYuaIMhuG7cqSHdU1QtKPQgS 7/2UBWsi1IxUY8qf5W2o8TlZEA2UgmuFQNEsIutCTJnmiS7+lyojRFL/CwTa0qwE6WOf bScQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=aE3c1+YhOpnk0+VqylK2i+T0h1qRBhBBnQ1pB7UIS9k=; b=zvFL1QKQfderamrB8NfqAk+sn0VbNV1QQRtH9FreGTBydBUNC1eE9D62WmIxVBhPSF HnsJnS62jUaWjJndtSOpV3BHYdVSKYjo7HMdVTKzESITVqmHjQCTE6ayIbrBm5A9gUnQ 6N6l0+6zr2k/lo7VphKZo7F8zUdfype+Q/XuD6MkBGSd86RgK2eYwI+6ozL9qcPgIMtW GfhOh8MSiazW295BkLgx9EEY1TB+9BxMhBWMR5aJJphpKlI1nEBrRHP8kPFzM43SNoYV SUoWKPThW3YTfgZOP80Dk+qntFM9OTvuOwknwb1LaThmtfIk4cyuMXDFMH+v8SKqnZ6K Mu/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pvpwGINo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v12-20020a1709061dcc00b0092ff7e4cdc8si25618876ejh.267.2023.03.27.13.26.41; Mon, 27 Mar 2023 13:27:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pvpwGINo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232487AbjC0UTR (ORCPT + 99 others); Mon, 27 Mar 2023 16:19:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230155AbjC0UTL (ORCPT ); Mon, 27 Mar 2023 16:19:11 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B59D3592 for ; Mon, 27 Mar 2023 13:18:58 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id d17so10019112wrb.11 for ; Mon, 27 Mar 2023 13:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679948336; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=aE3c1+YhOpnk0+VqylK2i+T0h1qRBhBBnQ1pB7UIS9k=; b=pvpwGINoN7998DOLexrD/+Pee8XDqStCqWkT78+tvmaQ/q27xkiAGP8onBoufpE21N UL6N+PoxzlaIudePqUMCN6Kai2+CQ4uVp7JsPGNE3UvXYPs9xQt7ES6zJv+moleEotWn 4vIrncoNr6dLY3Sel9hKOyR17ajZ9iRAThkQq0AmQyQWUv/ai9AGu0R01IyGdC1H9A0q BZYYrwZVLXdGkB0HYRHReo8zIXima+fwnCOa94LrliclLGwadiSknL3hSY00ZTaHzhop gby3aQmiTxNrGRUlLt/R+Hw+7QkAyFA+aKavuQN6eqoweow9w/QDRvmzhOGO+YXJ79/O ntUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679948336; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aE3c1+YhOpnk0+VqylK2i+T0h1qRBhBBnQ1pB7UIS9k=; b=DY0zD0MMe5m0TN3zAP7NDU2E/EWjteKWXfuTiTMs1rnC+VFI/AE4V9u234BGk6wgyO naBhnnWn3GvWczku3AByQ76caUsrQsS0jOELTXhqDww8HYHBGtQLyg6XVZ5zG5Zer/Ug XipHX8LiCiliq486/Co8V9zwnvpXTLeUehwvUJJf6XcC0HMwnc+mTK/+aFqJRuJ97oSj 8vC0RlGgRvlx1lLS2msv86MJcga8vC9Wmitu1VsKiOMuWZA6v9TmXmWyCT+6gF9YRwn4 dkrQEubzFKoSxYch6t3SrJMufMreC1xZXFNSSs5G7NwgF8ABxsAAkqtr0xqB1xBkcc3a 3XBw== X-Gm-Message-State: AAQBX9cALyrFi5Py3/OVvWTAdtblzIAiulcMIuFIERdn278ydpo/G0Nw mL9WofvqZO0Qw3njFrEXSaDOEPGSSPqBR13JPQc= X-Received: by 2002:adf:cf12:0:b0:2d7:4c98:78fe with SMTP id o18-20020adfcf12000000b002d74c9878femr9996122wrj.34.1679948336309; Mon, 27 Mar 2023 13:18:56 -0700 (PDT) Received: from khadija-virtual-machine ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id v13-20020a5d6b0d000000b002daf0b52598sm12725301wrw.18.2023.03.27.13.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 13:18:55 -0700 (PDT) Date: Tue, 28 Mar 2023 01:18:53 +0500 From: Khadija Kamran To: outreachy@lists.linux.dev Cc: Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: greybus: refactor arche_platform_wd_irq() function Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Refactor function by adding goto statement. This reduces the indentation and fixes the issue reported by checkpatch.pl script. "CHECK: line length of 101 exceeds 100 columns" Signed-off-by: Khadija Kamran --- drivers/staging/greybus/arche-platform.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index fcbd5f71eff2..c7d3b6f7368f 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -178,11 +178,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) */ if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) { - arche_platform_set_wake_detect_state(arche_pdata, - WD_STATE_COLDBOOT_TRIG); - spin_unlock_irqrestore(&arche_pdata->wake_lock, - flags); - return IRQ_WAKE_THREAD; + goto out; } } } @@ -205,6 +201,11 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); return IRQ_HANDLED; + +out: + arche_platform_set_wake_detect_state(arche_pdata, WD_STATE_COLDBOOT_TRIG); + spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); + return IRQ_WAKE_THREAD; } /* -- 2.34.1