Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 20:39:39 +0000
From:   Alok Tiagi <aloktiagi@gmail.com>
To:     Tycho Andersen <tycho@tycho.pizza>
Cc:     Christian Brauner <brauner@kernel.org>, viro@zeniv.linux.org.uk,
        willy@infradead.org, David.Laight@aculab.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        keescook@chromium.org, hch@infradead.org, aloktiagi@gmail.com
Subject: Re: [RFC v4 2/2] file, epoll: Implement do_replace() and
 eventpoll_replace()
Message-ID: <ZCH/C89TwQ/aM1Rr@ip-172-31-38-16.us-west-2.compute.internal>
References: <20230324063422.1031181-2-aloktiagi@gmail.com>
 <ZBzRfDnHaEycE72s@ip-172-31-38-16.us-west-2.compute.internal>
 <20230324082344.xgze2vu3ds2kubcz@wittgenstein>
 <ZB2o8cs+VTQlz5GA@tycho.pizza>
 <20230327090106.zylztuk77vble7ye@wittgenstein>
 <ZCGU5JBg02+DU6JN@tycho.pizza>
 <ZCGXNwvymHVJ7O6K@tycho.pizza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZCGXNwvymHVJ7O6K@tycho.pizza>
Precedence: bulk

On Mon, Mar 27, 2023 at 07:16:39AM -0600, Tycho Andersen wrote:
> On Mon, Mar 27, 2023 at 07:06:46AM -0600, Tycho Andersen wrote:
> > On Mon, Mar 27, 2023 at 11:01:06AM +0200, Christian Brauner wrote:
> > > On Fri, Mar 24, 2023 at 07:43:13AM -0600, Tycho Andersen wrote:
> > > > Perhaps we could add a flag that people could set from SECCOMP_ADDFD
> > > > asking for this extra behavior?
> > > 
> > >         +       if (fd > 0 && addfd->ioctl_flags & SECCOMP_ADDFD_FLAG_EPOLL) {
> > >         +               /*
> > >         +                * - retrieve old struct file that addfd->fd refered to if any.
> > >         +                * - call your epoll seccomp api to update the references in the epoll instance
> > >         +                */
> > > 			epoll_seccomp_notify()
> > >         +       }
> > >         +
> > >         +       if (fd > 0 && addfd->ioctl_flags & SECCOMP_ADDFD_FLAG_IO_URING) {
> > >         +               /*
> > >         +                * - call your io_uring seccomp api to update the references in the io_uring instance
> > >         +                */
> > > 			io_uring_seccomp_notify()
> > >         +       }
> > 
> > Looks reasonable to me, thanks.
> 
> One change I might suggest is only using a single flag bit -- we don't
> need to consume all of seccomp's remaining flag bits with the various
> subsystems. If you want to do this logic for epoll, you almost
> certainly want it for io_uring, select, and whatever else is out
> there.
> 
> Tycho

Thank you for your comment and thoughts on this Christian. The per-subsystem
helper and calling this from seccomp add fd looks like a cleaner API. I'll
address the changes in v5.