Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3501064rwl; Mon, 27 Mar 2023 15:18:27 -0700 (PDT) X-Google-Smtp-Source: AK7set/bybNAdoRmML6zA8UV2HyYJ6theBQz5Fcp2WbxIJnCp1szSavXkA4dxz5J9iSWza27xY3Z X-Received: by 2002:a05:6a20:3aa6:b0:d9:a39d:2b77 with SMTP id d38-20020a056a203aa600b000d9a39d2b77mr13188386pzh.1.1679955506728; Mon, 27 Mar 2023 15:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679955506; cv=none; d=google.com; s=arc-20160816; b=l03Jt49Br3Z6r+aN1luJiOR1/kSIrU9EXoP0n2Pr8l482XzGDS1Qg+6N40TjCd7ZRU I5qUCVDarm4kxToDorxP2sLUGQOoVqtOpd2RbB6O9niHnIyEW2kEEX2FwoZZVtnFtPoA AnMVFpqMeBMABULckpwygAlpoCprq9BgFWE5ZumVS3L06wB/BuYobtQh3FSLsRGdBOZr YbwtwHmBcgzvpfwKOBpDpwsa5VVQj3ulhqLuA6RA/G/38qKoGSpW4XCQuj3QKKDzhbI0 1NbyQlRgRN6jtDuRI6zIh1wuIWXuX/m77ARnoVhEPQcf0glo4qglGo1xPurHdFllQFwv 9sMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6Ng5vfFWPRK672V1V9mEH+5cYJAFAK0wLHLZvbZZU88=; b=szFVzky3P86VOPr7Kw8PikjX+lTGZpyE9bItOURhmWr/FtjmA8l133hMNveqsOFdSd s7VYiJXd13s20itTYTqEyc6pilkOx97HAMuU4cowdJpLV33SZf9hvZyYnxzLP9bW0rkP I0rtIHJ0PcLxAxvmPaS5gAgu/utxNkYUGb+WDLHUep5q/nQsOnzODzcqlxWPsoUJY+w7 D8Wf1z5SuVOzcbYS2NXFI7DucllN0qatVPNpZrDPtRnhh0Tc7JokqiBKJWgpRuH+o1dj F9fpej3iT4UNewh+qyNAbcm2LlPCgkNV7sG6iP8jpXvldKrsnBicldgtk2Q/wzOXSqeX 7f8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=vM62KkjX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h30-20020aa79f5e000000b0062a52a1c916si10400477pfr.137.2023.03.27.15.18.14; Mon, 27 Mar 2023 15:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=vM62KkjX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjC0WOJ (ORCPT + 99 others); Mon, 27 Mar 2023 18:14:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjC0WOH (ORCPT ); Mon, 27 Mar 2023 18:14:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2783710A; Mon, 27 Mar 2023 15:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6Ng5vfFWPRK672V1V9mEH+5cYJAFAK0wLHLZvbZZU88=; b=vM62KkjXeWcZx2bTMrrlozyHAd LdP8IlWHJ8zF07UihwBDRaANHzf5lygmPj8Quuht3eABbAKF8eDHx7ENiRPj7s6GmPElBP9WOLB80 R8M5/v+9vjazdVSPOyL5dEi4bqPnXhPgvrBGK3jhuwfl5JbtIHLwmLwmlXNDo+KtLrKp5IvGvfb5r 1HU8F3pcBOP1+4yKF1dPGNeqdffjHo/eSDdnmRCEnKvoheX9C6HidV8ChA+Y5NfUL80dR8emlflbN 5siwWfow/Q3Vm7Syl/GXhtZIWrWOa2jGbrzFSA4JmHhZRJQlzkawG2yWWbVDnQeHi/aLnmgPqpbsj 0hEAfIlA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pgv6L-00CVOM-2R; Mon, 27 Mar 2023 22:14:05 +0000 Date: Mon, 27 Mar 2023 15:14:05 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, willy@infradead.org, axboe@kernel.dk Subject: Re: [PATCH 0/2] bio iter improvements Message-ID: References: <20230327174402.1655365-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327174402.1655365-1-kent.overstreet@linux.dev> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2023 at 01:44:00PM -0400, Kent Overstreet wrote: > Small patch series cleaning up/standardizing bio_for_each_segment_all(), > which means we can use the same guts for bio_for_each_folio_all(), > considerably simplifying that code. > > The squashfs maintainer will want to look at and test those changes, > that code was doing some slightly tricky things. The rest was a pretty > mechanical conversion. Can you post a code size comparism for the before and after cases?