Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3699189rwl;
        Mon, 27 Mar 2023 18:48:53 -0700 (PDT)
X-Google-Smtp-Source: AKy350anaHGgFWq+LyZ1yVJxqGgGyoLtsOnhn1iql1laseyaWcGbEzjGM4brpCfM9z/y5XZ2IMd5
X-Received: by 2002:a17:907:75f2:b0:88a:1ea9:a5ea with SMTP id jz18-20020a17090775f200b0088a1ea9a5eamr13311429ejc.65.1679968133050;
        Mon, 27 Mar 2023 18:48:53 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679968133; cv=none;
        d=google.com; s=arc-20160816;
        b=NhIxU6M/4/XDAobU4LdCzIVUtfPwfeOy9tOIuiC4hJ6asHnDyVgUHfmBjLGBhbHfnu
         HazU1qpookw6Y1U+qAfviYgNZq50L7+qFGIq+biU1JGJOsXwusLKXJGzW40nCxWl1d7d
         kGV5yRbBqaE9cRT0yoYgWXNtehgrjeLsthR6VcGHflP7erSMj+4AUAXvEPuq+4m8JxsL
         WuNYh3VqYZpz4l+blOQ06mXw3vwbVe7uXmy+swmkh2VC+qvNsc5Vnv2YLT10QcjMUZqh
         CtCPn1EN5eqKxwlaWn4dD+QGkoYTWXXAcLtJJ83tptghGGhUjIG50GZCR0z1HbVnrldc
         /+wg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=yiAuOvNscONHKuowuI7HPYf77O2fp0glVUU+c2+auVE=;
        b=HgSIg8Aa9NrsC4XgjLgZBXfs8v7akJL2H0oZrgMK1+ORvLWkxBU6gAZP6b9RjNsjml
         9mlPR3ePM+n4g5WxrVoHGqCD2LLfiRFqDvyKnDgbyG98Eb39yqKakntmPPRGOXG8NG1F
         lp3kcz0bc9qZZWYFoRWIUKZLknKtcYoN9F1YEe//dFs/SMS4G63zonXQRt/mO8M9Vf2I
         mHJ+avBWXQsH8nzOC2jLdnrr4a9R6DEJhSs6xauY3jDz6/DrlDLMa23SqfYd5AD+S4UF
         XWVKhg1b7r+nZQ9FpcEbPtUykm2eaJ5gdZMFl/DW/ytISR4FnmsoN7seJEvDMof9vAUp
         64jA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=DZ6krAY2;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id c11-20020a17090654cb00b0092043425e1bsi12784453ejp.714.2023.03.27.18.48.28;
        Mon, 27 Mar 2023 18:48:53 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=DZ6krAY2;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229952AbjC1Box (ORCPT <rfc822;andreqb@gmail.com> + 99 others);
        Mon, 27 Mar 2023 21:44:53 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47502 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229608AbjC1Bov (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Mar 2023 21:44:51 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E6068E;
        Mon, 27 Mar 2023 18:44:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=yiAuOvNscONHKuowuI7HPYf77O2fp0glVUU+c2+auVE=; b=DZ6krAY2JsYaX67+UjU/+As5YC
        bCJzMrVwBrXnwljWtkhhKTI+tneNR+5PJYmO12KAbAmuJX3yTTc/rD7gbEG5BwjL7WahvM16V9ey9
        uLIAzejFUMiXPiDdjWy5rYxjTakhPcg2xPFu1U0XnkBsFapLFWwr9NaP6CXea6JFDj7HswJRjVsGe
        qEUqk2sO8EUP4mq5e1gLb4Q5inbHtX8wEDqT8YKv++q6EsQvYk6W8etr3eiIKwLehZmG1DzuKyIhJ
        9db9sQP3xXIT0ExLuuxMqovuAIjWc3FgTuyD+aMgPEQTvWJYqUm18AYs5ceoxhSGUbEs3hrPSlg3b
        YvK13GDg==;
Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux))
        id 1pgyOF-00CoIS-3A;
        Tue, 28 Mar 2023 01:44:47 +0000
Date:   Mon, 27 Mar 2023 18:44:47 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     Ye Bin <yebin@huaweicloud.com>, linux-xfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, Ye Bin <yebin10@huawei.com>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: fix BUG_ON in xfs_getbmap()
Message-ID: <ZCJGjxfyeIebn0vj@infradead.org>
References: <20230327140218.4154709-1-yebin@huaweicloud.com>
 <20230327151524.GC16180@frogsfrogsfrogs>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230327151524.GC16180@frogsfrogsfrogs>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 27, 2023 at 08:15:24AM -0700, Darrick J. Wong wrote:
> [add Christoph to cc since he added/last touched this assert, I think]

I only really moved the ASSERT as part of an interface rewrite.  I'll
try to throw in my 2 cents anyway..