Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
CC:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 6/6] iommu/vt-d: Remove unnecessary checks in iopf
 disabling path
Thread-Topic: [PATCH v3 6/6] iommu/vt-d: Remove unnecessary checks in iopf
 disabling path
Thread-Index: AQHZXkiN6RW9RnA21UqhUY/nYgdm668PeJcQ
Date:   Tue, 28 Mar 2023 02:11:46 +0000
Message-ID: <BN9PR11MB52765ACD4408975FBB7EC4A78C889@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230324120234.313643-1-baolu.lu@linux.intel.com>
 <20230324120234.313643-7-baolu.lu@linux.intel.com>
In-Reply-To: <20230324120234.313643-7-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3rWgQJdwQSdN7zzgpKASOnma3oPpeh/RVZoyVIcTUJIPQTUEREDNKiA11Hp+?=
 =?us-ascii?Q?SyGSFofzUHuw8ef2RJTFqQ+LHSIXTdJUdUS+IYdjGbtgLnFEM/jGfE2Q6XOo?=
 =?us-ascii?Q?E605TdKUMdHYLuhHdb4E0HpPwF+JUfL3M70p6OxZxlkOjgYXBm/0yKTX/ql1?=
 =?us-ascii?Q?NHt2Stp7CgqNcK6KJPcBBQvIea5uroQev4qHA6V3V7L6NTZYfaqaQ63WLt99?=
 =?us-ascii?Q?eJhrPCUYi889Re0hSVR0oGyIh4sA94lAZE/CzGQgJKfpZMyLSxiI99Q2xuFu?=
 =?us-ascii?Q?0jJst/TAWLzDPTTjtZiMDrNP6mVCCiZ6rZQfq0+j89IQwG4FWmleuKPM6f5Z?=
 =?us-ascii?Q?o32uEgQD7Hihczn3awBHIDJoCC7xDEHTMbE8oLcOxYfII/IBzkfJ8kOYkWoZ?=
 =?us-ascii?Q?gLh574j7TJ8zmefK3Dj13TrpIc2upQ/nR+g6PsokYzvuuQGuKWqxzkpIpCFa?=
 =?us-ascii?Q?XTd2dKgC/oFKK8C2oBvSvtGofhnW5gVuDY8wDFlwl4Mx8FFjfD7jvH+S2mOF?=
 =?us-ascii?Q?hr3YkUZuChsovRd1x0q7h95QIPFrzZLzjAN/Xa+uCnzq7efuvTowKhJyGz7v?=
 =?us-ascii?Q?QlTaR0wPW4Vgi8YmOLuYRCZiasZ3yFXmu85trnqwPBOV46MCPykyzgvWSWQL?=
 =?us-ascii?Q?ihz6ZsUE3B2/MsnRMmPK5IUdDf5XGoH76k+oZchJrkML7M8uloqGOHtCVqtS?=
 =?us-ascii?Q?I8F97YPavcbiIjTjgrktcE95Ri+W6qPuSx0F25e5vDvm3b9HtN2ljKBOlxBq?=
 =?us-ascii?Q?xFRDSV5Yn22lLHtUu2B7n3TqAvm58AH+IH56KPc0kpuRMXj7Vm+HTuk7p5GI?=
 =?us-ascii?Q?1bv3UNv8NkKXKMSkL6DQeTf8mts0dPmDLeOGgzxiy61EZAiXcjTUn4tKqDin?=
 =?us-ascii?Q?JxyeDStVXRyZAn9otS7XfRVmoOggOKHzW0rr1rUon8nqBgeb17Bv9krOvGN0?=
 =?us-ascii?Q?UxfBCQgkKClDH74k4lQrTXVnJWF53nJUleaOQDnRWmi71BABVPBt3QLPhfde?=
 =?us-ascii?Q?Y/Qy4GFWWICc6UkeMfjeRQbee0oT03+PeZd7/zdY3yyfyAaGUbIfSQYSLANO?=
 =?us-ascii?Q?mivMe+IdcYj9IBfKIgQnJRq+pyVQOCqQojahelf4sWTIq2g/S9eouKGH1rrz?=
 =?us-ascii?Q?A96mp7JRxfuglSrPy3+hknRWV4lcwNSS2YG3Lm9s/iZuzkCiTwbBYW3riSpO?=
 =?us-ascii?Q?5qk8Fz6qSa14uNX8q97DPiL+hGTt++yxkj72ao4DNxQdcu2Nwe675VHgUTZo?=
 =?us-ascii?Q?i9CF9b29B67hy/JW9tE+xtqIiTBm2NRtjTc6y87lhCOF7Z8K/WoqdjVEdUnr?=
 =?us-ascii?Q?HBpiPpaPOKn2WeliuF0nmOjXbJXq2EwxeOfEkl9hs0NTVKR0V5qvNaZmYJC+?=
 =?us-ascii?Q?CWtO/PxMEbpHobgCeL5RKWD7ocHrbajIxcxx2wp83h++DFNMQUnn7Hzbras7?=
 =?us-ascii?Q?2GlErb2oea1SkMyIUrJ9GOGKeF3rYO/BKHMorjFf/sBX75AZbv6eKsYSxy3X?=
 =?us-ascii?Q?RhajApF4vR7riDBAdcwcjvsrAP6rWNJHCloy0FwFi/UFG8TdnPqzgiWJ9z0a?=
 =?us-ascii?Q?yiPwKJWKfVmsZaS9PPWq8aXkPn0ffLRSOClWiGyF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c903d89-ff81-4514-1f0c-08db2f31c83d
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2023 02:11:46.2226
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Tve0Fdv0/Jak5V2QqWLn79NK6luWQ+4YUpa6BUJI/fyQPY/jzVGdYjvb0N7efeqz3/ykKM2xJkslvDx4/Q8U7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5460
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Friday, March 24, 2023 8:03 PM
>=20
> iommu_unregister_device_fault_handler() and iopf_queue_remove_device()
> are called after device has stopped issuing new page falut requests and
> all outstanding page requests have been drained. They should never fail.
> Trigger a warning if it happens unfortunately.
>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>