Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 21:49:12 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     ye.xingchen@zte.com.cn
Cc:     keescook@chromium.org, yzaikin@google.com,
        akpm@linux-foundation.org, chi.minghao@zte.com.cn,
        linmiaohe@huawei.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V7 1/2] mm: compaction: move compaction sysctl to its own
 file
Message-ID: <ZCJxyOX22ZeijBys@bombadil.infradead.org>
References: <202303281002046981494@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202303281002046981494@zte.com.cn>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Tue, Mar 28, 2023 at 10:02:04AM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> This moves all compaction sysctls to its own file.
> 
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Your commit log did not improve as requested sadly. Please look at
the other kernel/sysctl.c changes and you can find much better
motivations documented before there.

For example a467257ffe4 ("kernel/kexec_core: move kexec_core sysctls
into its own file"). You can also now add the defconfig size results
you had mentioned last.

  Luis