Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4fcb67bf-aa12-61c3-ca30-3fb11eaba67a@linaro.org>
Date:   Tue, 28 Mar 2023 08:32:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] dt-bindings: mips: lantiq: Document Lantiq SoC dt
 bindings
Content-Language: en-US
To:     Aleksander Bajkowski <olek2@wp.pl>, tsbogend@alpha.franken.de,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230326122942.870990-1-olek2@wp.pl>
 <3871e958-79aa-2b4c-3300-270a2eb8f8e8@linaro.org>
 <b3e0502b-61d0-430e-8832-dbbec69035a5@wp.pl>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <b3e0502b-61d0-430e-8832-dbbec69035a5@wp.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/03/2023 23:21, Aleksander Bajkowski wrote:
>>> +properties:
>>> +  $nodename:
>>> +    const: "/"
>>> +  compatible:
>>> +    oneOf:
>>> +      - description: Boards with Lantiq Amazon-SE SoC
>>> +        items:
>>> +          - const: lantiq,ase
>> This does not look like proper board compatible. Boards have almost
>> always minimum two compatibles - one for SoC and one for board. With
>> commit msg this just adds to confusion...
>>
> 
> The added dt-binding contains only the SoC part. The compatible strings
> for individual boards will be added later together with the dts files. Before
> sending the dts files I want to document current bindings and clear
> checkpach warnings about undocumented strings.

Which is incomplete and inaccurate documentation. Instead, document
proper, full compatibles.

Best regards,
Krzysztof