Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>
CC:     Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org>,
        "David Woodhouse" <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>
Subject: RE: [PATCH v2 6/8] iommu/vt-d: Implement set_dev_pasid domain op
Thread-Topic: [PATCH v2 6/8] iommu/vt-d: Implement set_dev_pasid domain op
Thread-Index: AQHZYQJZG2KyXXm2pk6VVsU4SfiGqq8P0HAw
Date:   Tue, 28 Mar 2023 07:47:45 +0000
Message-ID: <BN9PR11MB5276B3FF6D21608BB17E32A18C889@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230327232138.1490712-1-jacob.jun.pan@linux.intel.com>
 <20230327232138.1490712-7-jacob.jun.pan@linux.intel.com>
In-Reply-To: <20230327232138.1490712-7-jacob.jun.pan@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i1MxQTif7wadC1zX9uUXiru0TDcM2XbH7NbCsO2g85dPFHwp3yJbN5S0SbYI?=
 =?us-ascii?Q?CMioJhvhHb6O2y8ZvYcGpjKqR3Qp7/RIRsxH4MMthuTc8KPN1WZLAUH+Mq+T?=
 =?us-ascii?Q?5S7kHfkL8iJzHXRLll0W17wA8TRuplKPWVQUPL4fjwE3tlapfS+ZeD+GgWvA?=
 =?us-ascii?Q?AegRxxGpNk5CoVUCTAfypoPauRcre7NBoDTEkzaXL4wJ88g7lYHsaAGJMOUX?=
 =?us-ascii?Q?OUuMosf8BIenMa65QASbEbN+VweTGgPl9WWR06NFw1Utb9ylLKaFgBVfRUGQ?=
 =?us-ascii?Q?nQvo6xnYtAdxCEB7jlhgitSxDZz8TSUYGaxSMXAr+UoSAlWLckJ0C2AOD1vH?=
 =?us-ascii?Q?sr88L0ona3pfLIGCpY2yh0xIpdjXGRNgbo7jO6UFVVtkH/ScnpCr+IYDXbNH?=
 =?us-ascii?Q?iEErCmL4vNvXsUGhetPhz5ykTKRW3SVRQp6AwZdfZdt0tXa2mhbCr7gpORMP?=
 =?us-ascii?Q?3dMiFImUl5T5EAsYPvoKw0zk/R5QfaqdFTdD7jg5iNlz2XDnU4YzBkw0+IOR?=
 =?us-ascii?Q?n/EHpDoxHoZDeUK2PDEZTTqoDPSq+eLR++LBg4o8TAWc3kNmSFbu3HPlwAZw?=
 =?us-ascii?Q?sVuXcWvTP+OpoSNOTp6/xz9hRJcFAqs7sltOjQPExjNjZgJPByvR48aj1JM/?=
 =?us-ascii?Q?XDi5koH/MmTE5fRXfQmXfDZkjx9syhlVq+hXamHWSpDAf5A3XgEjm0tbF2ov?=
 =?us-ascii?Q?IYKLuyoM+H7EaoCk+q6eOhbDEqB1kO1hw8+UA0AP893LmiSFBk4TpqA07BSp?=
 =?us-ascii?Q?TEeL4VHAZ8XpDZBVMFtOHKq9d9GBgKz42G+GywJJzCQaFs16r9rnoI318mSA?=
 =?us-ascii?Q?e3w7tkEuWyxt1ETCPwaKUz+QLrS+sYJQ/F6PoHel5hgUWeaYZKrCvTk6OpFZ?=
 =?us-ascii?Q?XpWUaRQ0nz1cMgzUUhoTIGTYCjob0SkCohJwkAP4vqQmdtounvXEN5Jxjqpv?=
 =?us-ascii?Q?hjKNOmDFRbhzwbDwh8W7Ab6rtI9r3Ot4l6gzEFFDYJ8cNEAXn5mlXUEYnpFV?=
 =?us-ascii?Q?ugxPOBw4sw1JWH3yz+AGEyy6pW0U7yHZC/MlBr45h+mMcS7V5QG5d2TD69Ll?=
 =?us-ascii?Q?Hoehvtr/KsyQUNYAowvMh7z8v7+62thAin31H1SmgE3IP1LniL7cCUr8zgnQ?=
 =?us-ascii?Q?b8DmF/Wr4wYhlIX0muTQ4S0PLaOvyl1E7CkhWSO/q93NPFKOd+k0OPUwSTxC?=
 =?us-ascii?Q?L07IaeBJCsHnjVzjrH7zFGxN7BEFWn3K7SigweRaaoNUH62BkvjBkEBcsLrZ?=
 =?us-ascii?Q?pwzrso/HcroQBUDIRG82Hmjx/YmlgYYUG2EZd1pyP7qwZQ5Q64sWSK9/qTcv?=
 =?us-ascii?Q?xugWNWmfi5H+heTJ/K6JzrEfM78DeYxUKueQc4h0s2yAcrEfyJ3WQw3/MpnX?=
 =?us-ascii?Q?ho1ikq1k4MGzgUzPvEyC1FCrn66ADPH4nsXNx17R7f2B062SCy7IipUjfdVP?=
 =?us-ascii?Q?q0KNa4MJCq67er5jL+10XmVrTwaQHNTtl8ea2oCSxTvXqRXQHlUyv4m0Y2bN?=
 =?us-ascii?Q?BoiZ1az6ksBCBtKMCjwhympzwe5KdAWe+P67OliZhx9IkXTWVqRQqwHr8ra0?=
 =?us-ascii?Q?PeIplQa9RsDnF+j7EqBXPHjCFAAJ7xuvcrt53BuP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d752ad30-3946-4981-41b3-08db2f60b7f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2023 07:47:45.2091
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4ykpeCBbp/xMnIHbaiKvgBE3BYzhEMoMczUnPU1l4/pJQiu9VNau6yoXu+jkamLIiY9fVrT+5wNAMaxzQQW9/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5042
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Tuesday, March 28, 2023 7:22 AM
>=20
> Devices that use ENQCMDS to submit work on buffers mapped by DMA API
> must attach a PASID to the default domain of the device. In preparation
> for this use case, this patch implements set_dev_pasid() for the
> default_domain_ops. Besides PASID attachment, device will also be
> attached to the domain as the result of this call if the device has not
> been attached before.
>=20

I didn't get the last point. PASID attach should only have the scope
for the pasid. RID of the device might be attached to another domain
which shouldn't be changed by this call.