Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d4409486-7b3e-5b59-3b4e-9e832a7c98d5@xen0n.name>
Date:   Tue, 28 Mar 2023 15:52:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: [PATCH v2] loongarch/bpf: Skip speculation barrier opcode, which
 caused ltp testcase bpf_prog02 to fail
Content-Language: en-US
To:     Daniel Borkmann <daniel@iogearbox.net>,
        George Guo <guodongtai@kylinos.cn>
Cc:     ast@kernel.org, bpf@vger.kernel.org, chenhuacai@kernel.org,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongarch@lists.linux.dev, masahiroy@kernel.org,
        michal.lkml@markovi.net, ndesaulniers@google.com,
        hengqi.chen@gmail.com, yangtiezhu@loongson.cn,
        tangyouling@loongson.cn
References: <c1932d0d-cf3f-5005-958d-7e08dddf42c9@iogearbox.net>
 <20230328071335.2664966-1-guodongtai@kylinos.cn>
 <ddb2f552-252f-4533-469b-31044b4fc2d6@iogearbox.net>
From:   WANG Xuerui <kernel@xen0n.name>
In-Reply-To: <ddb2f552-252f-4533-469b-31044b4fc2d6@iogearbox.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023/3/28 15:22, Daniel Borkmann wrote:
> On 3/28/23 9:13 AM, George Guo wrote:
>> Here just skip the opcode(BPF_ST | BPF_NOSPEC) that has no couterpart 
>> to the loongarch.
>>
>> <snip>
>>
>> diff --git a/arch/loongarch/net/bpf_jit.c b/arch/loongarch/net/bpf_jit.c
>> index 288003a9f0ca..d3c6b1c4ccbb 100644
>> --- a/arch/loongarch/net/bpf_jit.c
>> +++ b/arch/loongarch/net/bpf_jit.c
>> @@ -1022,6 +1022,11 @@ static int build_insn(const struct bpf_insn 
>> *insn, struct jit_ctx *ctx, bool ext
>>           emit_atomic(insn, ctx);
>>           break;
>> +    /* Speculation barrier */
>> +    case BPF_ST | BPF_NOSPEC:
>> +        pr_info_once("bpf_jit: skip speculation barrier opcode 
>> %0x2x\n", code);
>> +        break;
> 
> Thanks that looks better. Question to LoongArch folks (Cc): There is no 
> equivalent
> to a speculation barrier here, correct? Either way, I think the 
> pr_info_once() can
> just be removed given there is little value for a users to have this in 
> the kernel
> log. I can take care of this while applying, that's fine.

I can confirm there's currently no speculation barrier equivalent on 
lonogarch. (Loongson says there are builtin mitigations for Spectre-V1 
and V2 on their chips, and AFAIK efforts to port the exploits to 
mips/loongarch have all failed a few years ago.)

And yes I'd agree with removing the warning altogether. Thanks for the 
reviews!

Acked-by: WANG Xuerui <git@xen0n.name>

> 
>>       default:
>>           pr_err("bpf_jit: unknown opcode %02x\n", code);
>>           return -EINVAL;
>>
> 

-- 
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/