Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4055731rwl; Tue, 28 Mar 2023 01:47:59 -0700 (PDT) X-Google-Smtp-Source: AKy350ZtwRy51ZmsUcAUf5Y37hx1fFfSbA9WzXmVO1WeK37wOmE2Ukq7E21/lw3usEZm6Em1Hkbh X-Received: by 2002:a17:903:3015:b0:1a1:9ff6:ca9 with SMTP id o21-20020a170903301500b001a19ff60ca9mr10747703pla.28.1679993279710; Tue, 28 Mar 2023 01:47:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679993279; cv=none; d=google.com; s=arc-20160816; b=HzxStcbSgmqPpIAokY0XWPpPYwloG3kR1QHqOvboUWBQiMu9al4b0KSUi5gwh0WOc3 S9JUMFhTptsMi4TYwjnEiabx/fXGojVBmuHUFTtYFAdFH9bQZoqyf42e8EjvisF02op8 zZ/dNYhND0MBBJegmRQ9qqRnCNe1meFZRINMyagAw78R7RmsYcDcoFqlJYPfCmKopbIn QsY7bbWbJMET5moy2N7zn7KqmQzfueJ4lpbB0FwJ+qw6EbP//Llb/OTt/nLxxTwz+a3E E7sQi+zjsnyFdr67CA6mDt3hFOPrsuwBAiSN0Q7JywX8jH6Xy7vAZwhmDaFF0HSqzS60 HBtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature:dkim-signature; bh=TwlX1ZKKkpep42Df/aSvGTZTqr74ekNzHcssqi3oj/A=; b=MwF7hH+ywtW2CfbZMJ2juMfO1jpOb560pN+KDZO5JSHNfRrNV9w/UcIRNyR/+oWbsO vPAbfaXNRwlt99PVHy5Co935h0xHKICgeKUqVr492sXYg8dQdWcE1xJ8ZETi3nwHVX/h ktALEXhE+zYrF7dVIKHyCqC0XKlZ1sd6wmLo7/iFgu7GilUEhRKxJO1CvXVdtDXWmrMq /8Hwh5CwFgEvwgQ1VzZzxvoKJs4SVKcL4X4yHJboOp70Sj70kXs14BDnTde7WZ8mdTiq a2SUWuou+vy+DxPZZgU9R5mIPMi5Oxdaj+M/jk0k5Fv8p2lNA5hwQbssvYjz1vgsI8Ak 4M2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=y+ToxPFH; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 16-20020a631850000000b005133f7ca477si6671059pgy.707.2023.03.28.01.47.46; Tue, 28 Mar 2023 01:47:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=y+ToxPFH; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbjC1Ira (ORCPT + 99 others); Tue, 28 Mar 2023 04:47:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbjC1Ir3 (ORCPT ); Tue, 28 Mar 2023 04:47:29 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45C454C05 for ; Tue, 28 Mar 2023 01:47:28 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 0273E1FDA1; Tue, 28 Mar 2023 08:47:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679993247; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TwlX1ZKKkpep42Df/aSvGTZTqr74ekNzHcssqi3oj/A=; b=y+ToxPFHRRDoH/1AcZt/wwqBWPfU577F891yLLh3rAIGlz1IkVe6E9I8E6vmBecBpJYta1 QkgLA6PwJg04DeVRUjsz0W2I710EB4iy3unqoULBVAHo4qw0f7IhAoIaD96ZrnCq7KuNdu uXlp4e7UrWF615UkL9LHd+X33Bx13gI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679993247; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TwlX1ZKKkpep42Df/aSvGTZTqr74ekNzHcssqi3oj/A=; b=1rSMvy3cHaVPk78kum3InCQzJB4kOLdLih2r/iRZ0x89j3+kAwIGpWMtz0KdCWjD39JJB5 cSruqpzBTcLMg7Dg== Received: from pobox.suse.cz (pobox.suse.cz [10.100.2.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D490F2C141; Tue, 28 Mar 2023 08:47:26 +0000 (UTC) Date: Tue, 28 Mar 2023 10:47:26 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf cc: x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [PATCH 1/5] objtool: Add '--verbose' option for disassembling affected functions In-Reply-To: <217a005fe22f9d33f99fed499d6508af9f5cabd0.1679932620.git.jpoimboe@kernel.org> Message-ID: References: <217a005fe22f9d33f99fed499d6508af9f5cabd0.1679932620.git.jpoimboe@kernel.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static inline void objdump_func(struct section *sec, unsigned long offset) > +{ > + struct symbol *sym = find_func_containing(sec, offset); Unnecessary assignment? > + const char *script_relative = "scripts/objdump-func"; > + bool is_text = (sec->sh.sh_flags & SHF_EXECINSTR); > + char *cmd, *srctree, *script; > + > + if (is_text) > + sym = find_func_containing(sec, offset); > + if (!sym) > + sym = find_symbol_containing(sec, offset); > + if (!sym) > + return; Miroslav