Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3630bb5-a2a9-6f38-c70a-eb4b8ea1630d@linaro.org>
Date:   Tue, 28 Mar 2023 11:16:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v3 15/18] arm64: dts: qcom: sa8775p-ride: set
 gpio-line-names for PMIC GPIOs
Content-Language: en-US
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
References: <20230327125316.210812-1-brgl@bgdev.pl>
 <20230327125316.210812-16-brgl@bgdev.pl>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230327125316.210812-16-brgl@bgdev.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27.03.2023 14:53, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Set line names for GPIO lines exposed by PMICs on sa8775p-ride.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 51 +++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> index b7ee4cc676b5..a0d2024a69df 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> @@ -32,6 +32,57 @@ &i2c18 {
>  	status = "okay";
>  };
>  
> +&pmm8654au_0_gpios {
> +	gpio-line-names = "DS_EN",
> +			  "POFF_COMPLETE",
> +			  "UFS0_VER_ID",
> +			  "FAST_POFF",
> +			  "DBU1_PON_DONE",
> +			  "AOSS_SLEEP",
> +			  "CAM_DES0_EN",
> +			  "CAM_DES1_EN",
> +			  "CAM_DES2_EN",
> +			  "CAM_DES3_EN",
> +			  "UEFI",
> +			  "ANALOG_PON_OPT";
> +};
> +
> +&pmm8654au_1_gpios {
> +	gpio-line-names = "PMIC_C_ID0",
> +			  "PMIC_C_ID1",
> +			  "UFS1_VER_ID",
> +			  "IPA_PWR",
> +			  "",
> +			  "WLAN_DBU4_EN",
> +			  "WLAN_EN",
> +			  "BT_EN",
> +			  "USB2_PWR_EN",
> +			  "USB2_FAULT";
> +};
> +
> +&pmm8654au_2_gpios {
> +	gpio-line-names = "PMIC_E_ID0",
> +			  "PMIC_E_ID1",
> +			  "USB0_PWR_EN",
> +			  "USB0_FAULT",
> +			  "SENSOR_IRQ_1",
> +			  "SENSOR_IRQ_2",
> +			  "SENSOR_RST",
> +			  "SGMIIO0_RST",
> +			  "SGMIIO1_RST",
> +			  "USB1_PWR_ENABLE",
> +			  "USB1_FAULT",
> +			  "VMON_SPX8";
> +};
> +
> +&pmm8654au_3_gpios {
> +	gpio-line-names = "PMIC_G_ID0",
> +			  "PMIC_G_ID1",
> +			  "GNSS_RST",
> +			  "GNSS_EN",
> +			  "GNSS_BOOT_MODE";
> +};
> +
>  &qupv3_id_1 {
>  	status = "okay";
>  };