Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4097505rwl; Tue, 28 Mar 2023 02:32:32 -0700 (PDT) X-Google-Smtp-Source: AKy350bF1OVVk1YnMIBRTEZsEp4dWx9/9SVG/2eX0R9VpwZab6tpy4Ji2GnyxefsdfDakeW0KT82 X-Received: by 2002:aa7:db4f:0:b0:4fd:298a:62cb with SMTP id n15-20020aa7db4f000000b004fd298a62cbmr13874558edt.21.1679995951852; Tue, 28 Mar 2023 02:32:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679995951; cv=none; d=google.com; s=arc-20160816; b=t4srjIagxYhCqq7lcZSPo0siyNKXmoi9YFpVnEic4az9drCPQh/+2Ch1GQRQJ0qYl1 4lzs6dBPBQabgTyVR6ZssURnBDSbEbOwrPF8I6F0M7BXvHnzO5toRM14TbKS2GscEChC UnPW43cUCeFM6VTJ5UUggTcn7Sltb0b3COvUIt/+OlFtE9Xrehz55oQyRsfTl508nRvP mvdtlOKAGKb8x5Iolu8saq0CFngT67IpQmlsNxsww4a9W1T5aoP4z3pVQgmrxO4X7alV XIZ8gzl0EiSaagvmhPXO1CxUdafdHa8sNQisRhmyG5RA2lWwQJ3C6x2glc5dn5/6nqhM N/VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=yFB98fl8c+VxJhat2aITQJylt85+D41Na+tueFpnBAE=; b=eD5Ai08sD3gRPMW3/8SVxNcKbfsd5vjNXvJ0wEYyWOucbZxkCLL/l1x4dtpA9hMpkf 4Zpsqy/7rPVO8HoujLpeMroRay5FC9esiDq2ATdznZeG8vTfPbQqvlxP4+3oL3eJ2FCz oSBuhvB1xP8rPYOZ4AhlLOtQp7gspSaVX+VYwXDEvfenmji9JARskbsS9+XLYADEDHij tVy6/n1s85pZ/HfRUYWx+m4QC0hw0+bDnuNR9D6n8ststZ26s8Y2tpB4rB7YD/Om46jE xS3MUfutA4FsISY3lGVB99ILNtlyDgPtgd55Bl5I+Yj3vPLBnW5JinF4P+motuI1ey60 nxdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h6Vz5hHs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d13-20020aa7d68d000000b004fc63fada98si29957457edr.30.2023.03.28.02.32.07; Tue, 28 Mar 2023 02:32:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=h6Vz5hHs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232776AbjC1JbO (ORCPT + 99 others); Tue, 28 Mar 2023 05:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230424AbjC1JaY (ORCPT ); Tue, 28 Mar 2023 05:30:24 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CC907286 for ; Tue, 28 Mar 2023 02:29:19 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id p204so14162302ybc.12 for ; Tue, 28 Mar 2023 02:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1679995751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yFB98fl8c+VxJhat2aITQJylt85+D41Na+tueFpnBAE=; b=h6Vz5hHsFbSVlybmIlvV3llRGY6zxdMBPqd7vuRnJb91gssIrU+JkHC8x3k8jk99aZ TUV+/AV65p6lGjzaxQBmfrutizEWwOo+EZeXN/NHKK4LwatIFW/QwCXbyNZ7bW8Vvnd5 K2dz4isaG3Fg9/yhee6xJqIWq4kl98h+rwO8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679995751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yFB98fl8c+VxJhat2aITQJylt85+D41Na+tueFpnBAE=; b=FO3Tq6YvegBoOLh8iFbaYUr2ZxEkPhZNXeie6hmVQViUCUMhCYhuGa4X3J8MzNZrIW SQ6eHsiufBeBiWltubzd6lCjcQcPeDO/vWQlkQ+LTNgXXztI4qbtzdISM1+Zh95V68wY yFOw3tKWGO8qhHYuxWsS3Mx7D/jyHnANYPhgraHJp/7SQwY6ENmaL2GQhWO95Kws5+kd BziWxbvNaaQZPr2z9lm1YfBoH8mXDm83na6Lzuw0+HDUSKp8UUfRvgYvyjdB03tsbgmi kWQGITh+dioOqRC/xqMj5gmuK+LZzdrzkh2QofZi07fqnjXub7fPacqtmOtUk7nBPzQY M5XA== X-Gm-Message-State: AAQBX9dz7IIh0oC9/e3obsdCmXhfZvWz/aB5E2mIDK+AJ7zoE01IM60f OSvTZW3ypD/XeRNeftlxaEP9uJfJ+voNG34j+WL8hQ== X-Received: by 2002:a05:6902:188f:b0:b78:bced:2e3d with SMTP id cj15-20020a056902188f00b00b78bced2e3dmr7396712ybb.3.1679995751012; Tue, 28 Mar 2023 02:29:11 -0700 (PDT) MIME-Version: 1.0 References: <20230328073328.3949796-1-dario.binacchi@amarulasolutions.com> <20230328084710.jnrwvydewx3atxti@pengutronix.de> In-Reply-To: <20230328084710.jnrwvydewx3atxti@pengutronix.de> From: Dario Binacchi Date: Tue, 28 Mar 2023 11:28:59 +0200 Message-ID: Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller To: Marc Kleine-Budde Cc: linux-kernel@vger.kernel.org, Vincent Mailhol , Rob Herring , Amarula patchwork , michael@amarulasolutions.com, Alexandre Torgue , Krzysztof Kozlowski , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Maxime Coquelin , Paolo Abeni , Rob Herring , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On Tue, Mar 28, 2023 at 10:47=E2=80=AFAM Marc Kleine-Budde wrote: > > On 28.03.2023 09:33:23, Dario Binacchi wrote: > > The series adds support for the basic extended CAN controller (bxCAN) > > found in many low- to middle-end STM32 SoCs. > > > > The driver has been tested on the stm32f469i-discovery board with a > > kernel version 5.19.0-rc2 in loopback + silent mode: > > > > ip link set can0 type can bitrate 125000 loopback on listen-only on > > ip link set up can0 > > candump can0 -L & > > cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 > > > > For uboot and kernel compilation, as well as for rootfs creation I used > > buildroot: > > > > make stm32f469_disco_sd_defconfig > > make > > > > but I had to patch can-utils and busybox as can-utils and iproute are > > not compiled for MMU-less microcotrollers. In the case of can-utils, > > replacing the calls to fork() with vfork(), I was able to compile the > > package with working candump and cansend applications, while in the > > case of iproute, I ran into more than one problem and finally I decided > > to extend busybox's ip link command for CAN-type devices. I'm still > > wondering if it was really necessary, but this way I was able to test > > the driver. > > Applied to linux-can-next. Just one last question: To test this series, as described in the cover letter, I could not use the iproute2 package since the microcontroller is without MMU. I then extended busybox f= or the ip link command. I actually also added the rtnl-link-can.c application to the libmnl library. So now I find myself with two applications that have been useful to me for this type of use case. Did I do useless work because I could use other tools? If instead the tools= for this use case are missing, what do you think is better to do? Submit to their respective repos or add this functionality to another project that I haven't considered ? Thanks and regards, Dario > > Thanks, > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --=20 Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com