Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4fa90fd4-c8c3-6621-4aed-51f916fbddc8@foss.st.com>
Date:   Tue, 28 Mar 2023 11:38:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead
 of checking tRC_min
Content-Language: en-US
To:     Miquel Raynal <miquel.raynal@bootlin.com>
CC:     Tudor Ambarus <tudor.ambarus@linaro.org>, <richard@nod.at>,
        <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>
References: <20230327094742.38856-1-christophe.kerello@foss.st.com>
 <20230327094742.38856-3-christophe.kerello@foss.st.com>
 <75dcd205-5432-7103-370c-d65d792631ea@linaro.org>
 <20230327124313.1ccd3d66@xps-13>
 <70d0a8b6-62c2-fa3e-df5c-f86ba75484d0@linaro.org>
 <6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com>
 <20230328095633.188aff27@xps-13>
From:   Christophe Kerello <christophe.kerello@foss.st.com>
In-Reply-To: <20230328095633.188aff27@xps-13>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Miquel,

On 3/28/23 09:56, Miquel Raynal wrote:
> Hi Christophe,
> 
> christophe.kerello@foss.st.com wrote on Tue, 28 Mar 2023 09:27:55 +0200:
> 
>> Hello Miquel,
>>
>> On 3/27/23 13:06, Tudor Ambarus wrote:
>>>
>>>
>>> On 3/27/23 11:43, Miquel Raynal wrote:
>>>> Hi Tudor,
>>>>
>>>> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100:
>>>>   
>>>>> On 3/27/23 10:47, Christophe Kerello wrote:
>>>>>> This patch is using timings.mode value instead of checking tRC_min timing
>>>>>> for EDO mode support.
>>>>>>     >>>
>>>>> Fixes and Cc to stable here too, as you'd like to have this backported
>>>>> as well, don't you?
>>>>
>>>> Actually the reason why Christophe split this into two patches is
>>>> because timings.mode was introduced rather lately, he wanted the same
>>>> patch to apply on all stable kernels, he actually asked for that split
>>>> and I agreed (another solution would have been to send this current
>>>> patch to Linus and have the other version sent to stable, but it
>>>> requires a bit of scheduling on both ends).
>>>>
>>>> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t
>>>
>>> Right, I understood that from the beginning. If it were to me, I would
>>> Cc: stable@vger.kernel.org #v5.4+ for the first patch and
>>> Cc: stable@vger.kernel.org #v5.10+ for the second.
>>>
>>> So first would be alone just in v5.4, and starting with v5.10 we'll have
>>> both and we'll mimic what we currently have in upstream mainline.
>>>    
>>
>> I can send a V3 with cc tag added as per Tudor's suggestion.
>> Or cc tag will be added when the patches will be applied?
> 
> I'll handle it, no problem. Is it fine if I send this as part of the
> next merge window or do you expect this fix to be applied earlier? I
> just sent my fixes PR on Monday morning.
> 

Yes, it is fine. This patch set can be applied on next merge window.

Regards,
Christophe Kerello.

>>
>> Regards,
>> Christophe Kerello.
>>
>>>>   
>>>>>   
>>>>>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
>>>>>
>>>>> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>>>>>   
>>>>>> ---
>>>>>>    drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +-
>>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>>>>>> index 3abb63d00a0b..9e74bcd90aaa 100644
>>>>>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>>>>>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>>>>>> @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr,
>>>>>>    	if (IS_ERR(sdrt))
>>>>>>    		return PTR_ERR(sdrt);
>>>>>>    >>>> -	if (sdrt->tRC_min < 30000)
>>>>>> +	if (conf->timings.mode > 3)
>>>>>>    		return -EOPNOTSUPP;
>>>>>>    >>>>   	if (chipnr == NAND_DATA_IFACE_CHECK_ONLY)
>>>>
>>>>
>>>> Thanks,
>>>> Miquèl
> 
> 
> Thanks,
> Miquèl