Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 11:53:37 +0200
From:   Andi Shyti <andi.shyti@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Yang Li <yang.lee@linux.alibaba.com>, kyungmin.park@samsung.com,
        myungjoo.ham@samsung.com, cw00.choi@samsung.com,
        alim.akhtar@samsung.com, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] devfreq: exynos-ppmu: Use
 devm_platform_get_and_ioremap_resource()
Message-ID: <20230328095337.sr6s3klmhiyz63pr@intel.intel>
References: <20230328053853.23159-1-yang.lee@linux.alibaba.com>
 <8779217b-bd70-37a4-c779-139690048d4d@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8779217b-bd70-37a4-c779-139690048d4d@linaro.org>
Precedence: bulk

Hi,

On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote:
> On 28/03/2023 07:38, Yang Li wrote:
> > According to commit 890cc39a8799 ("drivers: provide
> > devm_platform_get_and_ioremap_resource()"), convert
> 
> I don't understand why do you reference this commit. There is no bug
> introduced there, there is nothing related to this driver.
> 
> > platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.

I've seen Yang has sent many of these cleanups, perhaps he can
write something like:

"
Commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()") introduces the
devm_platform_get_and_ioremap_resource() function which combines
both platform_get_resource() and devm_ioremap_resource() into a
single call.

Update the code to use the new combined function instead of the
separate calls.
"

With that

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi