Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4146851rwl; Tue, 28 Mar 2023 03:23:36 -0700 (PDT) X-Google-Smtp-Source: AK7set/AWa8227D003Iu2pwpyzJgWgxowynkzR3dzinDRuIgE6EyQqXYXhtfmBke3tzfjLny/og4 X-Received: by 2002:a05:6a20:4904:b0:d9:162d:98e8 with SMTP id ft4-20020a056a20490400b000d9162d98e8mr13907950pzb.13.1679999016621; Tue, 28 Mar 2023 03:23:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679999016; cv=none; d=google.com; s=arc-20160816; b=HmEiudQVeNWZxRT3ESRQND7t1yzJuMc1ZktPFn1H/42pgm5LAbmt2uaSYHevIVZ1cE +URJB/tmf9RjGU8cyCQHXz9EvKS0gjXIn2DsAjsPybxJ9ZpOT+93+Rva9biZVG0jtjuA 4UC+m9FxwMcnaITWeTUfXbWb3nCmxDWhd4jD3/PS8RT2R+TCpjcDy8BwqXEF6uQcbFaI qgQwAdz4uaeIslcccMBBhnHPWB2mHgSn658Y6bnC2JRi6MW3dlqIRpnLnmXI3mqb/w6t wRozn7lslG1EqLy4xd+YwyC/nlkDd6auQsSD6EbupkzXBDrWtC9MpBs9LEX5J1FC+1JZ m2Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from:dkim-signature; bh=nO83ilZNUaVi2upE7lW9WWh6HxclCAqAz05TPcgygzQ=; b=GgvuyvV3RmR84rsZCUFIWqkQZFKAsMok7Olp1R3BE5lUiSefHMTLBQs5mRUrg5F/C7 jQIxx63tScekyQLZU7vDbq1jbeFDcSVxv6RsTLzBEsQZu3GeyCZbfzrALtWG5pzu8KCj txk7ikllIxkYtMh9xnEqXmwNAlYk5DV5/tgKzkHcy0apg+lzc+23ObOcC3DxLsaS7ksv atbhv3d3oGNQBr1xBhJlLPnIdw4ominioDG5H85JIAIgp/wEcyj8T0SfGOPATG9yMY1R dfxvctskm1VsFyY0XQDSvaUBTJm8YqjL/vLiFhhGiKnEwIyGrzZIWEEUwaKi8bqyYnzx 1XdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Pundf8vf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a6566c5000000b00502f344050csi30219022pgw.313.2023.03.28.03.23.25; Tue, 28 Mar 2023 03:23:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Pundf8vf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbjC1KRG (ORCPT + 99 others); Tue, 28 Mar 2023 06:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbjC1KRF (ORCPT ); Tue, 28 Mar 2023 06:17:05 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD42619A3 for ; Tue, 28 Mar 2023 03:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679998605; x=1711534605; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=YNcmTAzIivIIG1nw9WZggF/K2IYvfLlzFc8+1akrKgM=; b=Pundf8vfZkjIf755tBEPpvBd2JCiacgGhLKPduQ4PFre2K6k/Z6EkRR/ zfJEXNnPMl867TFjEKb8wkfd5r2hx/NxRNVgBvLMO8O97SeOwDQuZJJbE ovgPxUbLVTfucVCk1kcPfCKRYusv+tJIWWHsNYB5LNI2ITgXXyowPIPty 2IC/rxT3oZKyQx0ngh1X/LM4nfdlEYjYfXWEOhcsO8NnqU7woihQeLC/h 0m1tY9ZahPSFI6o1Ry1ro0PEEqm/SoscHrz3IncKyWsgOOdJv5WIN+ehp KmxkxaA0bJ/9kdgNB3HyS1YXurqB9Oks2RocCxiP0xvnVDg8jvtSmpui8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10662"; a="339252097" X-IronPort-AV: E=Sophos;i="5.98,297,1673942400"; d="scan'208";a="339252097" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2023 03:16:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10662"; a="929817003" X-IronPort-AV: E=Sophos;i="5.98,297,1673942400"; d="scan'208";a="929817003" Received: from gprivite-mobl.ger.corp.intel.com (HELO localhost) ([10.252.50.147]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2023 03:16:31 -0700 From: Jani Nikula To: Caio Novais , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Felipe Clark , Wenjing Liu , =?utf-8?Q?Ma=C3=ADra?= Canal , Mario Limonciello , Jun Lei , Charlene Liu , Gabe Teeger , Rodrigo Siqueira , Taimur Hassan , Aurabindo Pillai , Alvin Lee , George Shen , Hamza Mahfooz , Chaitanya Dhere , Alan Liu , Mukul Joshi , =?utf-8?Q?A?= =?utf-8?Q?ndr=C3=A9?= Almeida , Jingwen Zhu , Guo Zhengkui , Leo Li , Melissa Wen , Le Ma , Jiapeng Chong , Caio Novais , Martin Leung , Ryan Lin , Brian Chang , Sung Joon Kim , Yifan Zhang , Jack Xiao , Dillon Varone , Tom Chung , Wesley Chalmers , Qingqing Zhuo , "Pan, Xinhui" , Zhan Liu , Roman Li , Christian =?utf-8?Q?K=C3=B6nig?= , Wayne Lin , Alex Deucher , Ethan Wellenreiter , Nicholas Kazlauskas , Joshua Ashton , Hawking Zhang Subject: Re: [PATCH 00/12] drm/amd: Remove unused variables In-Reply-To: <20230327233353.64081-1-caionovais@usp.br> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230327233353.64081-1-caionovais@usp.br> Date: Tue, 28 Mar 2023 13:16:28 +0300 Message-ID: <878rfh5gg3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Mar 2023, Caio Novais wrote: > This patchset cleans the code removing unused variables and one unused > function. > > Caio Novais (12): > Remove unused variable 'r' > Remove unused variable 'value0' > Remove unused variable 'pixel_width' > Remove unused variable 'hubp' > Remove unused variable 'speakers' > Remove unused variable 'mc_vm_apt_default' > Remove unused variable 'optc' > Remove two unused variables 'speakers' and 'channels' and remove > unused function 'speakers_to_channels' > Remove two unused variables 'is_pipe_split_expected' and 'state' > Remove unused variable 'cursor_bpp' > Remove unused variable 'scl_enable' > Remove two unused variables 'result_write_min_hblank' and > 'hblank_size' Curious, how did you create this? It does not match the patches. BR, Jani. > > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 8 ---- > .../amd/display/dc/dcn10/dcn10_link_encoder.c | 3 -- > .../drm/amd/display/dc/dcn201/dcn201_dpp.c | 6 --- > .../drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 - > .../gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c | 2 - > .../gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c | 4 -- > .../drm/amd/display/dc/dcn30/dcn30_hwseq.c | 3 -- > .../gpu/drm/amd/display/dc/dcn31/dcn31_apg.c | 39 ------------------- > .../drm/amd/display/dc/dcn32/dcn32_resource.c | 4 -- > .../display/dc/dcn32/dcn32_resource_helpers.c | 4 -- > .../dc/dml/dcn31/display_rq_dlg_calc_31.c | 2 - > .../dc/link/protocols/link_dp_capability.c | 7 ---- > 12 files changed, 84 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center