Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 13:05:23 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Sumit Gupta <sumitg@nvidia.com>, treding@nvidia.com,
        dmitry.osipenko@collabora.com, viresh.kumar@linaro.org,
        rafael@kernel.org, jonathanh@nvidia.com, robh+dt@kernel.org,
        lpieralisi@kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
        mmaddireddy@nvidia.com, kw@linux.com, bhelgaas@google.com,
        vidyas@nvidia.com, sanjayc@nvidia.com, ksitaraman@nvidia.com,
        ishah@nvidia.com, bbasu@nvidia.com
Subject: Re: [Patch v4 03/10] memory: tegra: add interconnect support for
 DRAM scaling in Tegra234
Message-ID: <ZCLJ895gHPXQE+Lz@orome>
References: <20230327161426.32639-1-sumitg@nvidia.com>
 <20230327161426.32639-4-sumitg@nvidia.com>
 <8b04a266-20eb-f1c1-278f-764b1b06b78b@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="z50dz8DtOK299JG9"
Content-Disposition: inline
In-Reply-To: <8b04a266-20eb-f1c1-278f-764b1b06b78b@linaro.org>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--z50dz8DtOK299JG9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 28, 2023 at 09:31:58AM +0200, Krzysztof Kozlowski wrote:
> On 27/03/2023 18:14, Sumit Gupta wrote:
[...]
> > diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra=
/tegra186-emc.c
[...]
> > @@ -158,6 +260,9 @@ static int tegra186_emc_probe(struct platform_devic=
e *pdev)
> >  	if (!emc)
> >  		return -ENOMEM;
> > =20
> > +	platform_set_drvdata(pdev, emc);
> > +	emc->dev =3D &pdev->dev;
>=20
> This patch looks like stiched from two or more patches... emc->dev does
> not look like new member of emc, thus why do you set in exisitng
> function in this patch? Why it wasn't needed before?

This looks like it may be leftover from some development. These two
lines exist in this driver a few lines further down. Either one pair
should be removed. I don't see why this would need to be moved, so
probably the above additions can just be dropped.

Thierry

> >  	emc->bpmp =3D tegra_bpmp_get(&pdev->dev);
> >  	if (IS_ERR(emc->bpmp))
> >  		return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), "failed to get =
BPMP\n");
> > @@ -236,6 +341,25 @@ static int tegra186_emc_probe(struct platform_devi=
ce *pdev)
> >  	debugfs_create_file("max_rate", S_IRUGO | S_IWUSR, emc->debugfs.root,
> >  			    emc, &tegra186_emc_debug_max_rate_fops);
> > =20
> > +	mc =3D dev_get_drvdata(emc->dev->parent);
> > +	if (mc && mc->soc->icc_ops) {
> > +		/*
> > +		 * Initialize the ICC even if BPMP-FW doesn't support 'MRQ_BWMGR_INT=
'.
> > +		 * Use the flag 'mc->bwmgr_mrq_supported' within MC driver and return
> > +		 * EINVAL instead of passing the request to BPMP-FW later when the BW
> > +		 * request is made by client with 'icc_set_bw()' call.
> > +		 */
> > +		err =3D tegra_emc_interconnect_init(emc);
> > +		if (err)
> > +			goto put_bpmp;
> > +
> > +		if (tegra_bpmp_mrq_is_supported(emc->bpmp, MRQ_BWMGR_INT))
> > +			mc->bwmgr_mrq_supported =3D true;
> > +		else
> > +
>=20
> Drop blank line.
>=20
> > +			dev_info(&pdev->dev, "MRQ_BWMGR_INT not present\n");
>=20
> And what user is supposed to do with this? Either make it descriptive or
> drop.

Agreed. I think we can just drop this. If the intention was to provide a
quick way for people to detect whether BWMGR is available or not, using
something from sysfs/debugfs would be preferable.

Thierry

--z50dz8DtOK299JG9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQiyfAACgkQ3SOs138+
s6FbVA//bUVPUi8Z6YbSbsr4lHpodrVcNKo8kLvOAIm4MrRyRHiEXz+fzcorFDD1
DuvPL76LXtzwRgA6fcQPOgRjeLkTQspfkIb69WzeGYFwqVY6ddPTfMTwucmYwIqZ
4lMCMpiDuv8onPnmMH/l3PEiHFlzETb1IIfIDs6+u1NZ0jVyi0ovEM4y9jGhOb5x
3+K+HFl9zAMLaXRWH+ckLaVJ075FUTZw3rp13v4kCjSy7Zbm3NhnJqf7zftJDfk5
Hxzawn21Yw/Kb5ANSWOuPhwP+has+BPAp1P8JZIgBSURxJaxY1C6Utv6yx7zWWpS
LydIrQBS62gSS0l5Kh095FZbPUwHOKbCh7E0yqvDSz323v+HjhGm1KUeJ42tYKkg
b2D0vwMqSjKVKm2vZ1QqVqvYSU/2UFeo5Iu4niGeOiaRRQ0D93zTmDzK4VN5ISBo
rTQIt3u+ypphgF9rcHixfORuyIE0pmR1UJy+U5D+ko0x6599i5d+gXinXAg67DMG
DUTGb0JP+9FqF5wcpMacTkR+s2eux5IvT+hRaKr0PAzityvDlcnq9lWa6SLkCJsp
eDpPoDcTRGYtaEcy37zU5wtXuV9lLGOUWVrkZiHILwN8S+G8EO6lmM0ISmHemHAJ
acMXRTtGeOMCybdN+qD+41oLPMMlqzgqhNKQWDkPHceO5Lu3jEY=
=xbRH
-----END PGP SIGNATURE-----

--z50dz8DtOK299JG9--