Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 13:39:05 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Svyatoslav Ryhel <clamor95@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] ARM: tegra: transformer: use labels for mmc in
 aliases
Message-ID: <ZCLR2XYBrOVuJHL3@orome>
References: <20230304084319.18424-1-clamor95@gmail.com>
 <20230304084319.18424-4-clamor95@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7hXrrpViK7lmN/l4"
Content-Disposition: inline
In-Reply-To: <20230304084319.18424-4-clamor95@gmail.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--7hXrrpViK7lmN/l4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 04, 2023 at 10:43:17AM +0200, Svyatoslav Ryhel wrote:
> Since mmc devices in common dtsi are labeled let's use labels
> for simpler comprehension of tree.
>=20
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arc=
h/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> index 08ea9cb32d0e..70f7f279fd35 100644
> --- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> +++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> @@ -12,9 +12,9 @@ / {
>  	chassis-type =3D "convertible";
> =20
>  	aliases {
> -		mmc0 =3D "/mmc@78000600"; /* eMMC */
> -		mmc1 =3D "/mmc@78000000"; /* uSD slot */
> -		mmc2 =3D "/mmc@78000400"; /* WiFi */
> +		mmc0 =3D &sdmmc4; /* eMMC */
> +		mmc1 =3D &sdmmc1; /* uSD slot */
> +		mmc2 =3D &sdmmc3; /* WiFi */

I find it hard to see the improvement here. If you really need this,
please merge this with the patch that adds the labels and add them on an
as-needed basis. That is, if you want to replace the paths by phandle
references here, then introduce the sdmmc{1,3,4} labels, but not the
other ones which aren't used.

Thierry

--7hXrrpViK7lmN/l4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQi0dYACgkQ3SOs138+
s6HrVA/+Km3OB1YYUeGd4+77nCO847LN8NdGvwGivbwClB7eSWBbdR6AinIPlsps
oJjLP4fIPcQ8T6p+QKPf2L4MT0AgQZZWJYcBg2EH7zMY1uaoZIyCE9B/e2jsEWz+
Vw3h/gt35XSVM0wVKkcuVDNlQWw7j+65C+u+xkAVh8v8tZrGEscgy0zz7a0001e8
Kk1yEkl+rAqqMaIMNrxxmlKW7X+JOOS1upfSGj8PgbRulCSkHOvbwaLPo/S2mvSI
Bbynh7E4wQ0MWm9eUMi2YRgdrPg4CFGj+PPjk7Xndg0OQZwbtFMmMdfP/Z7FStyI
MkCnlcwqiyfTzdGoWNKm052RTc1AjgXxVcoqfgkyptcB1zTXsRS2VWpJENF0PMMQ
mUeFD6idkJ6xufr6la2w+olnOprhaQNvnu/X7eAgHZqNN1ueLxeCMSUUf+sU6j+7
7RrbW9w4MEyOS1NzNphmjE5C3X0EtFfx3r1lVe4v7P0U3sB7BLGB30LCOaH21JCL
/1p8pDeM6jd9/G193BMr8gr1NPcw+lTJScU1khUUZEVXVoYbUkuA1NKm3DghyJmf
Gp3mkvvt5t6/A1fSOpgv8yYRvcjcaq22vS2AzMcsvbyJB5tcKHDkfmI0SCHpDyNb
bc/eT35SSUgT7WKvi1R1MNCZ8NfVHvoT1iwhPP6CCpgzdCbwv00=
=FM0o
-----END PGP SIGNATURE-----

--7hXrrpViK7lmN/l4--