Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cdd53e29ca3d8dbfdfa1a2520935e2bf9418313d.camel@gmail.com>
Subject: Re: [PATCH v6 5/5]  mfd: max77541: Add ADI MAX77541/MAX77540 PMIC
 Support
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "Sahin, Okan" <Okan.Sahin@analog.com>
Cc:     Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Caleb Connolly <caleb.connolly@linaro.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Date:   Tue, 28 Mar 2023 15:26:44 +0200
In-Reply-To: <ZCLi6MB/aHIf4lMr@smile.fi.intel.com>
References: <20230307112835.81886-1-okan.sahin@analog.com>
         <20230307112835.81886-6-okan.sahin@analog.com>
         <20230315175223.GI9667@google.com> <20230315175257.GJ9667@google.com>
         <MN2PR03MB5168249900206433A082875EE7889@MN2PR03MB5168.namprd03.prod.outlook.com>
         <ZCLi6MB/aHIf4lMr@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-03-28 at 15:51 +0300, Andy Shevchenko wrote:
> On Tue, Mar 28, 2023 at 08:26:41AM +0000, Sahin, Okan wrote:
> > > On Wed, 15 Mar 2023, Lee Jones wrote:
> > > > On Tue, 07 Mar 2023, Okan Sahin wrote:
>=20
> ...
>=20
> > For previous patch(v5), There was feedback from Andy. I did not fix
> > them.=20
>=20
> Why not? :-)
>=20
> > 1)=20
> > > They have same regmap except for ADC part of MAX77541.
> >=20
> > Extra space in the Subject.
> >=20
> > ...
> >=20
> > > +#include <linux/of_device.h
> >=20
> > This is my fault, I missed this comment. I will fix in following
> > patch(v7).
> >=20
> > 2)
> > ...
> >=20
> > > +static const struct regmap_config max77541_regmap_config =3D {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.reg_bits=C2=A0=C2=A0 =3D =
8,
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.val_bits=C2=A0=C2=A0 =3D =
8,
> >=20
> > Do you need lock of regmap?
> >=20
> > > +};
> >=20
> > ...
> >=20
> > Since I do not need lock of regmap, I did not change anything in
> > regmap_config (v6). Do I need to answer this question even if I
> > don't need
> > lock of regmap?
>=20
> IIRC the lock is opt-out. You need to explicitly disable it if not
> needed.
>=20

IIRC, regmap_read() is not really reentrant and it is used in the IIO
driver on the sysfs interface. So, yeah, I think you need the regmap
lock and better just leave the config as is. Yes, the lock is opt-out
so let's not disable it :)

- Nuno S=C3=A1