Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 08:30:24 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Roger Quadros <rogerq@kernel.org>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <srk@ti.com>,
        <r-gunasekaran@ti.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port
 for USB0
Message-ID: <20230328133024.ow6cvm22o2c5heem@untrimmed>
References: <20230328124315.123778-1-rogerq@kernel.org>
 <20230328124315.123778-3-rogerq@kernel.org>
 <20230328131810.x2j6uvwzhniclvwf@evoke>
 <3bd6191c-caa4-15a8-92ad-17a07ec085e2@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3bd6191c-caa4-15a8-92ad-17a07ec085e2@kernel.org>
Precedence: bulk

On 16:20-20230328, Roger Quadros wrote:
> 
> 
> On 28/03/2023 16:18, Nishanth Menon wrote:
> > On 15:43-20230328, Roger Quadros wrote:
> >> USB0 is a Type-C port with dual data role and power sink.
> >>
> >> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> >> ---
> >>  arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts      |  4 ++
> >>  arch/arm64/boot/dts/ti/k3-am625-sk.dts        | 44 ++++++++++++++++++-
> >>  .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi |  4 --
> >>  3 files changed, 47 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> >> index b2ca19e3042e..a3c3609833fd 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> >> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> >> @@ -225,3 +225,7 @@ ldo4_reg: ldo4 {
> >>  		};
> >>  	};
> >>  };
> >> +
> >> +&usb0 {
> >> +	dr_mode = "peripheral";
> >> +};
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> >> index cdc0858dd1b2..13fdaa9ce4e7 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> >> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> >> @@ -136,6 +136,35 @@ AM62X_IOPAD(0x01d4, PIN_INPUT, 7) /* (B15) UART0_RTSn.GPIO1_23 */
> >>  	};
> >>  };
> >>  
> >> +&main_i2c0 {
> >> +	typec_pd: tps6598x@3f {
> >> +		compatible = "ti,tps6598x";
> >> +		reg = <0x3f>;
> >> +		interrupt-parent = <&exp1>;
> >> +		interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
> >> +		interrupt-names = "irq";
> >> +
> >> +		connector {
> >> +			compatible = "usb-c-connector";
> >> +			label = "USB-C";
> >> +			self-powered;
> >> +			data-role = "dual";
> >> +			power-role = "sink";
> >> +			ports {
> >> +				#address-cells = <1>;
> >> +				#size-cells = <0>;
> >> +
> >> +				port@0 {
> >> +					reg = <0>;
> >> +					usb_con_hs: endpoint {
> >> +						remote-endpoint = <&usb0_hs_ep>;
> >> +					};
> >> +				};
> >> +			};
> >> +		};
> >> +	};
> >> +};
> >> +
> >>  &main_i2c1 {
> >>  	exp1: gpio@22 {
> >>  		compatible = "ti,tca6424";
> >> @@ -150,7 +179,7 @@ exp1: gpio@22 {
> >>  				   "UART1_FET_BUF_EN", "WL_LT_EN",
> >>  				   "GPIO_HDMI_RSTn", "CSI_GPIO1",
> >>  				   "CSI_GPIO2", "PRU_3V3_EN",
> >> -				   "HDMI_INTn", "TEST_GPIO2",
> >> +				   "HDMI_INTn", "PD_I2C_IRQ",
> >>  				   "MCASP1_FET_EN", "MCASP1_BUF_BT_EN",
> >>  				   "MCASP1_FET_SEL", "UART1_FET_SEL",
> >>  				   "TSINT#", "IO_EXP_TEST_LED";
> >> @@ -256,3 +285,16 @@ partition@3fc0000 {
> >>  		};
> >>  	};
> >>  };
> >> +
> >> +&usb0 {
> >> +	#address-cells = <1>;
> >> +	#size-cells = <0>;
> >> +	usb-role-switch;
> >> +
> >> +	port@0 {
> >> +		reg = <0>;
> >> +		usb0_hs_ep: endpoint {
> >> +		    remote-endpoint = <&usb_con_hs>;
> >> +	       };
> >> +	};
> >> +};
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> >> index 80e8b9b9a5f5..e3223088b90c 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> >> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> >> @@ -264,10 +264,6 @@ &usbss1 {
> >>  	ti,vbus-divider;
> >>  };
> >>  
> >> -&usb0 {
> >> -	dr_mode = "peripheral";
> >> -};
> >> -
> > 
> > 	How about sk-lp ?
> 
> moved it to sk-lp. see above in this patch.
> 

A bit confused. Looking at [1] vs [2], it seems to indicate pd controller at
0x3f as well? Am I misreading the schematics?

[1] https://www.ti.com/tool/SK-AM62-LP#design-files
[2] https://www.ti.com/tool/SK-AM62#design-files
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D