Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230327174402.1655365-1-kent.overstreet@linux.dev>
In-Reply-To: <20230327174402.1655365-1-kent.overstreet@linux.dev>
From:   Phillip Lougher <phillip.lougher@gmail.com>
Date:   Tue, 28 Mar 2023 14:42:28 +0100
Message-ID: <CAB3woddAP_6uOUJ4Yjj_PATme-CQao3p2JErBBtjtpzYxQejng@mail.gmail.com>
Subject: Re: [PATCH 0/2] bio iter improvements
To:     Kent Overstreet <kent.overstreet@linux.dev>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        willy@infradead.org, axboe@kernel.dk,
        Phillip Lougher <phillip@squashfs.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 27, 2023 at 7:02=E2=80=AFPM Kent Overstreet
<kent.overstreet@linux.dev> wrote:
>
> Small patch series cleaning up/standardizing bio_for_each_segment_all(),
> which means we can use the same guts for bio_for_each_folio_all(),
> considerably simplifying that code.
>
> The squashfs maintainer will want to look at and test those changes,
> that code was doing some slightly tricky things. The rest was a pretty
> mechanical conversion.

An eyeball of the changes doesn't bring up anything obviously wrong.

I'll apply and do some tests.

Phillip

BTW please CC me on the cover letter as well as patch [1/2].


>
> Kent Overstreet (2):
>   block: Rework bio_for_each_segment_all()
>   block: Rework bio_for_each_folio_all()
>
>  block/bio.c               |  38 ++++++------
>  block/blk-map.c           |  38 ++++++------
>  block/bounce.c            |  12 ++--
>  drivers/md/bcache/btree.c |   8 +--
>  drivers/md/dm-crypt.c     |  10 ++--
>  drivers/md/raid1.c        |   4 +-
>  fs/btrfs/disk-io.c        |  10 ++--
>  fs/btrfs/extent_io.c      |  52 ++++++++--------
>  fs/btrfs/inode.c          |   8 +--
>  fs/btrfs/raid56.c         |  18 +++---
>  fs/crypto/bio.c           |   8 +--
>  fs/erofs/zdata.c          |   4 +-
>  fs/ext4/page-io.c         |   8 +--
>  fs/ext4/readpage.c        |   4 +-
>  fs/f2fs/data.c            |  20 +++----
>  fs/gfs2/lops.c            |  10 ++--
>  fs/gfs2/meta_io.c         |   8 +--
>  fs/iomap/buffered-io.c    |  14 +++--
>  fs/mpage.c                |   4 +-
>  fs/squashfs/block.c       |  48 ++++++++-------
>  fs/squashfs/lz4_wrapper.c |  17 +++---
>  fs/squashfs/lzo_wrapper.c |  17 +++---
>  fs/verity/verify.c        |   4 +-
>  include/linux/bio.h       | 123 +++++++++++++++++++++-----------------
>  include/linux/bvec.h      |  70 ++++++++++++++--------
>  25 files changed, 302 insertions(+), 255 deletions(-)
>
> --
> 2.39.2
>