Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7fcb4be2-2c8c-dc17-3266-82c35a45eedd@suse.com>
Date:   Tue, 28 Mar 2023 15:57:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 0/3] xen/netback: fix issue introduced recently
Content-Language: en-US
To:     Paolo Abeni <pabeni@redhat.com>
Cc:     Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        xen-devel@lists.xenproject.org, stable@vger.kernel.org,
        Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
References: <20230328131047.2440-1-jgross@suse.com>
 <da45f73bcc2642260ef7718a6650dc535cc05c86.camel@redhat.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <da45f73bcc2642260ef7718a6650dc535cc05c86.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGVmMHJPZ1d2ek16WmE5TmJRaXBwWUFQdWx0R0lUQ2pJVWVZR2NlaWZtMW52?=
 =?utf-8?B?OVZzTEVxcG54Z216ckh1NlJOYzg5S1lxNnZ6SWd2TFFISnY4dm1id2pSak80?=
 =?utf-8?B?ampGck9ubHdVcmNvTU9GQUlGN3Z3V3l0cmhSajYxSHRWR2hhV21oTUI5Y3ZR?=
 =?utf-8?B?OE9VNVVpbFpsWUR1YjI5VTZlUC9FekF5RXR1WmsvVTdvOWx5VW5WcHBnakNQ?=
 =?utf-8?B?VEVmN3F1TXV6b0oxZk05OXQ1T3NDTnlnenpxSm9aNmpROU5yL2hka0NWcHB0?=
 =?utf-8?B?azFHc0pzQkhSd1Q1YlV3Nk5HTFV1WGhEZmFENlE3ZGNYVUVabFpjM2sxU2Ro?=
 =?utf-8?B?WkgrcVVxYXJieVpRQ25MVEJ3YXlIL0hjb09oTVZLbTQzSFZnalhTa0NVTzd5?=
 =?utf-8?B?R1NpR3R1djNFTTFERVozcDhvZG8vV1VrNE12NXNtTEUwT2FqeDVwUEhYbDNQ?=
 =?utf-8?B?VWtUc0h1S1pmb2laQ3VSRDlWekNaMjhQNHZncUU0UmlrUFo0dWJLTmdGOHZx?=
 =?utf-8?B?ZHhTUWVKRndmdm94QmFEM0dsVHg0YzdUOU9ndFNFOEsrZ1ZuT08xYzhJZ1Fy?=
 =?utf-8?B?U1VqVnkvcTFnNXZpRnRUK2tqVDYxM1NId04rcGRzNGpMbU5SaGFYa0NHcXla?=
 =?utf-8?B?YzMrYlpjOXY5NVArOVdtdXluZURNeDlycVp2NEpOOVI5UWpFanlmUCthQjBn?=
 =?utf-8?B?WDBRenRiS3VPMXRNdWN4Q1FMOXhndVJzZXhyNEtGdTVjbkNVLzVQZFpnQXZl?=
 =?utf-8?B?bVR2UUtMK1JVdjR5djRuUllGRU1XV0I2MTgxeWJKelRGcmIzWURnNkdHWXNG?=
 =?utf-8?B?aURlaUgwaXBYYUdSVzlyM3BjQ1RlSGNGcVhETEsrRWtENXFENXpoS2RqODNy?=
 =?utf-8?B?U3JtUXBZSVgzT3RyekY3dUJ5MERQTVlFMUlsa1kvUWVydVdTRm5SL0kwR1BH?=
 =?utf-8?B?SUV1QStrTXdGZXZ4S3o0S2xLRDNEZ2d4RkpGTzYycGV3VkdVNDhDQ2xOY0lG?=
 =?utf-8?B?S1ovSDk5Qy9lK0F5dDNPUU5KS05DeG9TTk55SnZibVNtUENzbTVDYnVMMnFE?=
 =?utf-8?B?b2NsMURLZjlucDZqR2RSdGNQVndNdHYrRm54Q1pLcGRlazV0NWdrWDEvVnRZ?=
 =?utf-8?B?V1JUbUlIR0pJaUxZdmlOTWxVYXhoTTBXdU5zckU3a29wWUhWTzVMblFzZHdG?=
 =?utf-8?B?VTZ0UnRsRytRUTAyU2U4RFRtTlA2WnhFR1JTcy9oeEZvVndSU0lMVm90b0Zk?=
 =?utf-8?B?ekdCa0VsSnBieXZjMFNvM212cmtiZERhd25ycXQ0YnFPRG9jcXBDcWZJYlFR?=
 =?utf-8?B?eGg3aUVlSVZmUDVjVUFIOGNpSmQ5N0w3NkZXUlhSM1g4VDI3OE9rZURnOUlX?=
 =?utf-8?B?Y1B5REUvMHZRMTNIS3dBU0lOQ3FuZVVXZjVycEN4YWZMZHlOSWZDK1NnRHBy?=
 =?utf-8?B?YXZWMjNqZTh6bHIxK0d5V3JYZm1YcE8xaHNQaHF2cGpGVXQrTkpUK3YvMWMz?=
 =?utf-8?B?SnJCLzMzaG5leSs4WmNBZGZEc3E3aW9EcW1TL0lSb1ZzbkF6dFlWZ3hLeFpP?=
 =?utf-8?B?R2QwMnF0cUx2KzlkVThUYVYxRFBvNVhEUENKTEF3UEExaUdhNEcxYWVvWStt?=
 =?utf-8?B?c1IvRlgvRXc4ZENtajNHZlMvNXNwVjZnT0orTDFPL0szQlRJRTBwcTU0M2N3?=
 =?utf-8?B?Zm5yWGdycE93VWwxdkRWUFJYV2NxOUwvNWlrVjNwVkNPYnNWOU5RcjhKYTB6?=
 =?utf-8?B?UkJRb3FiV3pyUEFWeElaT2FmV1VCNjMrbHRpMWxMVTNuenVsNjliNUlsbGJm?=
 =?utf-8?B?dnkxRXV2YUtvQnA1OFVHaldFZ3dHR2JleTdERzZGYkZBUTB4VVQ1NHppVFNP?=
 =?utf-8?B?OTM3YkZVbEFBbUd0dytzeXArNjkxRGttU1RHTm1veHZBWjNUYWdEUHkyUTdt?=
 =?utf-8?B?bFdiL2xPakgzY3R4eGFNZHVNZGhQKzBoQ1RMWDllUnFKZjc1aUk0TlBIWEJ4?=
 =?utf-8?B?UmtjSkM5eHZWZ2RBQmpweWdmN1ZBQnFIOTQ5Q3BqTkxLZXRPZFFadTF5cG9x?=
 =?utf-8?B?SDBHR1dObzB4aTdPTXNvOVNId3EyRzZlM1JMYTU0V1VucTA3cXJJNWovL1Ax?=
 =?utf-8?Q?atFtUP7SUBuJTGHLF5c/Q/Vsx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 076ed602-5b48-4ff4-ca55-08db2f945155
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 13:57:07.0760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ErKnn2eW9ki8FF24/p/klBK1wr7aFywRgIfCdLBZzirej1YKnLpF/7DODiZOPtraqxd1pTKk7pjzJMDw4jmuQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9657
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28.03.2023 15:52, Paolo Abeni wrote:
> On Tue, 2023-03-28 at 15:10 +0200, Juergen Gross wrote:
>> The fix for XSA-423 introduced a bug which resulted in loss of network
>> connection in some configurations.
>>
>> The first patch is fixing the issue, while the second one is removing
>> a test which isn't needed. The third patch is making error messages
>> more uniform.
>>
>> Changes in V2:
>> - add patch 3
>> - comment addressed (patch 1)
> 
> I misread the thread on v2 as the build_bug_on() was not needed and
> applied such revision. 

I guess it's not the end of the world if we go forward without that extra
check. It's a safeguard for theoretical future work which, as Jürgen says,
isn't very likely to occur anyway.

Jan