Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 28 Mar 2023 15:59:58 +0200
Message-Id: <CRI2JTK76CHY.PX9MOKSRGSE5@burritosblues>
To:     "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc:     <linus.walleij@linaro.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <a.zummo@towertech.it>,
        <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linux-rtc@vger.kernel.org>, <jpanis@baylibre.com>,
        <jneanne@baylibre.com>, <sterzik@ti.com>, <u-kumar1@ti.com>
Subject: Re: [PATCH v2 1/3] rtc: tps6594: add driver for TPS6594 PMIC RTC
From:   "Esteban Blanc" <eblanc@baylibre.com>
References: <20230328091448.648452-1-eblanc@baylibre.com>
 <20230328091448.648452-2-eblanc@baylibre.com>
 <202303280929448e41808d@mail.local>
 <CRI1AQ7OIF6F.2G26C7VQKL5P0@burritosblues>
 <20230328133429ff45c492@mail.local>
In-Reply-To: <20230328133429ff45c492@mail.local>
Precedence: bulk

On Tue Mar 28, 2023 at 3:34 PM CEST, Alexandre Belloni wrote:
> On 28/03/2023 15:01:05+0200, Esteban Blanc wrote:
> > On Tue Mar 28, 2023 at 11:29 AM CEST, Alexandre Belloni wrote:
> > > Hello,
> > >
> > > On 28/03/2023 11:14:46+0200, Esteban Blanc wrote:
> > > > +	/* Start rtc */
> > > > +	ret =3D regmap_set_bits(tps->regmap, TPS6594_REG_RTC_CTRL_1,
> > > > +			      TPS6594_BIT_STOP_RTC);
> > > > +	if (ret < 0)
> > > > +		return ret;
> > > > +
> > > > +	mdelay(100);
> > > > +
> > > > +	/*
> > > > +	 * RTC should be running now. Check if this is the case.
> > > > +	 * If not it might be a missing oscillator.
> > > > +	 */
> > > > +	ret =3D regmap_test_bits(tps->regmap, TPS6594_REG_RTC_STATUS,
> > > > +			       TPS6594_BIT_RUN);
> > > > +	if (ret < 0)
> > > > +		return ret;
> > > > +	if (ret =3D=3D 0)
> > > > +		return -ENODEV;
> > > > +
> > > > +	/* Stop RTC until first call to `tps6594_rtc_set_time */
> > > > +	ret =3D regmap_clear_bits(tps->regmap, TPS6594_REG_RTC_CTRL_1,
> > > > +				TPS6594_BIT_STOP_RTC);
> > > > +	if (ret < 0)
> > > > +		return ret;
> > > > +
> > >
> > > This whole block must not be executed when the RTC is already running=
,
> > > else, you are stopping a perfectly running RTC.
> >=20
> > I'm not sure to get your point. You mean that during probe, the driver
> > might encounter an RTC device that is already running with a correct
> > timestamp? How would this be possible? A previous bootstage or the
> > driver was removed then re-inserted again?
> >=20
>
> The whole point of having an RTC is that the time tracking survives a
> reboot so yes, I would expect the RTC to have a valid timestamp at probe
> time.

Oh. Oh I see. I did not think of that. I will add a check for that.

Thanks again,

--=20
Esteban Blanc
BayLibre