Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 16:43:21 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net,
        willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
        sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
        jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvel.com,
        edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com
Subject: Re: [net-next Patch v5 3/6] octeontx2-pf: qos send queues management
Message-ID: <ZCL9CbpBuH0M3OJU@corigine.com>
References: <20230326181245.29149-1-hkelam@marvell.com>
 <20230326181245.29149-4-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230326181245.29149-4-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aUMddOWto980XJP48KFBMPOe7tdNSHR/47jTSB1Q4U5uZZ5o74w1U56PRHut?=
 =?us-ascii?Q?9Q75n9X7y+SpFMJdC4RvWnPdpxXNB0p4brAz5FaANJTdcWRE/ln4dDrMULuL?=
 =?us-ascii?Q?3Rbnk6e+dU3qB5Tag3cUc7qxy7UqFi3TWdINc1AQbBciWJpzQ7XKroNARlbs?=
 =?us-ascii?Q?XrSz4/ty6v3hWiGfqIjHOYW4MFlfURUF/DEoFwb7M7CpO92e7pRktNPOru/y?=
 =?us-ascii?Q?4pAaCsjX/Aq6jn/4UxXuwj2ibNYSl35qEPtnWdGt0VcXndM/ZKc7xWZ1HVjV?=
 =?us-ascii?Q?MwOOXpN7LomFmuWlyPDGa9e6qTyFcEN95CefEWt5U6Fyv82rb1mEUUMyWfRY?=
 =?us-ascii?Q?mSYL2jO7TKyiA8NwYc+8t4TCI+3EbWa7RO0WyAh/1ZPy55d103L7s3GpvS1m?=
 =?us-ascii?Q?vScDhiiScak0oKuUIHaghmSoEAb7fdRVRPYLRmjHCo9WJONwtUnSMjTav9WN?=
 =?us-ascii?Q?0xRgaW4TGFyGacR7AEExx4ToV6xAfJc/+n9hZiLwU3+0hJABYr/ZAIhCsaPd?=
 =?us-ascii?Q?Z4rEqRDmIrOTa2tjFd/RHLuS21uZkTrXcwt8m0LvxAev0k8p4T/mlKoqWX1C?=
 =?us-ascii?Q?fmfOF8v11ze3p+U8OrEAw9IhrKmmIksUF4HtDGLTq/ntS8Imjb4z2S9MzOVv?=
 =?us-ascii?Q?s8Y42qvPTAuMxjXT3DSaXYc8ygM2uzRWdwYei0kQ7XxGYyawtHyU5gzYAzKE?=
 =?us-ascii?Q?AQsnOgNt3104/031ZmCOC7E0wcSMZutjeX7IU/q/spsN4U6GJS4JRo4pNM+A?=
 =?us-ascii?Q?VNe7tsCy7g0vuAXO3EmYaUuI73se3ePvKase6P+yz1GU4wLTueKjzTZCdO2Q?=
 =?us-ascii?Q?GD018FL3UcpAPc/AaFp5Yc7xMRXqrbIq1/ekCJBpCXFBux8c6WkyMrbBN22l?=
 =?us-ascii?Q?TNVaWOyUHT2UnjldCje4On0uslHu1RlWfQaok4Ohz9ymXw70IogpzUpXsY99?=
 =?us-ascii?Q?NrCEQTvTOaO5sskN3ZHD0z1+1eGDJyNQ+IBDn3DIZHfsKO5TFMOuRSnyQ2ZA?=
 =?us-ascii?Q?hxmiG2BxCnfg9emf+aOiHucgpMfoFhObxZxe12LxPUzups2FPrmLDsKSFi8D?=
 =?us-ascii?Q?Q9vJToa3bwsvfIAk0YNNLQjlrGRM76eBGrTsrl/iQIqqTAY6NMXzLF5OEnuu?=
 =?us-ascii?Q?uiViFZdlLLBIFUjtoMt44IKfrFTYs6qBqgVZxjB4B8uf68DXQCrhUyck9iFP?=
 =?us-ascii?Q?3C6mo6PgWBob+nNRWnW1deXP4XcQ/aAcf7zBP+GqEkYw6T080yPT7wDK5Tey?=
 =?us-ascii?Q?lLyE0l7U8D/M/dh8JodihAjT/Z6BTMf/UoVI5BNoh8aJ2gm0tPLCmBb/CCOz?=
 =?us-ascii?Q?dMmnHU5vddS8FWmkRa5F75EMzBAGwOK2wK7/pHu0HDGt/Q3enlnu3Du3IdNu?=
 =?us-ascii?Q?xtRb6/r74hQBWMaWz66YhKQrpfD+bOCUkq1EsbyQgUCCFFGY6VEoYpfWoROm?=
 =?us-ascii?Q?fYQmZ8Gc+E4zxCMFMlNdclG/rQPtmxyzrbGCJwHjuEeswTjD5SjphBrp5fjt?=
 =?us-ascii?Q?yOje84AXPY5KmKHsT50sKOqc85dbWvJW2G84j+2sKnfyUrsqIkAa4vkys6Uw?=
 =?us-ascii?Q?S/q/lzAZNzABpEoZX6e4omhxPmZ21mmy0WO9Fh9szJZUoViQdFL1jFsTcP0e?=
 =?us-ascii?Q?4UMSUzA4+oA2+pXNc+0IfJB/n9rTUFom9UI7yLFeEY1NQCsGSGdm3hX6ZCB9?=
 =?us-ascii?Q?Idn1kw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e53c10c6-7a50-4036-a68e-08db2f9acb12
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 14:43:28.3485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EH7uGga8fuQ0rY1LMEMZs0a1EosaSsDKHKWGhi0004C6y7cz6yH52437smrcZ+t9/NkwM2gctePkX0XqVdcRQ9DLYRxqFzHiM0UgmG89FJA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3667
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 26, 2023 at 11:42:42PM +0530, Hariprasad Kelam wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
> 
> Current implementation is such that the number of Send queues (SQs)
> are decided on the device probe which is equal to the number of online
> cpus. These SQs are allocated and deallocated in interface open and c
> lose calls respectively.
> 
> This patch defines new APIs for initializing and deinitializing Send
> queues dynamically and allocates more number of transmit queues for
> QOS feature.
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

...

> @@ -1938,6 +1952,12 @@ static netdev_tx_t otx2_xmit(struct sk_buff *skb, struct net_device *netdev)
>  	int qidx = skb_get_queue_mapping(skb);
>  	struct otx2_snd_queue *sq;
>  	struct netdev_queue *txq;
> +	int sq_idx;
> +
> +	/* XDP SQs are not mapped with TXQs
> +	 * advance qid to derive correct sq maped with QOS

nit: s/maped/mapped/

...