Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 16:44:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net,
        willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
        sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
        jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvel.com,
        edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com
Subject: Re: [net-next Patch v5 1/6] sch_htb: Allow HTB priority parameter in
 offload mode
Message-ID: <ZCL9QQSRBWEYrT/R@corigine.com>
References: <20230326181245.29149-1-hkelam@marvell.com>
 <20230326181245.29149-2-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230326181245.29149-2-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nvt/4pKcNe7z47hWIb531d7/oX4gaqw26p0SMh25qoMbJa6ek84R/twDn+f9?=
 =?us-ascii?Q?o7epjFQ2FDL/y6ZjM3M3esUd8P70TlzaGXsCBl+qTzqzLeybIouOv5j8kqEK?=
 =?us-ascii?Q?c96+E9qA++lwkCX/XleFY2RGgj0KuTduVPx1iEOfB1hFt9uOyf3eWXKzbSXn?=
 =?us-ascii?Q?E2K9ZeRutzfW+OPnOigRmJuiqb4srm8w1WCi9vXtQ4Jk/+PNldlPAfr1CcC9?=
 =?us-ascii?Q?RoSDpDsKulq+yEA7ojYTXMcRAt1MrglxmQqmXpXIY4Lgeg7HXI4W0kkqizwN?=
 =?us-ascii?Q?ZCwjjilQQLLmTFMW2vz7am2e3UHFgT7ovvgXe1Rmgjr1tPDYAYbc+ADBI1Da?=
 =?us-ascii?Q?cyB5NLahti1pB4OOsadP+ziGQYybBdeNQrJIw1oRNGr3hC4fAzUHKd6Coc/k?=
 =?us-ascii?Q?BHXPXRfzrvLjiCGxDDi0YD2IYdpSfP8sDtnPS7BLV1h1vHeVyWidcZuoHNzg?=
 =?us-ascii?Q?YoAtPZCzvma15jFGpbFavEd/AzwFEzs/a1iitDHdUBhVaF5jeEtXAFrG9f64?=
 =?us-ascii?Q?t7W5YemZ84QtrCHi61+SK1Kkgr2QRruMadxTghBZDM8RYGVbGJCQ0ZH/r91B?=
 =?us-ascii?Q?zmZVi6TMIoNH1c+ix6GBpRicuuLf1SRFBY37gcoQQwx/72Yru2UHn4n5ZPKS?=
 =?us-ascii?Q?4R7VgOWskvltaN6p5G+JLbrhrPPtG5qGm+vEcClXx65WoDKhv72QfGyIaoCj?=
 =?us-ascii?Q?sjTgpJTleLgPwxsH+SREXvZGN3V2f+bL1J2wvaXcVMohUaCS0WQPsEZdikTz?=
 =?us-ascii?Q?CtTniDL1UZ0d/VLvMdS1AVL8eraJM3qpwHjLvjFNu26pV37tz7QAhAkEUp52?=
 =?us-ascii?Q?Fweg7GgcRrnOhGmmzEgBXasjIRcou7XC+ZYymqltCsJqvrWRGy9jNyd+HZwW?=
 =?us-ascii?Q?B7WQhsFCJwpXA3U8sTIH1aTE8POjd8b3k8x+QDzF2rFudm9QMKIbJb1Yw+ds?=
 =?us-ascii?Q?CW8Sti00jETIKokUq2bB2TjqEyi3Yl4OMnal5hzsQebGUsv5oP35m/S105Eh?=
 =?us-ascii?Q?Mmmd3hDzwr+LQBb1Cq/Hp25uhjW4R4Ljty+bVqaE9XleKAOJtU6Hqs7JnMZj?=
 =?us-ascii?Q?uzdGvcM8cv90QqIEqHwqJHFmkCVu1wGc/PoK3dLEvgLrVtOSgTvz9QdIYM23?=
 =?us-ascii?Q?HuvCOZ6p7lXJ1E1BCHbj0+ctm4rMbh4Xsa6q5sYxh6zYe9gwZT4A8UZEILex?=
 =?us-ascii?Q?Kzvr4pJuAdmo0QRAUxZjwqq9pvKVdEMQxgSo4dBhz5E4GmqnQtBsM71Td/d5?=
 =?us-ascii?Q?uhq2UM+Hwm6ooscvVpr7Hm4NSzpu0t7YC8enFHCBY18YlxeyrqvLwBgEyfOu?=
 =?us-ascii?Q?L86NcwhMext9/trHUPYB5Z3rEakLes9fb/Cbl0IRBKcrrrIqiW+PuqszC+ce?=
 =?us-ascii?Q?uL0XFbkaViRg10YHKSY96kin3oAYVby0FX3QBywoqaEteQi77hGhZf5HU86x?=
 =?us-ascii?Q?mvy+/mUQMRx9cNrVaXSQkZkWYZ5skDt/195J71EwrRZq/I3e8FPjHb5eOO1I?=
 =?us-ascii?Q?XYNxcuadjc3jgtI1jRN8n52aXLbn1ZltaMAMdU3mWxvHTlV/0rauCBj/KPd/?=
 =?us-ascii?Q?5nITypMdde0kTV6NmWLkZ3LNltCEguoYS7SoR/tS1YrN7KQbSAv02O87bSrW?=
 =?us-ascii?Q?O3KYzi7LYfpLEt/bWNBg0KouzrAOUdgxyKN3nXvZ1vWk08ATDkMA93e5qlYM?=
 =?us-ascii?Q?ePTdAQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf336e79-ada7-4980-e552-08db2f9aed31
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 14:44:25.5750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aCed7MMxllQ7RVP6MBQk/LhT2y5+FGZbF+FKqYLkIGYzmTRRe8nu/0EgfHJWSiThvfl+RYmhQyQuX0B5q1Xdz31BHQ1dLNfgl47EW+dWcmI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4914
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 26, 2023 at 11:42:40PM +0530, Hariprasad Kelam wrote:
> From: Naveen Mamindlapalli <naveenm@marvell.com>
> 
> The current implementation of HTB offload returns the EINVAL error
> for unsupported parameters like prio and quantum. This patch removes
> the error returning checks for 'prio' parameter and populates its
> value to tc_htb_qopt_offload structure such that driver can use the
> same.
> 
> Add prio parameter check in mlx5 driver, as mlx5 devices are not capable
> of supporting the prio parameter when htb offload is used. Report error
> if prio parameter is set to a non-default value.
> 
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Co-developed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>