Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 16:44:59 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net,
        willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
        sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
        jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvel.com,
        edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com
Subject: Re: [net-next Patch v5 4/6] octeontx2-pf: Refactor schedular queue
 alloc/free calls
Message-ID: <ZCL9a5kXqMCx7n7L@corigine.com>
References: <20230326181245.29149-1-hkelam@marvell.com>
 <20230326181245.29149-5-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230326181245.29149-5-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fl10f2jP9tFLdcRdPhLgHL+qY+nJRr2JXqydG3rYqAIVNHIaDKcspV2TmhLu?=
 =?us-ascii?Q?MiClXriXp16ur12asc/87diJqWbhUc5Fhf1msKr5T6MIr2cmhxebghprk/gf?=
 =?us-ascii?Q?E8Nnq99vTdk8r3yLLDI0ZIVwrfnXgNJL0wjl86trxDewVCHzqOvEAEMrhusU?=
 =?us-ascii?Q?7ZUQc6Np7PmfjdpwnjO92i0uVBIF09X3bx3loxCvLZ6UwUyO8DXZXZm+NRWZ?=
 =?us-ascii?Q?Zb7+SGwjEWynoXPQ+qGVrvPG+weeLi2dCrEUbWKeYr1n7Ym98RKgwxrXZQaQ?=
 =?us-ascii?Q?hB9fMwe3FOHxm8P0WpJcUiJiVmU6tzOOJLjpairIKFRTrfGYh6Eq91mJJPTr?=
 =?us-ascii?Q?CxZVDJHwALCFBCteHE4tTUBJvtOSX4n8LhLEEuA0k4HCoO/WsrEpSdgwQRDA?=
 =?us-ascii?Q?8Quy0hY8vW4R+H4jDayxbkfoMvN0HTq9nFJzkDDw6jFXE3drWxNSTPIm7GP3?=
 =?us-ascii?Q?Z1FeemJwqUSD0KWRfZiVLVyiPWgj9p9rhelwacd69DqIWo4sIVgkthFFqyYj?=
 =?us-ascii?Q?/1DW4+IVRFljvK3csBUKi7zn7GaUArBwnaYNQt8EnCkwgNWKRTqhiIYNo6Tc?=
 =?us-ascii?Q?gTiApEDDUcCNjln2mcDqFXVTHgnGb8qx/9B38hiN9RrR/35FChNP5P+p3JZS?=
 =?us-ascii?Q?/aLaM30BAC/p/gYe+7kg99eu4oTf9zB77B/zgPwS5jmjryiyYBbO0Z1n8gFt?=
 =?us-ascii?Q?/pqxz3e+/zGDEqUWd9kvftmqG1KXnP4ppAOT60QetKvXrkBhMPuHssUWJdKi?=
 =?us-ascii?Q?Vb3S5qfwb2qhuqCRKZExs1aAEgurgO54JMaxV+v7ZcZLfE+78/saE8Q37mra?=
 =?us-ascii?Q?UunCz+qEFhvxrtlpoVOCTcolJXb0XH3dYrQSC4jJPEWsgtR9hKaeilyoja4U?=
 =?us-ascii?Q?hiyKhcsx9p7jMFrOqdLO2Qgu9fVAjqwEXnkQwoG1E81ZCKz+l3iLm1DWg5kT?=
 =?us-ascii?Q?MSUwwLxHPEuA7M4OZL31Qi0v5k7U+w0ZQZ4t2RIm/gUIXjscJpGb4CvWfIH6?=
 =?us-ascii?Q?wbc9AqaKndbmN/MH7fRAffoVCbk+tki47F+iwMqLQkHYOBFrND2eUAX++G/H?=
 =?us-ascii?Q?KcCs9FxsbddJoFidqwYnBZ3hGB8lkQWYT6lhHazFl7qRRx9nyGyJlMIX0kC6?=
 =?us-ascii?Q?74Dgdxv5gowyqsFqjGT8/MHocVL/g2+TvLFf3AVuz0+gzpwf5z8b9NxGhR9G?=
 =?us-ascii?Q?uxL3uhE/lfN+fyfA2UtrVaMU9p5DfcxZgSAxx5UkXrB8HEuTdcGXVXTKU39q?=
 =?us-ascii?Q?WPzloqn3m6TKJEyKwXpqUztZQXiBdVTByrPhnXZ0FOK2eLPX2PDh9FwUxv1F?=
 =?us-ascii?Q?9X8dXF32NMRo/zl1E3IKJzoK6cdaAzcNQTfCsC07mryz3gMk8Z+7lTXzjORw?=
 =?us-ascii?Q?NfNhAwE/DcY2D1SKnRarPUoqFeozyDNs16qG5dmvZf/NDo7+2NuDv+9uL+L4?=
 =?us-ascii?Q?kieoQWVGWZPX6Q6szJH6DykJ6NCdki6aDEsVs1/FuQioWT0IagnLgekwLvjS?=
 =?us-ascii?Q?/xwHNPRnr5MvY7RD/AuW8zSeguHckwzcDidUdxyJe/D7E0ErDeUWesqEdkXG?=
 =?us-ascii?Q?/Lf4R6u5cx1LA90KbEyVqXI7XJMX8OinVvb8eHkxaYaxkpCHMNSw+G44IrPU?=
 =?us-ascii?Q?AVEmzPvBHI20E5LQdIX+zM5szOVz+ChY0FBTx6Gd2FZwQR6W+0EH5Na06gxh?=
 =?us-ascii?Q?koL/gw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33c15ac5-0a0a-448d-dfcb-08db2f9b0522
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 14:45:05.7862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yBK96AksLaZjC1lkCxpfcp5NxHnLKJMI95Vfv74RloU7fw2crLjinyPT+FW1M258cV8mIdY5Kr4f+8hTTrbq0jqldddxc/zHw77Fy2mNTD0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB4635
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 26, 2023 at 11:42:43PM +0530, Hariprasad Kelam wrote:
> Multiple transmit scheduler queues can be configured at different
> levels to support traffic shaping and scheduling. But on txschq free
> requests, the transmit schedular config in hardware is not getting
> reset. This patch adds support to reset the stale config.
> 
> The txschq alloc response handler updates the default txschq
> array which is used to configure the transmit packet path from
> SMQ to TL2 levels. However, for new features such as QoS offload
> that requires it's own txschq queues, this handler is still
> invoked and results in undefined behavior. The code now handles
> txschq response in the mbox caller function.
> 
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>