Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b16d9ae7-625d-c5b1-d7bb-42bac8445125@oracle.com>
Date:   Tue, 28 Mar 2023 10:56:33 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 3/3] scsi: blocking IO when host is set blocked
Content-Language: en-US
To:     Ye Bin <yebin@huaweicloud.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Ye Bin <yebin10@huawei.com>
References: <20230328143442.2684167-1-yebin@huaweicloud.com>
 <20230328143442.2684167-4-yebin@huaweicloud.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20230328143442.2684167-4-yebin@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkNGVzVWTmJlSkp4K0lsd1JldXdEeFFReVJoRUJvMERMQTRveExiOU9scXZW?=
 =?utf-8?B?aGJFM1FQa3dpYndscDdUU3UwaWszWXRXSmlLd0JLL240MkZMa200U0NpUzdW?=
 =?utf-8?B?ZCtRZWJiV3k2NHVPNmFoQ0F5ckJLbmI0QVMxeTZlbWIxalM4amZSNzc0R1FW?=
 =?utf-8?B?c0ZJMlQwT0lHQm9HL3R2ZnNTRHdzenNIeGhpRlpmMklQWUJSN1VZRDE5YzZV?=
 =?utf-8?B?T0E2SDlNZ1BwbzdHNzVibnJKa29aa1F2ZDAyaWw4aFgvMUlzWkFJRndSeUVl?=
 =?utf-8?B?RkJxYXR6REdQZjdZLzRIZWlqVTlyNlpxUzlEbmQyZDhZUi9uSzhjY0FLSHJX?=
 =?utf-8?B?ZFJ2S2tvQjBrNUtCM0RKUFRFaHh3dVNMSVZUR01CaENuT2xQSEpMSTBvSlMv?=
 =?utf-8?B?YUN0dmJhYU9Vc2dwbDVaS2xmdnExVG5RN0hoM2ErRzR4TTVkVVdSZ1VrdDdK?=
 =?utf-8?B?WnhvL1JKMENEdDBoYnR6L1FmR0cyWjRHSmxuVHI4N2hmV0hJYXZNK1h3eDZK?=
 =?utf-8?B?NnJzSlJUN0RnQTdUYnJFdDhkVHUxR0hxd0hBMGc0VDB0dk9HdTg5ZFFSekQ2?=
 =?utf-8?B?Uis5RkFENUN6Z295ZlljdUw3Lzd0bWJaV1N3Mm9tdUJVSzVvcUpYeDQ0QVIr?=
 =?utf-8?B?YnZ3SEQ2R0lLK3BuZVJkbjl0T3A2ZjBEd29Tb1FqNnkvYmVwUUN4YkErekZH?=
 =?utf-8?B?SGtwQzVWNEMwZ0duNmp4QWFNeW5wVnpiWDZFT29ZaDZxeHhVQXNNeW8zVS9G?=
 =?utf-8?B?OUlVN0ZqZ3AxOTlPaVFuWmZ4c0FkRHV6QXdtc2V5dXR3a01nQTV6Z3RkK1U2?=
 =?utf-8?B?eDcweXByNzlqaUY2NUlMN1hxNS9XNkR3bVNMeVFjQzFtRHZmeEVNSlFkbUtv?=
 =?utf-8?B?RzNMWEZCNXVGeWJBZ1YycUxjM3cwWWE4Ty9IdndLVkdpdGdSS3hYTjAyb29L?=
 =?utf-8?B?Zk5mdSs3OVhpeFlFTE5pOUFCWWRaUjRLaDJGTnk3ZEhUSDc0elFWelNkR1hN?=
 =?utf-8?B?TVhoYkNGbkJqeUVaYkt5ZS8vSVN3N25xTzlhSEppc0JaTUZFMmJacW1rOGF6?=
 =?utf-8?B?QThZMUxxRm5HL0lpSm1qQ2hFMjRKQ01ybzgwaUM4WEdlV3hPWExrMjFWZVcw?=
 =?utf-8?B?NWNIcVBoTDBhZW1NaUtJVW5KK1RMajV5UktwTDRiY09EcDExK0QxeDZtMENY?=
 =?utf-8?B?djNoeTFMazJTMzZQWTM0SmJtdnVFZ0FBUU05Rzd3V0dFMm90Nlh5YStxZ3J2?=
 =?utf-8?B?dXJHNlVMV0pYSnprclVpdk03LzF0UmNJckJPWXp5djZ6Uk5JZEpvL1VNUnli?=
 =?utf-8?B?QWRxc1ozQjcvZkdrZUJzaS8zV2RXUi90T3RMblV1TjRRbVhDTXY1UmlieGhF?=
 =?utf-8?B?d29rb1MyamZZcVprVzQrdktVZ3FteVgxS0ZiS0tnNnlHcnVDbDJZNFI0cnVp?=
 =?utf-8?B?a3I5ZnlzcFJSQ05yMS9raERtOHBZajVsNXZjL2JieXFMYWNSb0kzMXhtS3hh?=
 =?utf-8?B?THVNWm14YTVZMGxRYmNHNUZ5RHBpcWsvdzRyRHpMYXRjSHJ3R09NcnJMRDR3?=
 =?utf-8?B?UTdjQmFQYlRIVStiWjZFNHpyL05WSEFDeEVwSmdNV1dnWHBrZVhlWWlEeFZp?=
 =?utf-8?B?TUFaS3JXQVVWMUNseUwxK2QzSU9nNjVldjBsdzRXL1dxQjJ2Rmxkd3IrMWpK?=
 =?utf-8?B?cGorTVAyNmlkOVJyT0lsVHo5Z0IzamRsU1ozL2J6UnFHNk4vc3M2YU0vcGRP?=
 =?utf-8?B?Rkp6T3FYUVowNEZtZkNKdG13NnJwbFN6Y2V0MW91S0hlWVcxWkgydXZqd2d6?=
 =?utf-8?B?M1p0M2c4eWZyTnVHVlBuS1F5YnNjZE9NNDNXQTVCYkMvVWkxNGdBSkx2Z1Bl?=
 =?utf-8?B?MGhOQmJBcHlacm1aMFFXUnhKYTVjei9xcm1oRDgybURQbHBrL25sb2RwMm9o?=
 =?utf-8?B?Ui9TMXZrTTE0Q3JoZDJlc1JhKytrakFycFN3WVJKRXVSUXAyZW01WnZiZ0RI?=
 =?utf-8?B?amc5QVZPN2ROVllBNS94RE1nNW1KMUhDMXN2eVVYa3BBOHc2UjFxQmdiZUk4?=
 =?utf-8?B?SWQySENEeEZsMjJjblFvYmlRWEpLb3RKRDU4UjFzczEvZjQzY2FYTG83YzRx?=
 =?utf-8?B?SXdHbTBReE5GNjhFUkxKb1diMXdkUVplWUJrQ0pFTTNrQ2Z5TnpVU0tYQ0RC?=
 =?utf-8?B?Q2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wKY7gEXHFIHgjLYen+jIIsTBtjj88My8QtMUaC/5XlCiepiM+cpUNQhAAJ0hEThbM7iE7kQgDLbzVnhx2KF9thBDZGdmCyVKAIBwXjQzfhd3Lmd+gGvBKq3lEQ/+2lGhCyJRye5uqTqPWEAyTKAIoe03TmG8HsujY3p+XMM/oMC5M+iRarLoD6sQnDXyJERfPHvQGPTdw4fYx5WL8xHGfoPVBE/r9kQGcZE2c+gI6B3fbbFPp6T5ui1GSrCfCEwpJbCgO1ounPyR9y/MwbKGY06UTXeR5mZTzfCehrdrboa/ACBdJDPgsFOCSfIXxT6RImdPuVBZeLPJTTgGjb/9x5ZWvfkTjEs2hs9vQyuevyin0gK3PdprRPnZR3/3v9KgYXUY84goYDBvdP4C6y5ixknNPFfcl3/xgFtbjMyGG9DH/ajVCEsuGVH5hgrjhBaBHIefDJ3KuStxvySEmkallioIZ9S1/iWz9VH6cMLgwULgO1wZDxzlBCXffaWlNt+JVfHsK69gvDi9OXFk6dV+z2zrDDnkYDCrc+e+bk23Uxl3XFZx0YY/X/K0GTS1fVB9FtRw15hvw8m1p5Wvg4p4TzMSGmSD5xdD0F2SoM1cGnKpCdlqaLeBGV7KAp0HtrQjiXmitATO6Z2NzvjgjGhjJQyshQqIZ2eCkbsfQ9PS3W3hdG2zzDdJMD/5BjtSKT+wkNTA6xPU5i1xKr7dAICJZhxqinP3vxtjn9WrTlWP8yxu4tfgbhS5ctTPvfx5+5Zk1FYsMN0nF1xHFJ/caCtU81jVz9G9esIeFzEgFBMzeDwI/aMCzdtbvh4i2vGCvvPujm1fdxNNiuTXV1pJf4zfdkxkdASDMc0gXRGETgRONVJuVbD//Us984yiJwKLp6wf
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 707d40e4-2247-427a-a24c-08db2fa5021b
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 15:56:35.6470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KBvGJ6PwBBC/WMC+sDyGiwZw+3sT8LGBs/Ww7c/L+BOshVru6gV1e/Je76CqOatuGijZ3Hc6lyfrG7QuwmfwiFp+HNhbLbkTgaviKhauOVs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4605
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-24_11,2023-03-28_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0
 suspectscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2303280124
X-Proofpoint-ORIG-GUID: FdwdfkYiGLmDS2_UPTUMjrgeo-IWKSWa
X-Proofpoint-GUID: FdwdfkYiGLmDS2_UPTUMjrgeo-IWKSWa
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/28/23 9:34 AM, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
> 
> As previous patch introduce 'blocked' sysfs api to set 'host_blockio'.
> If 'host_blockio' is true will blocking IO.
> 
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
>  drivers/scsi/scsi_lib.c  | 2 ++
>  include/scsi/scsi_host.h | 5 +++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index b7c569a42aa4..20d618300a46 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1724,6 +1724,8 @@ static blk_status_t scsi_queue_rq(struct blk_mq_hw_ctx *hctx,
>  	}
>  
>  	ret = BLK_STS_RESOURCE;
> +	if (unlikely(scsi_host_blocked(shost)))
> +		goto out_put_budget;

You can just put this check in scsi_host_queue_ready with the
host_self_blocked check.