Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <970b8475-a52e-9adc-65cf-5a95220bd35b@samsung.com>
Date:   Tue, 28 Mar 2023 18:02:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
        Thunderbird/102.9.0
Subject: Re: [PATCH 2/5] orangefs: use folios in orangefs_readahead
To:     Matthew Wilcox <willy@infradead.org>
CC:     <martin@omnibond.com>, <axboe@kernel.dk>, <minchan@kernel.org>,
        <akpm@linux-foundation.org>, <hubcap@omnibond.com>,
        <viro@zeniv.linux.org.uk>, <senozhatsky@chromium.org>,
        <brauner@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <mcgrof@kernel.org>,
        <linux-block@vger.kernel.org>, <gost.dev@samsung.com>,
        <linux-mm@kvack.org>, <devel@lists.orangefs.org>
Content-Language: en-US
From:   Pankaj Raghav <p.raghav@samsung.com>
In-Reply-To: <ZCMF+QjynkdSHbn0@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
CMS-TYPE: 201P
References: <20230328112716.50120-1-p.raghav@samsung.com>
        <CGME20230328112718eucas1p263dacecb2a59f5fce510f81685f9d497@eucas1p2.samsung.com>
        <20230328112716.50120-3-p.raghav@samsung.com>
        <ZCMF+QjynkdSHbn0@casper.infradead.org>
Precedence: bulk

On 2023-03-28 17:21, Matthew Wilcox wrote:
> On Tue, Mar 28, 2023 at 01:27:13PM +0200, Pankaj Raghav wrote:
>> Convert orangefs_readahead() from using struct page to struct folio.
>> This conversion removes the call to page_endio() which is soon to be
>> removed, and simplifies the final page handling.
>>
>> The page error flags is not required to be set in the error case as
>> orangefs doesn't depend on them.
>>
>> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> 
> Shouldn't Mike's tested-by be in here?

I mentioned that he tested in my cover letter as I didn't receive a Tested-by
tag from him.