Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sahin, Okan" <Okan.Sahin@analog.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        =?iso-8859-9?Q?Nuno_S=E1?= <noname.nuno@gmail.com>
CC:     Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Caleb Connolly <caleb.connolly@linaro.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: RE: [PATCH v6 5/5]  mfd: max77541: Add ADI MAX77541/MAX77540 PMIC
 Support
Thread-Topic: [PATCH v6 5/5]  mfd: max77541: Add ADI MAX77541/MAX77540 PMIC
 Support
Thread-Index: AQHZUOiqG6ZyiGxaUE6S5aTx5qv2Ta78K/mAgAAAKICAE8FVcIAAWNsAgAAJvgCAAAWSAIAACOQAgAAEs4CAAAR3AIAAD8MAgAACyAA=
Date:   Tue, 28 Mar 2023 16:01:21 +0000
Message-ID: <MN2PR03MB51688CAF5DDF0628ED6B0B06E7889@MN2PR03MB5168.namprd03.prod.outlook.com>
References: <20230307112835.81886-6-okan.sahin@analog.com>
 <20230315175223.GI9667@google.com> <20230315175257.GJ9667@google.com>
 <MN2PR03MB5168249900206433A082875EE7889@MN2PR03MB5168.namprd03.prod.outlook.com>
 <ZCLi6MB/aHIf4lMr@smile.fi.intel.com>
 <cdd53e29ca3d8dbfdfa1a2520935e2bf9418313d.camel@gmail.com>
 <d2bed74b-9eb9-45af-8f45-ad2c2889024a@sirena.org.uk>
 <fc07de9af0b691fbd3a5915c8293f0c7ad4c4e06.camel@gmail.com>
 <ZCL7J5a7UZVayQVS@smile.fi.intel.com>
 <60bbad1b38b8e3c9c3efefb0fb7b8d3cad7fa98c.camel@gmail.com>
 <ZCMMHl5ENSuCstFV@smile.fi.intel.com>
In-Reply-To: <ZCMMHl5ENSuCstFV@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-9?Q?cgEWp12vSWhPuUU6cp85ptmmAi4jdL9RyZUhvkZ2H0d0StOz6Box66AI1G?=
 =?iso-8859-9?Q?cZE37kDt1MZka74+3/xPVhUAea5IUEw0D2nZ1EV0tgjkaiu4GHQSL2+7j0?=
 =?iso-8859-9?Q?IbuGcJq5+5kzq6lB3CyuVk5HQEjXLfyv95ZfbfDO9DeIoC8IXsUagohxM1?=
 =?iso-8859-9?Q?Acdv+V73kQaJ/f9wcUTwj9m1bxUP4GdykHBopnSomVJm3fYrS1YGRiomgC?=
 =?iso-8859-9?Q?wZT+9nUD+M7tn2BHsPaDX5OJz+CtUaCbR5eBqAp3xa3W5Z0P1Y/lSug6+0?=
 =?iso-8859-9?Q?sif6KJo5bzkxOnEie7bR4Vm90rzSGFo512i7HL0209k4D0Hdft8DINEVtP?=
 =?iso-8859-9?Q?eNtU6EHob80m75liHwr4bfuzE7Y11CbzcwSqAfgu98Rfqccf6TqR85mn8w?=
 =?iso-8859-9?Q?diBSe+QiAc/CV1CEc16KJTW6HnrqBE6H67PzfYzMfMQdnKxRUVnbQTOPZF?=
 =?iso-8859-9?Q?IIQJL1ZaxBC41mq2duDzg6flHXSEt3w28Ike63A8uIJuQYy4iwwwo7apX4?=
 =?iso-8859-9?Q?lA6h1PYD0YYVuriqCqPOT+sDX6UOIHB/pYG50MSRQFeFgSi8G1l8aoVcbw?=
 =?iso-8859-9?Q?9waRHJZhXjJeOcNDaJ7VoxUf7JiC+24F5U8B7L2QkLzrJjfS/PrdZhZ5Fy?=
 =?iso-8859-9?Q?CR+ioR5hh2ew0xeLNVf0eRo3nDKaYOh43hrYNtRY0ljwpk+em71HfAwGO1?=
 =?iso-8859-9?Q?Oeea/3vcoATLWB8VI0GCnUMcOKMh49TRg/kIEPPbXuWZLLesukGXgFjXdr?=
 =?iso-8859-9?Q?BipDHRwPQ1mWqdnYEn0u3aEo2QPKscT0Ow5aaEu8ud9O56M0F2Fxg2TUkc?=
 =?iso-8859-9?Q?3by2/ilVeWj0LJGYBICnsDzdTs2Nsi1F0924fMo3q6T5Ku3kpZJVvhPpz2?=
 =?iso-8859-9?Q?eUaTnBdNVwvJyCHg0HKqVNfnMHZbL3KMXDpTZFM3xjIchyM3v7pZrqeS4S?=
 =?iso-8859-9?Q?8dTytrVk0xJr1wMnK4IUp+BNuCYghab+rCu/B9MsoJygnobye868h3rNaV?=
 =?iso-8859-9?Q?K/JiGoc/8QcCGe0IATbwKAuNjyTyr1e4IEw3HMAg1R0pzWXr6d37xn0XYA?=
 =?iso-8859-9?Q?GYaLL8esikqs7Fjms4xA6Vz+xeToTVi/gTxGHUtKhbtyivKRBxv3KGBQhp?=
 =?iso-8859-9?Q?TqnvPAFY9GPkK6nOQqsF4PMFRwK8hyE+Kg4HEY3LpFrf1tP34OyWIk9nx3?=
 =?iso-8859-9?Q?2Cw9xeBGVSp68OSuVR5JjJ4tfQ/0bCwCxFOICQSL13SUE7aqANd0/Aex25?=
 =?iso-8859-9?Q?DUSP57J3HyPcwxwBaPtteHIahfMOic480wwcEyLAMCDpLH6ElumF+CUFQN?=
 =?iso-8859-9?Q?AsGn7RwYqdzrX3cpJYL+1HTk3VLVSg8PtlLiXwGomexYdzFuaDiD6X5J9T?=
 =?iso-8859-9?Q?qFNpiLlaA+OeoXL9RIpe/xj5L/mUR8hX3I4TcV6NCexaXrhLQYR1rnNK8H?=
 =?iso-8859-9?Q?hkHyB+SZoDeJmeSOFY6Qz8KwhIP8qGbAB0AfPNVGMR7PCNZy6XvV3CYtfT?=
 =?iso-8859-9?Q?X/t9GqBxyGvsIMqLg5affGd8eWQYGcI02y/9YKnlXQ2ZVHO8Cv1QkU9m1G?=
 =?iso-8859-9?Q?dwKzv7R6tFufJCOH2w8Q7sM5UAuAc3eQ7D5rjjFmN0NPNnP5g+aI/xL6zu?=
 =?iso-8859-9?Q?ua8tqSejtPn6DefRoEmbWn2FmFn4K24x60?=
Content-Type: text/plain; charset="iso-8859-9"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR03MB5168.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 887d6b2f-0f55-4ed2-ef35-08db2fa5ac67
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2023 16:01:21.1053
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DQLNQQtPWmuYK72pkQOayIbxJZJgl2F1ljFPJxlitP3fAEjoVRFMKFj+a/zrAX/lAj/YKnnuMjn+Mn0hES8dnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5759
X-Proofpoint-GUID: oEygBh_I08DWOPMso1Sk6HUngXHtgJPo
X-Proofpoint-ORIG-GUID: oEygBh_I08DWOPMso1Sk6HUngXHtgJPo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-24_11,2023-03-28_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 priorityscore=1501
 impostorscore=0 clxscore=1011 spamscore=0 mlxlogscore=630 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2303280125
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Tue, Mar 28, 2023 at 04:51:18PM +0200, Nuno S=E1 wrote:
>> On Tue, 2023-03-28 at 17:35 +0300, Andy Shevchenko wrote:
>> > On Tue, Mar 28, 2023 at 04:18:30PM +0200, Nuno S=E1 wrote:
>> > > On Tue, 2023-03-28 at 14:46 +0100, Mark Brown wrote:
>> > > > On Tue, Mar 28, 2023 at 03:26:44PM +0200, Nuno S=E1 wrote:
>> > > >
>> > > > > IIRC, regmap_read() is not really reentrant and it is used in
>> > > > > the IIO driver on the sysfs interface. So, yeah, I think you
>> > > > > need the regmap lock and better just leave the config as is.
>> > > > > Yes, the lock is
>> > > > > opt-
>> > > > > out
>> > > > > so let's not disable it :)
>> > > >
>> > > > All the regmap operations are fully thread safe.
>> > >
>> > > Even if 'config->disable_locking' is set? I think that is what's
>> > > being discussed in here...
>> >
>> > In case the driver has its own lock to serialize IO how on earth the
>> > regmap lock is needed. That's what I asked the author of the driver.
>> > He told the code
>>
>> Well, if the driver has it's own locking, then sure we do not need
>> regmap's lock...
>>
>> > doesn't require the regmap lock, and I tend to believe the author.
>> > So, why to
>> > keep it?
>>
>> However, if you look at the adc driver, I can see plain regmap_read()
>> calls without any "outside" locking.
>
>Then author of the code should know what they are doing. Right?
>
>--
>With Best Regards,
>Andy Shevchenko
>
Hi Andy,

Actually, I do not want to disable regmap lock that's why I did not update =
it.

Regards,
Okan