Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5865a840-cb5e-ead1-f168-100869081f84@samsung.com>
Date:   Tue, 28 Mar 2023 18:17:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
        Thunderbird/102.9.0
Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio
 end_io handler
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>,
        Christoph Hellwig <hch@lst.de>
CC:     <martin@omnibond.com>, <axboe@kernel.dk>, <minchan@kernel.org>,
        <akpm@linux-foundation.org>, <hubcap@omnibond.com>,
        <viro@zeniv.linux.org.uk>, <senozhatsky@chromium.org>,
        <brauner@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <mcgrof@kernel.org>,
        <linux-block@vger.kernel.org>, <gost.dev@samsung.com>,
        <linux-mm@kvack.org>, <devel@lists.orangefs.org>
From:   Pankaj Raghav <p.raghav@samsung.com>
In-Reply-To: <ZCMFcTHkTe/1WapL@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
CMS-TYPE: 201P
References: <20230328112716.50120-1-p.raghav@samsung.com>
        <CGME20230328112718eucas1p214a859cfb3d7b45523356bcc16c373b1@eucas1p2.samsung.com>
        <20230328112716.50120-2-p.raghav@samsung.com>
        <ZCMFcTHkTe/1WapL@casper.infradead.org>
Precedence: bulk

On 2023-03-28 17:19, Matthew Wilcox wrote:
> On Tue, Mar 28, 2023 at 01:27:12PM +0200, Pankaj Raghav wrote:
>> -static void zram_page_end_io(struct bio *bio)
>> +static void zram_read_end_io(struct bio *bio)
>>  {
>> -	struct page *page = bio_first_page_all(bio);
>> -
>> -	page_endio(page, op_is_write(bio_op(bio)),
>> -			blk_status_to_errno(bio->bi_status));
>>  	bio_put(bio);
>>  }
>>  
>> @@ -635,7 +631,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec,
>>  	}
>>  
>>  	if (!parent)
>> -		bio->bi_end_io = zram_page_end_io;
>> +		bio->bi_end_io = zram_read_end_io;
> 
> Can we just do:
> 
> 	if (!parent)
> 		bio->bi_end_io = bio_put;
> 

Looks neat. I will wait for Christoph to comment whether just a bio_put() call
is enough in this case for non-chained bios before making this change for the
next version.

Thanks.